Commit Graph

11 Commits

Author SHA1 Message Date
Sander de Waal
b0ff189fbb ftpd typings: error and result can both be undefined for readdir, open, stat in FtpFileSystem. (#28707)
Please fill in this template.

- [X] Use a meaningful title for the pull request. Include the name of the package modified.
- [X] Test the change in your own code. (Compile and run.)
- [X] Add or edit tests to reflect the change. (Run with `npm test`.)
- [X] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).
- [X] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).
- [X] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).

Select one of these and delete the others:

If changing an existing definition:
- [X] Provide a URL to documentation or source code which provides context for the suggested changes: 

```
import * as fs from "fs";

fs.readdir("./non-existing-dir", (error, files) => {
	// Will print "error: ..."
	console.log("error: ", error);
	// Will print "files: undefined"
	console.log("files: ", files);
});
fs.readdir("./existing-dir", (error, files) => {
	// Will print "error: null"
	console.log("error: ", error);
	// Will print "files: ..."
	console.log("files: ", files);
});
```

- [X] Increase the version number in the header if appropriate.
- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ "extends": "dtslint/dt.json" }`.
2018-09-10 14:51:48 -07:00
Andy Hanson
45c9246c09 Remove esModuleInterop from tsconfigs (no longer mandatory) 2018-02-14 14:55:13 -08:00
Daniel Rosenwasser
27e260259e
Merge pull request #23615 from hoo29/master
[node] undo TlsOptions name change
2018-02-13 12:13:32 -08:00
Huw McNamara
6c98b1f3d8 undid TlsOptions name change 2018-02-13 18:25:43 +00:00
Daniel Rosenwasser
45e71c9c2b
Merge pull request #23393 from hoo29/master
[node] tidied up and de-duplicated tls related options
2018-02-10 10:34:57 -08:00
Huw McNamara
e00c71172a fixed deps, add local pick def 2018-02-06 19:21:36 +00:00
Andy
bef4d2b27d
Enable "esModuleInterop" in all tsconfigs (#23354) 2018-02-05 11:01:56 -08:00
Andy
37685e11dd Add tslint disables for no-const-enum (#23134) 2018-01-23 18:19:36 +00:00
Andy
19f89399e4 Ensure every package has a tslint.json (#21009)
* Ensure every package has a tslint.json

* Fixes
2017-10-25 11:13:50 -07:00
Andy
947a8fb761 Enable strictFunctionTypes (#20373) 2017-10-06 14:03:03 -07:00
Andy Hanson
354cec620d Move all packages to a types directory 2017-03-24 14:27:52 -07:00