From 1cc4c2f0d6d95fcfdcae4cc4f6985d0f802b6074 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ole=20J=C3=B8rgen=20Br=C3=B8nner?= Date: Wed, 19 Dec 2018 19:42:23 +0100 Subject: [PATCH] Regression: Prev commit (af3623e) broke new window animation Try removing the Navigator.navigating and inPreview checks. In those cases the clone should be visible. Without those checks (together with the clone.get_parent check?) dialogs created during animation is not hidden. Also note that the unmapped description in af362e was wrong - unmapped is only true a short period after the window is created. --- tiling.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tiling.js b/tiling.js index 326a2fe..35d9bf3 100644 --- a/tiling.js +++ b/tiling.js @@ -2077,11 +2077,9 @@ function showHandler(actor) { if (Scratch.isScratchWindow(metaWindow)) return; - if (metaWindow.unmapped) - return; - - if (metaWindow.clone.visible || ! onActive || Navigator.navigating - || inPreview) { + if (!onActive + || metaWindow.clone.get_parent() && metaWindow.clone.visible + ) { actor.hide(); metaWindow.clone.show(); }