From 9e24210e2cdaa77d63ce2b30bb2da0f8cd45efca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor=20Hedin=20Br=C3=B8nner?= Date: Sun, 5 Aug 2018 22:19:48 +0200 Subject: [PATCH] Never add transient or non-normal windows A transient window can be NORMAL, at least in wayland. --- tiling.js | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tiling.js b/tiling.js index ae6d7a8..4b59ba2 100644 --- a/tiling.js +++ b/tiling.js @@ -1408,14 +1408,15 @@ function disable () { function add_filter(meta_window) { let add = true; - if (meta_window.window_type != Meta.WindowType.NORMAL) { - if (meta_window.get_transient_for()) { - add = false; - // Note: Some dialog windows doesn't set the transient hint. Simply - // treat those as regular windows since it's hard to handle them as - // proper dialogs without the hint (eg. gnome-shell extension preference) - } + if (meta_window.get_transient_for()) { + // Never add transient windows + add = false; } + if (meta_window.window_type !== Meta.WindowType.NORMAL) { + // And only add Normal windows + add = false; + } + if (meta_window.is_on_all_workspaces()) { add = false; }