Starting on the first window in a space, creating a new window and then closing
it would leave the user with the second window active instead of the first as
expected. This happened because we would never fix the stack order of the first
window.
If utils fails to load we're not getting proper error messages as we're using it
outside a try block. Use `log` instead.
SyntaxErrors still doesn't return a proper trace unfortunately, though that's
perhaps better fixed in tooling. The alternative would be to run `Reflect.parse`
on the module file in the catch block returning that error instead...
This reverts commit b138e9083e.
Revert "Fix fullscreen reactivity again"
This reverts commit d5bd0cf023.
This would've made it likely to trigger the mouse «freeze» on x11.
Before we fixed the clone's position everytime it was allocated, eg. whenever we
would scroll a pixel.
Insetad we listen on the WindowActors allocation signal, which happens far less
as we don't move the WindowActor around much.
If the selected window is still visible we don't forc alignment with the monitor
edges, making it possible to eg. center the first/last window with a touchpad.
In the case of overshooting the last/first window we could end up not having a
window under the pointer, resulting in going back to the starting window.
The code indicates that the intention was always to ensure at the end :/
This might be unnecessary, as I assume the clones will get garbage collected
automatically, but that does assume it's not part of the scene graph (ie. it
dosen't have a parent). Just as well to do it explicit.
After a99c151 the we caused lots of
meta_window_make_above: assertion '!window->override_redirect' failed
warnings in the log.
Most likely best to leave such windows alone.
`worspace:window-removed` runs after `focus` which means ensureViewport can get
us into a bad state. Remove any dead neighbours while we're fixing the correct
stacking order.
In particular when we had this setup, where the numbers is the stacking order,
and `2` isn't fully visible:
| 3 | 1 | 2 |
closing `1` would focus `2` and `ensureViewport` would start scrolling it into
the view. `layout` would then remove `1` resulting `2` moving further (the width
of `1`) to the left.
There's no longer a reason to force `ensureViewport` here. In particular when
closing a window, the windows to the left won't wait for the windows on the
right before becoming reactive.
button-press on these buttons trigger a grab (GrabOp.FRAME_BUTTON).
Our grab handler run startAnimate which tracks the background -> the
button-press is stolen
Only happened for server-side-decorated windows (make sense that the grab is not
triggered for CSD windows)
Regression after: 5d0f037d3
Syncing clone positions to the frame on addWindow doesn't work for slurp/barf.
Do it in insertWindow before we `addWindow` and run layout.
fixes 6d51bc2c24
This avoids some ugly situations where dialog-type windows was very hard to
focus. Windows that lie below the tiling is usually not possible to click so one
would have to use alt-tab, the overview, etc..
Our own preference UI behaved like that :D (but only on X11)
Making them always on top isn't 100% ideal though - especially since transient
windows doesn't move when their parent move. (so they quickly end up above
other windows)
The search dialog of gedit is an example. Prior to this commit it would not stay
on top when gedit was moved away. It did "flash to the top" during animations
though..
Semirelated: #40
Simply check if the window is currently wide enough to be considered maximized.
Before we used `unmaximizedRect` to track maximized status. That is of course
brittle since the window can change size in many way. We cleared
`unmaximizedRect` in cycle-width (but it has been buggy for along time :P)
Note: using the size-changed signal is not trivial for this purpose: the signal
doesn't provide the previous size and it is async in wayland and synchronous in
X11.. (after running move_resize_frame)
We silently relied on a tween being active after layout when inserting existing
windows. Set the clone's initial position in `space.addWindow` before layout to
fix this.
Don't display "Failed to install..." warning when a first-user already have a
user.js config
Still track has-installed-config-template so it's possible to remove the user
config dir without it reappearing on each extenstion init.
Tor Hedin Brønner