55 Commits
Author SHA1 Message Date
Bo Anderson 861dea9ada Bump various type strictnesses 2021-09-11 01:00:23 +01:00
Bo Anderson 8e98ce69f3 Stricter handling of CLI args 2021-03-18 16:41:57 +00:00
Bo Anderson 769a6cd1f5 Don't touch PATH, GEM_HOME and GEM_PATH when testing formula 2021-03-10 17:08:57 +00:00
Bo Anderson d911596af9 dev-cmd/test: output stacktrace to stderr 2021-02-26 18:23:48 +00:00
Bo Anderson 6cd1e5e384 Avoid passing around a massive $LOAD_PATH.
Portable Ruby crashes if the $LOAD_PATH gets too big.
2021-02-26 18:23:48 +00:00
Bo Anderson bb4e74042a formula_assertions: use minitest
We are migrating away from using system gems, and we already have minitest in our dependency tree, so we might as well use it.
2021-02-26 18:23:07 +00:00
Rylan Polster d1f3e39b7b Update commands to generate usage banner 2021-01-18 21:20:11 -05:00
Dawid Dziurla cf654da251 dev-cmd: indicate multiple named args in usage banner 2021-01-15 13:04:07 +01:00
Rylan Polster da811373d3 Add named_args DSL for commands 2021-01-13 17:09:42 -05:00
souleater7 e50e3e4b22 Delete references to devel 2021-01-01 10:16:31 -08:00
Markus Reiter da9289eff0 Add more type signatures. 2020-11-13 12:26:36 +01:00
Markus Reiter 24ae318a3d Move type annotations into files. 2020-10-10 14:59:39 +02:00
Mike McQuaid 2e5272d04c Deprecate/disable code for Homebrew 2.5.0.
Do the usual "disable deprecations" and "uncomment pending deprecations"
dance and delete/deprecate/disable relevant/related code.
2020-09-03 10:34:22 +01:00
William Ma fa7bd3bff6 args: Migrate usage of args loading methods to args.named 2020-08-23 09:02:20 -04:00
Dawid Dziurla c8c2e38bcb Consistently use HOMEBREW_RUBY_WARNINGS when calling ruby
Adding this in `dev-cmd/ruby.rb` allows us to suppress warnings like:
```
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/language/python.rb:8: warning: Insecure world writable dir /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/scm in PATH, mode 040777
```
2020-08-20 14:59:58 +02:00
Markus Reiter cd402358b0 Pass args correctly in brew test. 2020-07-31 19:45:18 +02:00
Markus Reiter d4c2ffd705 Refactor CLI::Parser. 2020-07-31 15:07:17 +02:00
Mike McQuaid 92a39bc49e test: add flag to retry.
This should allow better handling flaky tests.
2020-07-29 12:00:45 +01:00
Mike McQuaid 40ec8e69cc Cleanup Sandbox code
Remove unused code and methods.
2020-05-02 13:45:04 +01:00
Alexander BayandinandMike McQuaid bfcba0f5f0 Library/Homebrew: add free_port test helper
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-03-31 00:00:11 +01:00
Mike McQuaid e3ac94fc5d dev-cmd: use more and cleanup new args APIs. 2020-03-05 09:40:15 +00:00
Gautham GoliandGitHub de9295cc7a Merge pull request #6939 from Homebrew/argv-cleanup-8
ARGV: Replaces usages of ARGV.force? with Homebrew.args.force?
2020-01-15 21:25:36 +05:30
Gautham Goli 161c3fb6a4 ARGV: Replaces usages of ARGV.force? with Homebrew.args.force? 2020-01-15 21:09:31 +05:30
Gautham GoliandMike McQuaid 959b88266d ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args 2020-01-02 13:56:19 +00:00
Mike McQuaid 5dd8ead51a Rename Formula#installed? to Formula#latest_version_installed?
This naming has always been a bit weird and confusing so let's change
it and provide a `compat` fallback for later deprecation.
2019-12-03 11:42:42 +00:00
Gautham Goli 393c8dfbf1 ARGV: Replace options_only and flags_only with Homebrew.args counterparts 2019-09-23 12:39:22 +05:30
Mike McQuaidandGitHub 963cc556d4 Revert "argv: move options_only to cli/args" 2019-09-13 09:34:43 +01:00
Gautham Goli 4586632855 argv: move options_only to cli/args 2019-09-07 21:32:50 +05:30
EricFromCanada 8a8359cdd4 manpages: sentence rewording for readability
Use active voice when applicable, better verbs & adjectives, preposition usage, proper tense, etc.
2019-08-20 09:05:45 -04:00
Mike McQuaid c4f72312ce Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid 36dbad3922 Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid e40b171127 Rename cli_parser to cli/parser. 2019-04-17 22:16:50 +09:00
Mike McQuaid aa44509be9 Test dev-cmd *_args methods
Also, add a few missing invocations.
2019-03-27 13:35:42 +00:00
Mike McQuaid bbea109926 dev-cmd: remove --help headers and tweak docs. 2019-01-30 21:39:28 +00:00
Mike McQuaid 867b155479 Add missing conflicts to command options. 2019-01-29 19:39:41 +00:00
EricFromCanada 388781f6a7 dev-cmd/: remove colons from command specs.
These aren't needed when converting Parser-based help text to man page or Markdown formats.
Includes regenerated docs.
2018-10-19 13:12:55 -04:00
EricFromCanada 63b3d400e0 dev-cmd/: add Parser-based help text for remaining commands.
`brew ruby` now accepts only `-e`, verbose, and debug arguments.
2018-10-19 13:12:55 -04:00
Markus Reiter b7ea9e1830 Allow access to lock directory inside tests. 2018-10-17 14:23:02 +02:00
Markus Reiter e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
William Woodruff 367629d289 utils: Use JSON to marshal child errors
Replaces our serialization of child process
errors via Marshal with JSON, preventing
unintentional or malicious code execution outside
of the build sandbox.

Additionally, adds tests for the new behavior.
2018-09-04 11:03:32 -04:00
Mike McQuaidandGitHub 7df5b7057e Revert "Use JSON to marshal errors from children" 2018-08-18 08:20:13 +01:00
William WoodruffandWilliam Woodruff 5c90833f0a Use JSON to marshal errors from children 2018-08-17 15:23:08 -04:00
Markus Reiter 5841b992ac Refactor $LOAD_PATH. 2018-07-17 23:38:57 +02:00
Mike McQuaid 42fc339ee6 test: correctly prune non-test dependencies. 2018-03-08 08:56:58 +00:00
Mike McQuaid fea9bc1e42 Allow :test dependencies.
These specify that they are needed by the test block. This can be
combined with `:build` to ensure that this formula isn't uninstalled
by `brew test-bot` when running `test do` blocks on our CI.
2018-03-05 10:36:39 +00:00
Markus Reiter 175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Mike McQuaid 12c454822a sandbox: stop printing message.
We’re always using the sandbox where possible now so this is just
noise for the vast majority of our users.
2017-08-07 11:16:36 +01:00
Mike McQuaidandGitHub 5c2fa1fc1f test: use Test::Unit class. 2017-07-07 09:44:02 +01:00
Misty De Meo 5b464babf8 Define a custom assertion failure error for cross-version compat
Fixes #2840.
2017-06-29 17:40:04 -07:00
Mike McQuaid c45cca8e36 test: simplify minitest inclusion.
The previous version seems needlessly complicated given we only support
a single Ruby version. It was also blowing up on Bundler 1.15.X.
2017-06-25 13:04:36 +01:00