22 Commits
Author SHA1 Message Date
Nanda H KrishnaandRylan Polster a7271f8900 brew style --fix 2022-01-18 21:13:39 -05:00
Bo Anderson dab04e3321 utils/popen: redirect stderr to /dev/null rather than close 2021-03-19 17:14:59 +00:00
Seeker 88306d5f5d utils/popen: add safe argument to popen_read and popen_write 2021-01-12 10:22:40 -08:00
Markus Reiter 24ae318a3d Move type annotations into files. 2020-10-10 14:59:39 +02:00
Claudia 09d7889ed8 Extract constant IO_DEFAULT_BUFFER_SIZE 2020-09-02 18:15:51 +02:00
Claudia 246db8a134 Capture stdout during popen_write
Fix tests and fulfill intended semantics by having `popen_write`
transparently capture standard output.
2020-08-31 14:04:49 +02:00
Mike McQuaid 36dbad3922 Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Markus Reiter e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Markus Reiter 681098f4fe Fix ErrorDuringExecution initialization. 2018-08-02 05:56:24 +02:00
Markus Reiter 2452b27866 Refactor ErrorDuringExecution. 2018-07-19 16:41:27 +02:00
Shaun Jackman 1b688a3a25 Relocate bottles on Linux using patchelf
Ensure patchelf is installed to pour bottles and build bottles.
2018-07-12 10:21:26 -07:00
Shaun Jackman 7adee6d62f Utils.popen_read: Nonexistent program should fail
Ensure that $CHILD_STATUS.success? is false when the command does not exist.
2017-12-02 15:52:01 -08:00
Shaun Jackman 58a1bd6dbf popen: Do not suppress stderr when HOMEBREW_STDERR 2017-09-20 13:25:36 -07:00
Shaun Jackman 8bf28477a3 popen: Add an options argument
Useful for selectively enabling or silencing stderr, for example.
popen_read("foo", err: :err)
2017-09-20 13:25:29 -07:00
ilovezfsandGitHub 6fb9fed693 Revert "popen: Do not suppress stderr" 2017-09-19 07:40:29 -07:00
Shaun Jackman 78d3112df2 popen: Do not suppress stderr unless -d or -v 2017-09-08 09:39:33 -07:00
Markus Reiter dc4f303937 Remove unused popen_read_text method. 2017-05-29 01:45:05 +02:00
Markus Reiter 58e36c7319 Fix Style/GuardClause. 2016-09-24 12:24:35 +02:00
Martin Afanasjew 8486f6e04d Prefer $stderr over STDERR for consistency (#304)
Prior to this change there were only 3 instances of `STD(IN|OUT|ERR)`
versus 74 instances of `$std(in|out|err)` in the Homebrew code base. The
latter variant is also strongly suggested by bbatsov's Ruby Style Guide.
2016-06-01 09:45:49 +02:00
Andrew Janke a3b70d38a7 brew-audit: pull style checks in to main audit output
This collects all violations for each formula in a single place, instead
of doing `brew style` outputs for all formulae first, and then the other
audit checks.

Closes #112.

Signed-off-by: Andrew Janke <andrew@apjanke.net>
2016-04-21 14:45:33 -04:00
Jack Nagel 5c24b7330b Read if no block is passed to Utils.popen_read 2014-07-11 15:52:39 -05:00
Jack Nagel ad27b21cd1 Add popen wrapper that does not invoke the shell 2014-07-05 13:50:54 -05:00