Commit Graph
617 Commits
Author SHA1 Message Date
Mike McQuaid 134bd00d10 audit: don't care about shadowing official taps.
We're trying to import all of these formulae anyway.
2017-09-29 16:23:02 +01:00
ilovezfs feda0242be bump-formula-pr: fix duplicates check
`return unless pull_requests && !pull_requests.empty?` and
`return unless pull_requests&.empty?` are not equivalent.
2017-09-25 23:03:19 -07:00
Mike McQuaid cf5fdeef1d Rubocop: manual rule fixes. 2017-09-24 21:23:59 +01:00
Mike McQuaid 01e9ec9a9f Rubocop: automatic rule fixes. 2017-09-24 21:23:59 +01:00
ilovezfs 28c7838450 audit: also skip homebrew/science duplicates found by search_taps
Follow-up to #3202.
2017-09-24 00:29:34 -07:00
ilovezfs e984623214 audit: don't check for homebrew/science duplicates
It's just noise to turn the migration PRs red over expected duplicates.
2017-09-23 23:00:29 -07:00
Mike McQuaid 56ab1ef5a8 audit: hack around El Capitan audit failure. 2017-09-23 21:10:25 +01:00
Mike McQuaid ffdda0eb9f Tweaks for older Mac OS X versions.
- `brew update` should try to install `curl` before `git` on older
  versions of Mac OS X where it is needed for accessing modern SSL
  certificates.
- We don't need an HTTP mirror for `git` because `curl` will already be
  installed before it is downloaded.
- Don't recommend GCC on Mac OS X versions where it can't be built with
  the default system compiler.
- Start using the Homebrew `curl` on Mac OS X versions where it is
  needed as soon as it is installed.
2017-09-16 12:41:08 +01:00
Mike McQuaid 2e43d95498 audit: fix check_http_content args. 2017-09-15 10:17:40 +01:00
Mike McQuaid 03ace9b110 Require more HTTP mirrors for old OS X versions.
This allows the bootstrap of `curl` and `git` on versions of Mac OS X
that cannot reliably download from HTTPS servers any longer. Once these
are both installed users are able to update Homebrew and download files
securely.

Also, as we're doing this, don't point 10.5 users to Tigerbrew as they
are already given caveats for using Homebrew itself.
2017-09-14 19:58:37 +01:00
Mike McQuaidandGitHub ef60688704 Merge pull request #3126 from DomT4/curl_audit
audit: stop demanding a HTTP HEAD mirror for curl
2017-09-12 15:48:11 +01:00
Mike McQuaidandGitHub 929edca531 Merge pull request #3061 from mislav/hub-fork-forward-compat
bump-formula-pr: forward compatibility with `hub fork`
2017-09-08 18:46:07 +01:00
Mike McQuaidandGitHub bf0ab938e7 Merge pull request #3091 from GauthamGoli/audit_line_rubocop_part_3
audit: Port line_problems to rubocop and add tests part 3
2017-09-05 18:10:02 +01:00
Dominyk Tiller 9562cceef1 audit: stop demanding a HTTP HEAD mirror for curl
Not sure if this is how you want to handle it but having a HEAD mirror
for `curl` is just silliness.

Ref: https://github.com/Homebrew/homebrew-core/commit/e36b95849ae38ade30605155d75cf6e731b4e38f
2017-09-05 03:35:44 +01:00
Gautham Goli d45ff9c0fd audit: Add a global flag to silent warning when auditing 2017-09-04 23:57:09 +05:30
Gautham Goli 4ec26aea40 audit: Port audit_class to rubocop, add tests and autocorrect 2017-09-04 23:43:42 +05:30
Gautham Goli 267def28fa audit: Port rules from line_problems to rubocop part 3 2017-09-04 15:05:43 +05:30
Mike McQuaidandGitHub 73cd2a1db8 Merge pull request #3119 from MikeMcQuaid/audit-subversion-url-fix
audit: fix subversion remote check logic.
2017-09-04 01:54:28 +01:00
Mike McQuaidandGitHub 37293c6f01 Merge pull request #3096 from vszakats/urlchk1
audit: Add some heuristics to https upgrade checks
2017-09-03 21:50:53 +01:00
Mike McQuaid bbf71921eb audit: fix subversion remote check logic.
Stop flagging invalid URLs as valid and vice-versa.

Fixes #3118.
2017-09-03 21:42:46 +01:00
Viktor Szakats 42e2c71dbc cleanup range check 2017-09-01 16:47:31 +00:00
Dominyk Tiller f301e5c4f4 audit: add a nudge to remove ENV.java_cache 2017-08-31 21:33:09 +01:00
Viktor Szakats 18f5b43d90 fix length ratio range 2017-08-29 17:02:27 +00:00
Viktor Szakats 56ccf10efa limit some heuristics to strict mode 2017-08-29 12:53:45 +00:00
Viktor Szakats c30b941358 review follow-up #1 2017-08-29 12:31:07 +00:00
mansimarkaur 3d8873ca5b url skipped if svn not available when auditing urls 2017-08-29 16:16:17 +05:30
mansimarkaur 53be6bb4bd Added check for svn availability 2017-08-29 16:16:17 +05:30
Viktor Szakats 1c2c390c6f try addressing style issues #2 2017-08-27 18:00:59 +00:00
Viktor Szakats 11b267a7cf try addressing style issues 2017-08-27 17:52:26 +00:00
Viktor Szakats 923c84d4f7 add some heuristics to https upgrade check 2017-08-27 09:39:28 +00:00
Mike McQuaidandGitHub 8b7defb3eb Merge pull request #3086 from MikeMcQuaid/audit-taps-shush
audit: don't output when searching taps.
2017-08-24 11:17:31 +01:00
JCountandGitHub 6023e408da Merge pull request #2995 from GauthamGoli/audit_line_rubocop_part_2
audit: Port line_problems to rubocop and add tests part 2
2017-08-23 16:16:07 -04:00
Mike McQuaid f0605f4a30 audit: don't output when searching taps.
This messaging was added for the `brew search` command and having it in
audit is annoying:
(https://github.com/Homebrew/brew/pull/3059#issuecomment-323638672)

As a side note: this is why randomly including `cmd/*` is a bad idea.
2017-08-23 18:40:30 +01:00
Markus Reiter 15e572702e Fix pull. 2017-08-21 22:41:13 +02:00
Mislav Marohnić 80ae5b2660 bump-formula-pr: forward compatibility with hub fork
Due to limitations of `hub fork` in hub 2.2, scripts had to repeat the
command at least two times; the 2nd time was to read the fork name from
the "fatal: remote MYNAME already exists" message output from git.

In upcoming hub 2.3, the `hub fork` command is improved to always output
the remote name, regardless of whether one already existed or not. With
this approach, only one `hub fork` call will ever be necessary when hub
is up to date.
2017-08-15 17:32:12 +02:00
Mike McQuaidandGitHub ea33958e03 Merge pull request #3031 from JCount/audit-fix-tap-versioned-aliases
audit: fix mismatch in versioned alias names in non-core taps
2017-08-09 20:46:13 +01:00
Bob W. Hogg 0ae22c0e36 dev-cmd/bump-formula-pr: search for tar
We first search for gtar in PATH, then
check if Homebrew's gtar is available,
then finally search for tar in PATH.

Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-08-08 23:07:27 -07:00
JCount e1ebaab0cb audit: fix mismatch in versioned alias names in non-core taps
Fixes #3022
2017-08-08 16:56:19 -04:00
Markus Reiter ae4bafdb36 Simplify CurlDownloadStrategy. 2017-08-08 18:10:13 +02:00
ilovezfsandGitHub 986887b413 Revert "Refactor SVN and cURL download strategies." 2017-08-07 14:31:56 -07:00
Markus Reiter dc5a2c1764 Simplify CurlDownloadStrategy. 2017-08-07 21:31:17 +02:00
Mike McQuaid 12c454822a sandbox: stop printing message.
We’re always using the sandbox where possible now so this is just
noise for the vast majority of our users.
2017-08-07 11:16:36 +01:00
Gautham Goli 7614d2cc8b audit: Port FileUtils, inreplace audit rules in audit_lines to rubocop 2017-08-06 02:28:58 +05:30
Gautham Goli affd9055c2 audit: Port classname and template comments audit rules from line_problems method to rubocop 2017-08-06 02:28:58 +05:30
Gautham Goli 43cec10000 audit: Port patches audit code to a rubocop 2017-08-05 21:51:24 +05:30
Mike McQuaidandGitHub f4983ab16b Merge pull request #2975 from GauthamGoli/audit_urls_rubocop_strict
audit: Port audit_urls strict rules to rubocop, add tests, autocorrect
2017-08-01 11:39:01 +01:00
Mike McQuaidandGitHub 43d68b6dda Merge pull request #2980 from GauthamGoli/audit_style_check_bug_fix
audit: fix bug where `brew audit foo` runs every style check.
2017-08-01 11:36:18 +01:00
Mike McQuaidandGitHub c3c3575b70 Merge pull request #2964 from GauthamGoli/audit_line_rubocop_part_1
audit: Port dependency rules from line_problems to rubocop and add tests
2017-08-01 11:29:26 +01:00
Gautham Goli 5e8e705b50 audit: fix bug where brew audit foo runs every style check. 2017-07-30 22:03:43 +05:30
Gautham Goli c575f34d5f audit: Port audit_urls strict rules to rubocop, add tests and autocorrect 2017-07-30 12:59:37 +05:30