Commit Graph
21366 Commits
Author SHA1 Message Date
Mike McQuaidandGitHub 0a46e34024 Merge pull request #10460 from MikeMcQuaid/typecheck-deprecation
typecheck: migrate from deprecated flag.
2021-01-29 12:09:16 +00:00
Mike McQuaid 5a21ba0677 typecheck: migrate from deprecated flag.
Also, add a TODO to answer why the other error codes are suppressed.
2021-01-29 09:28:53 +00:00
Mike McQuaidandGitHub ebcd56cc62 Merge pull request #10459 from muneebmahmed/fix-fish-completion
Fix fish shell completion for upgrade
2021-01-29 08:48:54 +00:00
Muneeb Ahmed ae70e43aa3 Fix fish shell completion 2021-01-29 00:10:13 -08:00
Seeker 35f857e38f version: rename more regex constants 2021-01-28 16:59:51 -08:00
Seeker c5d3b9ae3e version: rename regex constants 2021-01-28 16:42:44 -08:00
Seeker 2e6e38ec4d version: rename ALPHA_SUFFIX to PREREL_SUFFIX 2021-01-28 16:41:49 -08:00
Seeker a52959d5d2 version: replace [-.vV] with [.-vV] in regexes 2021-01-28 16:41:49 -08:00
Seeker fc7c243471 version: add constants for regexes 2021-01-28 16:41:49 -08:00
Seeker d9e8a34d3b version: replace [.] with \. in regex 2021-01-28 16:41:49 -08:00
Seeker f76bf240cd version: replace [-_] with [_-] in regexes 2021-01-28 16:41:49 -08:00
Seeker e1d68cf1eb version: make [._-] consistent in regexes 2021-01-28 16:41:49 -08:00
Seeker 1ce8bd00fb named_args: print error if formula and cask found but one is unreadable 2021-01-28 15:21:23 -08:00
Seeker 89930157b5 named_args: raise rescued error if both formula/cask are unreadable 2021-01-28 15:21:23 -08:00
Rylan PolsterandGitHub db6f65ddc0 Merge pull request #10423 from Rylan12/rename-branches
Handle upstream branch renames
2021-01-28 16:45:01 -05:00
Michka Popoff 38ae6e0c0d style: re-enable sha256 checks for bottle blocks
Follow up PR to #10450
2021-01-28 20:35:31 +01:00
Michka PopoffandGitHub 26a3d4a544 Merge pull request #10452 from iMichka/line
style: handle line too long for new bottle blocks
2021-01-28 20:33:23 +01:00
Michka Popoff 46c5965037 style: handle line too long for new bottle blocks
The " was for a previous syntax we had, but we dropped that and changed our minds.
This PR fixes the style check for the current implementation of the new bottle blocks.
2021-01-28 20:02:29 +01:00
Michka Popoff b87c23bb7e style: do not fail on sha256 lines with cellar information
Fixes:
1-01-28T17:17:10.7152456Z [31m==>[0m [1m[31mFAILED[0m[0m
2021-01-28T17:17:10.7163169Z [36mFormula/dhall-json.rb[0m:14:12: [33mC[0m: sha256 should be 64 characters
2021-01-28T17:17:10.7175011Z     sha256 cellar: :any_skip_relocation, big_sur: "a1e0cb4f7e4a7e0994b43ecd783240356631d36655cfbf59a903cc3f6a799242"
2021-01-28T17:17:10.7176620Z            ^^^^^^
2021-01-28T17:17:10.7178131Z [36mFormula/dhall-json.rb[0m:14:15: [33mC[0m: sha256 contains invalid characters
2021-01-28T17:17:10.7179886Z     sha256 cellar: :any_skip_relocation, big_sur: "a1e0cb4f7e4a7e0994b43ecd783240356631d36655cfbf59a903cc3f6a799242"
2021-01-28T17:17:10.7181198Z               ^^
2021-01-28T17:17:10.7182390Z [36mFormula/dhall-json.rb[0m:15:12: [33mC[0m: sha256 should be 64 characters
2021-01-28T17:17:10.7183801Z     sha256 cellar: :any_skip_relocation, catalina: "050f219d8050cf46a54487e0cad414374a5d2b4a6422d1e2e2c7a682149c3afb"
2021-01-28T17:17:10.7184956Z            ^^^^^^
2021-01-28T17:17:10.7186016Z [36mFormula/dhall-json.rb[0m:15:15: [33mC[0m: sha256 contains invalid characters
2021-01-28T17:17:10.7187458Z     sha256 cellar: :any_skip_relocation, catalina: "050f219d8050cf46a54487e0cad414374a5d2b4a6422d1e2e2c7a682149c3afb"
2021-01-28T17:17:10.7188630Z               ^^
2021-01-28 18:27:21 +01:00
Michka PopoffandGitHub 61e38654ed Merge pull request #10449 from iMichka/bottle-write
cellars: write tag specific cellars
2021-01-28 18:09:00 +01:00
Mike McQuaidandGitHub ca4a4449ad Merge pull request #10448 from hyuraku/formula_auditor_delete_adoptopenjdk_condition
formula_auditor: delete adoptopenjdk condition
2021-01-28 15:46:50 +00:00
Rylan PolsterandMike McQuaid 84fc16c1c1 Apply suggestions from code review
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2021-01-28 09:10:14 -05:00
Rylan Polster f508f8dc0c update: show message prompting brew tap --repair
This message is shown when a fetch fails due to a branch rename
2021-01-28 09:10:13 -05:00
Rylan Polster 4bdc11ddc9 tap: fix renamed branches with brew tap --repair 2021-01-28 09:10:13 -05:00
Mike McQuaidandGitHub cd191a7f6c Merge pull request #10446 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.6251
build(deps): bump sorbet from 0.5.6239 to 0.5.6251 in /Library/Homebrew
2021-01-28 14:08:36 +00:00
Mike McQuaidandGitHub d658056607 Merge pull request #10443 from Homebrew/dependabot/bundler/Library/Homebrew/codecov-0.4.2
build(deps): bump codecov from 0.4.1 to 0.4.2 in /Library/Homebrew
2021-01-28 14:08:23 +00:00
hyuraku a1baff39d5 formula_auditor: delete adoptopenjdk condition 2021-01-28 22:57:21 +09:00
Mike McQuaid 4afebd2872 Fixup brew bottle (and tests) for #10447. 2021-01-28 13:19:41 +00:00
Michka PopoffandMike McQuaid e142dd3fc1 rubocop: do not complain for too long sha256 lines in bottle blocks 2021-01-28 13:19:41 +00:00
Michka PopoffandMike McQuaid 838cf2fc58 bottle_spec: run generate_sha256_line test on mac too 2021-01-28 13:19:40 +00:00
Mike McQuaid 902993afe4 dev-cmd/bottle_spec: add another integration test on macOS. 2021-01-28 13:19:40 +00:00
Michka PopoffandMike McQuaid de2e309d50 cellars: write tag specific cellars
With #10186 now merged, the tag specific cellar information is being read by brew.
This PR (once merged) will start adding the cellar information for each tag instead
of having a single cellar line on the top of the bottle block.

Each new CI build in homebrew-core will slowly start migrating the cellar lines to
the right place. If keep-old is used, the old "all tag" cellar line is removed and
added to each tag.
2021-01-28 13:19:40 +00:00
Mike McQuaid fc1c142ebd software_spec: reverse tag/digest for new bottles.
This new format was agreed in #10377
2021-01-28 13:15:41 +00:00
BrewTestBot 560d4d1d0d Update RBI files for codecov. 2021-01-28 12:09:27 +00:00
BrewTestBot b4bae9b390 brew vendor-gems: commit updates. 2021-01-28 12:07:56 +00:00
BrewTestBot a835cdc012 brew vendor-gems: commit updates. 2021-01-28 12:03:04 +00:00
dependabot[bot]andGitHub 85d124b5da build(deps): bump codecov from 0.4.1 to 0.4.2 in /Library/Homebrew
Bumps [codecov](https://github.com/codecov/codecov-ruby) from 0.4.1 to 0.4.2.
- [Release notes](https://github.com/codecov/codecov-ruby/releases)
- [Changelog](https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-ruby/compare/v0.4.1...v0.4.2)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-28 11:54:19 +00:00
dependabot[bot]andGitHub 3521b219e9 build(deps): bump sorbet from 0.5.6239 to 0.5.6251 in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.6239 to 0.5.6251.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-28 11:53:56 +00:00
Mike McQuaidandGitHub 5f66e15602 Merge pull request #10445 from MikeMcQuaid/rspec_tmpdir_parallel
tests: cleanup user configuration.
2021-01-28 11:38:00 +00:00
Mike McQuaid 4fe86661ac tests: cleanup user configuration. 2021-01-28 10:54:26 +00:00
Mike McQuaidandGitHub b14bd7a521 Merge pull request #10434 from jonchang/guard-zsh-completions
zsh: add guards to speed up completions
2021-01-28 09:24:31 +00:00
Mike McQuaidandGitHub 0fc2e82dd4 Merge pull request #10435 from jonchang/conflict-zsh-completions
zsh: don't complete conflicting options
2021-01-28 09:24:10 +00:00
Mike McQuaid 623e2d95af Revert "cleanup_spec: inline path creation."
This reverts commit 3724c739f8.
2021-01-28 08:13:08 +00:00
Rylan PolsterandGitHub 5b2f8a5a73 Merge pull request #10431 from Rylan12/fish-completions
Generate fish completions automatically
2021-01-27 17:46:34 -05:00
Mike McQuaidandGitHub a83848d24f Merge pull request #10439 from MikeMcQuaid/fix_retry
spec_helper: fix and improve retry logic.
2021-01-27 19:37:10 +00:00
Mike McQuaidandGitHub 03c861b7d7 Merge pull request #10428 from SeekingMeaning/cask-reverse-migration
cask/audit: disallow new cask to have token in tap_migrations.json
2021-01-27 15:07:13 +00:00
Mike McQuaid 3724c739f8 cleanup_spec: inline path creation.
Let's see if this makes the test more reliable.
2021-01-27 15:06:06 +00:00
Mike McQuaid 3ebc64a71d rubocop_rspec: don't autocorrect focus.
It's annoying to have these autoremoved.
2021-01-27 15:04:35 +00:00
Mike McQuaid da94957b01 tests: verbose tests with --verbose or --debug.
The `VERBOSE_TESTS` variable was from cask and never gets set (and
is unset by `bin/brew`). Replace it with `HOMEBREW_VERBOSE_TESTS` and
set it by `--verbose` or `--debug`.

While we're here, remove an unneeded `VERBOSE` delete (as it's already
done by `bin/brew`).
2021-01-27 15:04:13 +00:00
Mike McQuaid f38707e92a spec_helper: fix and improve retry logic.
- always retry each test at least once (confusingly this means a retry
  count of 2 rather than 1)
- always wait at least 1 second between retries
- set a default retry metadata for integration tests rather than
  overriding any specified values
- use `example.run` rather than `example.run_with_retry` for integration
  tests because, confusingly, this avoids having the retry count be
  half what it should be (because the attempts increases by one for
  each `run_with_retry` call)
- use 4 retries for integration tests with 2**attempts*retry_wait
  (retry wait now being 2) to actually have more retries than before
  this commit (but with exponential backoff)

This should generally improve test flakiness in CI but particularly
improve the cleanup test flake we've seen recently.
2021-01-27 12:43:30 +00:00