ilovezfs and GitHub
0d03eef655
Revert "FileUtils.make: don't bypass superenv"
2017-07-12 02:58:01 -07:00
ilovezfs and GitHub
6a5d24b53e
Merge pull request #2885 from DomT4/high_sierra_db3
...
High Sierra: updates for DB3 et al.
2017-07-11 09:54:54 -07:00
Dominyk Tiller
570dee5809
pkgconfig: update sqlite3 for 10.13
2017-07-11 16:20:37 +01:00
Dominyk Tiller
d0a2d1ba30
mac/xcode: update expected Clang on 10.13
2017-07-11 16:18:34 +01:00
Mike McQuaid and GitHub
db08eff02e
Merge pull request #2858 from marinintim/update_to_upgrade
...
Call upgrade if something was passed to update
2017-07-11 15:56:10 +01:00
ilovezfs
53a677aba6
sandbox: allow write access to /dev/random
...
This avoids build failure for `root6`.
MacPorts currently avoids the failure with a patch, as their sandbox
doesn't yet allow write access to `/dev/random` either:
https://github.com/macports/macports-ports/blob/7792b2c5655f9d2adb979434a242cc3ac60fea40/science/root6/Portfile#L73-L75
https://github.com/macports/macports-ports/blob/7792b2c5655f9d2adb979434a242cc3ac60fea40/science/root6/files/patch-disable-hsimple-macro.diff
The relevant code where `/dev/random` is opened with `O_WRONLY` is here:
https://github.com/root-project/root/blob/15673deba5a0cb73d90ae8f36d7b010f65b5e96e/interpreter/cling/lib/Utils/PlatformPosix.cpp#L63-L82
2017-07-11 01:47:36 -07:00
Tim Marinin
156e19c6dc
Display "Use brew upgrade foo instead" when calling update with args
...
So the user could just copy-paste the command.
2017-07-10 12:30:58 +03:00
Mike McQuaid and GitHub
287ba7a6af
Merge pull request #2872 from MikeMcQuaid/fix-high-sierra-tests
...
Fix `brew tests` on High Sierra.
2017-07-10 08:18:17 +01:00
Mike McQuaid
cabb7e898a
integration_test: add simplecov libs when needed.
...
Don't add these unconditionally or with Bundler to speed things up a
bit. Also, to speed things up further cache these arguments so we don't
have to do the same generation every time.
2017-07-10 07:51:04 +01:00
Mike McQuaid and GitHub
eb02612393
Merge pull request #2877 from mistydemeo/fix_fileutils_make
...
FileUtils.make: don't bypass superenv
2017-07-09 21:10:40 +01:00
Mike McQuaid and GitHub
f1fa475c4f
Merge pull request #2843 from GauthamGoli/audit_conflicts_rubocop
...
audit: Port audit_conflicts method to rubocop and add tests
2017-07-08 07:44:16 +01:00
Mike McQuaid and GitHub
ded1967c6c
Merge pull request #2871 from MikeMcQuaid/rspec-focus
...
spec_helper: add focus support.
2017-07-08 07:44:00 +01:00
Misty De Meo
2aefd7eed6
FileUtils.make: don't bypass superenv
2017-07-07 16:23:46 -07:00
Mike McQuaid
0b69ca85f7
spec_helper: add focus support.
...
When adding `, :focus` as a trailing argument to a `describe` or `it`
this allows you to only run that single test.
2017-07-07 16:34:29 +01:00
Markus Reiter and GitHub
8ec08479ae
Merge pull request #2865 from reitermarkus/cleanup-directories
...
Also remove directories with `brew cask cleanup`.
2017-07-07 17:25:02 +02:00
Gautham Goli
4ed34f91c2
audit: Port audit_conflicts method to rubocop and add tests
2017-07-07 20:46:57 +05:30
Mike McQuaid and GitHub
0740855f81
Merge pull request #2870 from MikeMcQuaid/node-cleanup
...
language/node: general cleanup.
2017-07-07 15:59:35 +01:00
Mike McQuaid and GitHub
81dbc29566
Merge pull request #2853 from GauthamGoli/disable-strict-cops-brew-style
...
style: Don't run FormulaAuditStrict cops when `brew style foo` cmd is executed
2017-07-07 15:43:55 +01:00
Mike McQuaid
cb3a47d9e2
Fix brew tests on High Sierra.
...
The `brew test` tests were failing as they were unable to include
`test/unit/assertions`. This is because it's a gem and we were setting
the `GEM_HOME` so system gems were being ignored.
While I was there and examining the `$LOAD_PATH`: reduce the number of
things we add there by using `Bundler.with_clean_env` and only adding
`HOMEBREW_LIBRARY_PATH` in the `$LOAD_PATH` if it isn't already there
(which it always is [and has to be] for integration tests).
This also seems to have the side effect of speeding up integration
tests from 1m26s to 1m8s on my machine.
2017-07-07 15:20:19 +01:00
Mike McQuaid
9f6762d958
language/node: general cleanup.
...
- Avoid using a temporary variable where not necessary
- Use fewer, better stubs in the tests to avoid warnings and better
test the implemented functionality.
2017-07-07 15:11:41 +01:00
Mike McQuaid and GitHub
1406f89ac5
Merge pull request #2863 from mistydemeo/formula_keg_only_boolean
...
Formula#keg_only should be a boolean
2017-07-07 10:14:32 +01:00
Mike McQuaid and GitHub
ddb1fd7981
Merge pull request #2841 from mistydemeo/formula_assertions_constant
...
Define a custom assertion failure error for cross-version compat
2017-07-07 10:14:21 +01:00
Mike McQuaid and GitHub
5c2fa1fc1f
test: use Test::Unit class.
2017-07-07 09:44:02 +01:00
Mike McQuaid and GitHub
7aaa7e1b79
formula_assertions: make removable on Ruby 2.0.
2017-07-07 09:43:39 +01:00
Mike McQuaid
bddafe4d54
audit: don't suggest non-stable versioned alias.
...
Additionally handle the case where a formula has been installed as
devel/HEAD rather than just e.g. `brew audit --devel`.
2017-07-07 09:30:18 +01:00
Mike McQuaid and GitHub
fa031f5045
formula: tweak keg_only? formatting.
2017-07-07 09:23:31 +01:00
Mike McQuaid and GitHub
d9e0a0bce6
rubocop.yml: remove doublenegation disable.
2017-07-07 09:22:39 +01:00
Markus Reiter
0217fb5d9d
Also remove directories with brew cask cleanup.
2017-07-06 20:59:35 +02:00
Mike McQuaid and GitHub
ae33f5c79c
Merge pull request #2859 from jonchang/fix-sse3-linux
...
cpu: fix SSE3 detection on Linux
2017-07-06 08:28:20 +01:00
Misty De Meo
5adca2e33d
Disable Style/DoubleNegation cop
...
As discussed in bbatsov/rubocop#3344 , there are situations where
this is the shortest and most idiomatic way to convert a value
to a boolean - particularly for checking values which can be
nil or truthy.
2017-07-05 17:51:57 -07:00
Misty De Meo
a79dc3e65b
Formula#keg_only should be a boolean
2017-07-05 16:34:59 -07:00
Jonathan Chang
5ab745574c
cpu: fix SSE3 detection on Linux
2017-07-05 13:03:39 -07:00
Markus Reiter
65b9e06082
Bump rubocop-cask version.
2017-07-05 20:51:51 +02:00
Gautham Goli
e9dfa736bf
style: Don't run FormulaAuditStrict cops when brew style some_formula cmd is executed
2017-07-03 12:54:04 +05:30
Mike McQuaid
835135cb68
missing_formula: no need to tap homebrew/core.
...
Avoiding printing the weird message e.g:
```
It was migrated from homebrew/science to homebrew/core.
You can access it again by running:
brew tap homebrew/core
```
2017-07-02 15:28:44 +01:00
ilovezfs and GitHub
f012660489
Merge pull request #2850 from ilovezfs/software-spec-rescue-unavailable
...
software_spec: rescue TapFormulaUnavailableError in recursive_dependencies
2017-07-02 06:48:39 -07:00
Mike McQuaid and GitHub
2b3717a5a0
Merge pull request #2842 from GauthamGoli/audit_only_cops_option
...
audit: Don't run audit methods when `--only-cops` option is passed
2017-07-02 14:45:29 +01:00
ilovezfs
418f578601
software_spec: rescue TapFormulaUnavailableError in recursive_dependencies
2017-07-02 06:25:25 -07:00
Markus Reiter and GitHub
eb110e94f0
Merge pull request #2772 from reitermarkus/dmg-eula
...
Fix DMG mounting.
2017-07-02 02:04:07 +02:00
ilovezfs and GitHub
a94a938285
Merge pull request #2829 from mislav/bump-formula-pr-unshallow
...
Fix `bump-formula-pr` when working with a shallow git clone
2017-07-01 09:15:07 -07:00
Markus Reiter and GitHub
fd5e673d2d
Merge pull request #2825 from reitermarkus/refactoring
...
Refactoring using `Forwardable` and `DelegateClass`.
2017-07-01 05:32:19 +02:00
JCount and GitHub
0a5052141d
Merge pull request #2827 from JCount/version-improve-url-only-version-parsing
...
version: improve url-only version parsing
2017-06-30 11:37:28 -04:00
Gautham Goli
e6938d9201
Enable LegacyPatches cop
2017-06-30 20:25:18 +05:30
Gautham Goli
8c167b23cc
audit: Don't run audit methods when --only-cops is passed
2017-06-30 20:25:12 +05:30
JCount
d50312ae6b
version_spec: add tests for char prefixed and w.x.y.z url-only styles
2017-06-30 10:53:24 -04:00
JCount
f87fadd4ee
version: improve parsing of url-only, non-filename versions
...
add support for styles prefixed with a r,v,V and an optional _ ,
and styles with four groups of digits, seperated by periods;
combinations of the two are also supported
2017-06-30 10:53:24 -04:00
Mike McQuaid and GitHub
bfe4eed034
Merge pull request #2826 from chrmoritz/languagenode
...
language/node: multiple improvements
2017-06-30 15:14:32 +01:00
Mike McQuaid and GitHub
202b3bc2c1
Merge pull request #2813 from DomT4/high_sierra_updates
...
High Sierra: update expected CLT/libcurl pkgconfig file.
2017-06-30 15:10:23 +01:00
Markus Reiter and GitHub
29ffe15890
Merge pull request #2819 from reitermarkus/trash
...
🗑️ Use AppleScript instead of Swift for trashing.
2017-06-30 14:38:57 +02:00
Misty De Meo and GitHub
0077e4f20e
Merge pull request #2837 from mistydemeo/audit_request_full_index_patches
...
audit: ask for full_index patches
2017-06-29 19:57:14 -07:00