Commit Graph
202 Commits
Author SHA1 Message Date
Mike McQuaidandGitHub f1fa475c4f Merge pull request #2843 from GauthamGoli/audit_conflicts_rubocop
audit: Port audit_conflicts method to rubocop and add tests
2017-07-08 07:44:16 +01:00
Gautham Goli 4ed34f91c2 audit: Port audit_conflicts method to rubocop and add tests 2017-07-07 20:46:57 +05:30
Mike McQuaid bddafe4d54 audit: don't suggest non-stable versioned alias.
Additionally handle the case where a formula has been installed as
devel/HEAD rather than just e.g. `brew audit --devel`.
2017-07-07 09:30:18 +01:00
Gautham Goli 8c167b23cc audit: Don't run audit methods when --only-cops is passed 2017-06-30 20:25:12 +05:30
Misty De Meo 87fa20076c audit: ask for full_index patches 2017-06-28 20:49:37 -07:00
Mike McQuaidandGitHub f4cdd7a051 Merge pull request #2790 from GauthamGoli/audit_legacy_patches_rubocop
audit: Port audit_legacy_patches method to rubocop and add tests
2017-06-25 08:54:59 +01:00
Gautham Goli 2e82754776 audit: Port audit_legacy_patches method to rubocop and add tests 2017-06-24 17:06:26 +05:30
Mike McQuaid b9e3daac70 audit: don't use Fossies as a primary URL.
As requested in:
https://github.com/Homebrew/homebrew-core/issues/14486#issuecomment-307753234
2017-06-23 19:34:25 +01:00
Gautham Goli 4d7a983415 audit: Port audit_checksum method to rubocop and add tests 2017-06-16 19:45:16 +05:30
Mike McQuaid 7a0aff1080 Autocorrect Rubocop Style/PerlBackrefs. 2017-06-10 20:23:20 +03:00
Mike McQuaidandGitHub 113a7a81d0 Revert "audit: Port audit_checksum method to rubocop and add tests" 2017-06-09 11:16:11 +03:00
Gautham Goli d09d5ecc55 audit: Port audit_checksum method to rubocop and add tests 2017-06-08 21:53:46 +05:30
Mike McQuaid cc8bc44286 audit: ensure curl always has an HTTP url.
This makes using `HOMEBREW_CURL` significantly nicer as then the system
`curl` (that, on old versions, sucks at SSL) can download a version of
`curl` that it can build from source.
2017-06-08 14:20:04 +03:00
Mike McQuaid 3a08f81470 audit: fix pypi strict audit capture group. 2017-06-03 20:25:12 +01:00
Mike McQuaidandGitHub 1d034265af Merge pull request #2726 from MikeMcQuaid/audit-pypi-urls
audit: check pypi URLs
2017-06-03 10:01:22 +01:00
Mike McQuaidandGitHub d6c4dfc783 Merge pull request #2725 from MikeMcQuaid/audit-formulae-options-fix
audit: fix false negative for formulae options.
2017-06-03 10:01:10 +01:00
Mike McQuaid cbfc83309f audit: check pypi URLs
#373 implemented as a strict check (thanks nijikon)
2017-06-02 22:28:07 +01:00
Mike McQuaid 6a0086a0a7 audit: fix false negative for formulae options.
Handle the case where an if/unless is detected and then write off this
line for option handling.
2017-06-02 22:26:37 +01:00
Markus Reiter 2d6ae61314 Re-revert "Fix operator spacing." 2017-06-02 19:22:05 +02:00
Gautham Goli cf848a14d2 audit: Port audit_caveats method to rubocop and add tests 2017-05-31 22:59:48 +05:30
Gautham Goli 51f2338dd5 audit: Port audit_text method to rubocop and add tests 2017-05-30 15:28:05 +05:30
Mike McQuaid 7a38bab333 Fixup all RuboCop warnings. 2017-05-29 18:43:18 +01:00
JCountandGitHub dd5d4880dc Merge pull request #2658 from JCount/audit-fix-versioned-aliases-homebrew-core
audit: fix versioned alias errors in homebrew/core introduced in a7c6a57
2017-05-21 21:54:17 -04:00
Markus Reiter 473bdadbcd Change error messages. 2017-05-22 02:04:02 +02:00
Markus Reiter 330307b01a Use FormulaVersions for checksum check. 2017-05-22 02:01:57 +02:00
Markus Reiter ade62aa1b1 Add the same check for Formulae. 2017-05-22 02:01:57 +02:00
JCount aa81f56356 audit: fix versioned alias errors in homebrew/core introduced in a7c6a57
This fixes #2657 which in turn were caused by an oversight in #2664
2017-05-21 12:00:56 -04:00
Mike McQuaidandGitHub a7c6a57c8e Merge pull request #2644 from JCount/audit-fix-tap-versioned-aliases
audit: fix full versioned alias name resolution in taps
2017-05-20 10:57:30 +01:00
Markus ReiterandGitHub f0dc1d96c5 Merge pull request #2537 from reitermarkus/pathname-to_str
Remove `to_s` from some `Pathname`s.
2017-05-18 09:39:07 +02:00
JCount cd8d7a8a44 audit: fix full versioned alias name resolution in taps
This fixes an issue where audit would prompt for the creation
of an already existing versioned alias while at the same time
declaring the existing alias invalid.
2017-05-17 15:18:59 -04:00
Mike McQuaidandGitHub ea8be174f6 Merge pull request #2631 from GauthamGoli/audit_homepage_rubocop
audit: Port audit_homepage method to rubocop and add tests
2017-05-15 10:02:47 +01:00
Gautham Goli 91efcb045e Port audit_homepage method to rubocop and add tests 2017-05-14 22:05:46 +05:30
Mike McQuaidandGitHub 75d230318a Merge pull request #2627 from MikeMcQuaid/audit-fix-option-detection
audit: fix dependency option detection.
2017-05-14 15:09:07 +01:00
Mike McQuaid d5006ef012 audit: fix dependency option detection.
Instead of trying to do this all with a single regex give up and do a
two stage process. Eventually I'll end up implementing a full ruby
parser here 🧌.
2017-05-13 13:00:00 +01:00
Mike McQuaid b14f1572b7 audit: more checks for versioned aliases.
Check that a required versioned alias has a valid name (rather than
assuming it’s fine based on it’s existence alone) and check for
the presence of invalid version aliases.

This should handle the case where someone bumps a formula but forgets
to rename the alias that’s mentioned in #2596.
2017-05-09 15:10:29 +01:00
Markus Reiter 5828eefd01 Remove to_s from some Pathnames. 2017-05-08 13:37:28 +02:00
Mike McQuaid 57db2e539e Revert "Merge pull request #2597 from MikeMcQuaid/vendor-gems"
This reverts commit 3e4547f52e, reversing
changes made to 6edf9382bc.
2017-05-07 17:28:39 +01:00
Mike McQuaid ee253e465b Vendor all Homebrew's gems.
Homebrew's actually ended up using a fair few gems. While we want to
avoid Bundler at runtime (and this PR still does that, in fact uses
Bundler even less at runtime than it did before) writing our own version
to use at build-time seems redundant.
2017-05-07 13:52:57 +01:00
Mike McQuaidandGitHub 555505ec54 Merge pull request #2531 from GauthamGoli/audit_cops_options_refactor
audit: Allow skipping/selective running of cops and cops refactor
2017-05-03 11:28:25 +01:00
Gautham Goli fed668b330 Add --only-cops,--except-cops options for brew style and simplify cop names 2017-05-03 14:49:23 +05:30
Dominyk Tiller 9aeb8f0f0b audit: match start of string, not line 2017-05-02 19:30:41 +01:00
Dominyk Tiller 80483c0206 audit: whitelist 'Firefox' in keg_only_style 2017-05-02 19:05:56 +01:00
Gautham Goli c3330c289d Add --only-cops,--except-cops options for brew audit
Also refactor audit cops into two "departments"
 - FormulaAudit
 - FormulaAuditStrict
2017-05-02 23:26:12 +05:30
Gautham Goli a4568a8697 Let cops run without --strict flag 2017-05-02 23:14:44 +05:30
Dominyk Tiller 85053b1476 audit: add audit_keg_only_style 2017-05-01 19:22:34 +01:00
Dominyk Tiller 2ad43cb1fd audit: formally ban go get usage
There's been an informal ban for a while but let's
be punchier because this crops up still.
2017-04-28 17:38:01 +01:00
Mike McQuaid 1c9cfb2419 audit: tweak dependency option audit.
Make sure that `if build.with?` isn't caught.
2017-04-27 16:30:05 +01:00
Mike McQuaid 5647fdb2f9 audit: fix audit of new formulae.
When auditing new formulae without `--new-formula` the
`audit_revision_and_version_scheme` method fails ungracefully. Instead,
set some better defaults so fewer checks are needed.

Fixes #2551.
2017-04-26 11:33:13 +01:00
Mike McQuaid b2a291529d audit: fix use of search_tap method.
This was removed in #2540 but this call site was note updated to use
the `search_taps` method instead.
2017-04-25 12:08:50 +01:00
Mike McQuaidandGitHub ceb1629ad7 Merge pull request #2465 from GauthamGoli/audit_components_port_rubocop
audit: audit_components method to rubocops and tests
2017-04-24 10:06:41 +01:00