Commit Graph
11908 Commits
Author SHA1 Message Date
Markus Reiter 1a96dc39d1 Add audit check to see if both version and checksum changed. 2017-05-22 02:01:57 +02:00
Mike McQuaidandGitHub 6d8c170e50 Merge pull request #2660 from MikeMcQuaid/env-filtering-test
formula: ensure HOMEBREW_PREFIX/bin in test PATH.
2017-05-21 16:35:03 +01:00
Mike McQuaid d89c870621 formula: ensure HOMEBREW_PREFIX/bin in test PATH.
Only likely to kick in when environment filtering is enabled.

Otherwise we need to tediously add a dramatic number of PATHs to tests
or recurse through the runtime formulae dependencies and add all them.

CC @ilovezfs
2017-05-21 13:55:44 +01:00
Mike McQuaid 49e8c19feb formula: build dependencies are never missing.
If the formula is already installed and they've been removed: that's ok.

Fixes #2625.
2017-05-21 13:51:33 +01:00
Mike McQuaidandGitHub 7000f50d5f Merge pull request #2646 from sjackman/replace_text_in_files
replace_text_in_files: Regex match is greedy
2017-05-20 10:57:41 +01:00
Mike McQuaidandGitHub a7c6a57c8e Merge pull request #2644 from JCount/audit-fix-tap-versioned-aliases
audit: fix full versioned alias name resolution in taps
2017-05-20 10:57:30 +01:00
Markus ReiterandGitHub e1098b0e6d Merge pull request #2638 from reitermarkus/matchers
Use scoped RSpec matchers.
2017-05-19 23:24:35 +02:00
Markus ReiterandGitHub 3139383fe6 Merge pull request #2623 from rednoah/master
Support GPG (signed data) container in Homebrew Cask
2017-05-19 20:48:35 +02:00
Esther W 6325fb88c5 Make behavior clearer by returning false 2017-05-18 15:43:54 -07:00
Esther W 4da2f24b0e Remove to_s method 2017-05-18 13:41:36 -07:00
Reinhard Pointner 61db2a58a5 Exactly match extension "gpg" 2017-05-19 04:24:36 +08:00
Esther W 37222c1953 Fix implicit conversion of nil into string error 2017-05-18 13:08:19 -07:00
Markus ReiterandGitHub 0977b4a17d Merge pull request #2494 from numbermaniac/fix-env
cask manpage: Fix section header link for Environment
2017-05-18 18:40:08 +02:00
Reinhard Pointner 6473a90c57 Extract to name without *.gpg extension 2017-05-18 22:32:00 +08:00
Markus ReiterandGitHub f0dc1d96c5 Merge pull request #2537 from reitermarkus/pathname-to_str
Remove `to_s` from some `Pathname`s.
2017-05-18 09:39:07 +02:00
Shaun Jackman 175c2e9303 replace_text_in_files: Regex match is greedy
The regex matches the longest possible string. Order does not matter.
2017-05-17 23:55:29 -07:00
JCount cd8d7a8a44 audit: fix full versioned alias name resolution in taps
This fixes an issue where audit would prompt for the creation
of an already existing versioned alias while at the same time
declaring the existing alias invalid.
2017-05-17 15:18:59 -04:00
Mike McQuaid 2b726383f1 info: fix conflicts formatting. 2017-05-16 10:05:05 +01:00
Mike McQuaidandGitHub aeaf9af711 Merge pull request #2470 from johnhawkinson/conflicts-info
Display formula conflict reasons
2017-05-16 08:45:45 +01:00
Markus Reiter 3cdf8f938a Use scoped RSpec matchers. 2017-05-15 17:23:40 +02:00
Mike McQuaidandGitHub 8e2198ff01 info: tweak conflicts output code. 2017-05-15 10:40:07 +01:00
Mike McQuaidandGitHub ea8be174f6 Merge pull request #2631 from GauthamGoli/audit_homepage_rubocop
audit: Port audit_homepage method to rubocop and add tests
2017-05-15 10:02:47 +01:00
Mike McQuaidandGitHub 9889b42ec4 Merge pull request #2628 from GauthamGoli/formula_desc_cop_fix
audit: Detect multiline and interpolated strings in formula desc cop
2017-05-15 10:01:38 +01:00
John Hawkinson 33d4c95a28 info: use more string interpolation 2017-05-14 15:09:01 -04:00
Gautham Goli 91efcb045e Port audit_homepage method to rubocop and add tests 2017-05-14 22:05:46 +05:30
Mike McQuaidandGitHub 75d230318a Merge pull request #2627 from MikeMcQuaid/audit-fix-option-detection
audit: fix dependency option detection.
2017-05-14 15:09:07 +01:00
Mike McQuaidandGitHub 80df74893a Merge pull request #2621 from MikeMcQuaid/rubocop-module-length
rubocop: don't always care about module length.
2017-05-14 15:08:58 +01:00
Mike McQuaidandGitHub 13efa8656e Merge pull request #2620 from MikeMcQuaid/more-env-filtering-tweaks
More environment filtering tweaks
2017-05-14 15:08:47 +01:00
Mike McQuaidandGitHub d0e3f3574f Merge pull request #2619 from MikeMcQuaid/more-audit-versioned-aliases
audit: more checks for versioned aliases.
2017-05-14 15:08:27 +01:00
Mike McQuaidandGitHub e8ef21252d Merge pull request #2617 from MikeMcQuaid/interactive-home-access
Allow --interactive to access HOME
2017-05-14 15:08:16 +01:00
Mike McQuaidandGitHub 25e9e658af Merge pull request #2616 from MikeMcQuaid/devel-opt-aliases
keg: skip opt versioned aliases for devel/head.
2017-05-14 15:08:06 +01:00
Gautham Goli 80572939b4 Update string_content method to support multiline strings, add test for same 2017-05-13 18:48:40 +05:30
Mike McQuaid d5006ef012 audit: fix dependency option detection.
Instead of trying to do this all with a single regex give up and do a
two stage process. Eventually I'll end up implementing a full ruby
parser here 🧌.
2017-05-13 13:00:00 +01:00
Mike McQuaid 8205e61e64 More environment filtering tweaks
- only document HOMEBREW_* variables in the manpage (although still
  read from all the original environment variables).
- resort manpage environment variables in alphabetical order
- check the original path for trailing slashes
2017-05-13 11:42:01 +01:00
Gautham Goli d04f295de3 Add autocorrect method for ComponentsOrder rubocop and tests 2017-05-13 03:09:55 +05:30
Reinhard Pointner 5c59b3352f Support GPG (signed data) container in Homebrew Cask (test case) 2017-05-11 16:27:45 +08:00
Reinhard Pointner b0987ffb33 Support GPG (signed data) container in Homebrew Cask 2017-05-11 16:26:16 +08:00
Reinhard Pointner 3668a7abb1 Support GPG (signed data) container in Homebrew Cask 2017-05-10 23:18:42 +08:00
mansimarkaur 45754a1888 diagnostic_spec.rb: check_access_lock_dir test
Added assertion to check `HOMEBREW_LOCK_DIR.stat.mode` changes after `HOMEBREW_LOCK_DIR.chmod 0555`
2017-05-10 03:02:55 +05:30
Mike McQuaid 7055abc436 Allow --interactive to access HOME
This may result in a slightly varied build but it’s generally just far
less annoying to be able to access all your e.g. shell configuration.
2017-05-09 20:00:11 +01:00
Mike McQuaid 76f48d338e keg: skip opt versioned aliases for devel/head.
These versioned aliases don’t correspond to the correct version if not
Installed from stable.

Fixes #2596.
2017-05-09 15:10:57 +01:00
Mike McQuaid b14f1572b7 audit: more checks for versioned aliases.
Check that a required versioned alias has a valid name (rather than
assuming it’s fine based on it’s existence alone) and check for
the presence of invalid version aliases.

This should handle the case where someone bumps a formula but forgets
to rename the alias that’s mentioned in #2596.
2017-05-09 15:10:29 +01:00
Mike McQuaid 0fb1fb51be rubocop: don't always care about module length.
We don't care about this in external taps as this is more about code
architecture than code style.
2017-05-09 12:58:49 +01:00
Markus Reiter 5828eefd01 Remove to_s from some Pathnames. 2017-05-08 13:37:28 +02:00
Mike McQuaidandGitHub f1d4c4be78 Merge pull request #2607 from MikeMcQuaid/travis-ci-tweaks-2
Travis CI tweaks.
2017-05-08 09:51:06 +01:00
Mike McQuaid 9853a78397 Travis CI tweaks.
Attempt to improve Travis CI. This time without any vendoring gems
nonsense.
2017-05-08 08:38:25 +01:00
Mike McQuaidandGitHub e4ecf6d6bc Merge pull request #2591 from retokromer/patch-1
fix date-based versioning
2017-05-07 21:13:52 +01:00
Mike McQuaid 57db2e539e Revert "Merge pull request #2597 from MikeMcQuaid/vendor-gems"
This reverts commit 3e4547f52e, reversing
changes made to 6edf9382bc.
2017-05-07 17:28:39 +01:00
Mike McQuaid e1bbab6ca6 Revert "Merge pull request #2603 from MikeMcQuaid/tweak-gem-vendoring"
This reverts commit 2372872974, reversing
changes made to 3e4547f52e.
2017-05-07 17:28:37 +01:00
Mike McQuaid a76392dd5f Revert "Merge pull request #2602 from MikeMcQuaid/travis-ci-tweaks"
This reverts commit 8d948e4b0b, reversing
changes made to 2372872974.
2017-05-07 17:28:34 +01:00