Markus Reiter
2eb366ff38
Fix SystemCommand without arguments.
2017-10-30 22:04:54 +01:00
Mike McQuaid and GitHub
2d5bb029a5
Merge pull request #3387 from MikeMcQuaid/env-std-homebrew-paths
...
ENV/std: fully extend from HOMEBREW_PATH.
2017-10-30 16:09:01 +00:00
Mike McQuaid
6ddf3f8796
bump-formula-pr: add --no-browse option.
...
If `--no-browse` is passed, don't pass the `--browse` argument to `hub`
which opens the pull request URL in a browser. Instead, output it to the
command line.
2017-10-30 09:14:53 +00:00
Mike McQuaid and GitHub
7a0fdc3d03
Merge pull request #3393 from MikeMcQuaid/with_env_tweaks
...
Tweak use of with_env
2017-10-30 08:17:06 +00:00
Mike McQuaid and GitHub
4c44266aa5
Merge pull request #3394 from MikeMcQuaid/sh-no-ps1
...
cmd/sh: set working PS1 for zsh
2017-10-29 19:17:26 +00:00
Mike McQuaid
3549377478
cmd/sh: set working PS1 for zsh.
...
The `bash`, default one is broken on `zsh`.
2017-10-29 17:23:05 +00:00
Mike McQuaid and GitHub
c59c0d6820
Merge pull request #3376 from tomjonandy/fix/keychain-credentials
...
Fix issue where keychain github credentials wouldn't work
2017-10-29 16:57:21 +00:00
Mike McQuaid and GitHub
215f49684b
Merge pull request #2795 from issyl0/desc_no_full_stops
...
formula_desc_cop: ensure no full stops at the end of desc
2017-10-29 16:56:00 +00:00
Isabell Long
640b1e9dcb
formula_desc_cop: ensure no full stops at the end of desc
...
- This was a suggestion by Mike McQuaid in my `homebrew-core` audit
description PR. Based on ilovezfs's incantation `grep -r -E 'desc
".*\."' *.rb`, some formulae descriptions do end in full stops. (My
initial assessment of this failed to account for the fact that
descriptions are strings and so end in `"`.)
- Add an autocorrect for this cop, too.
2017-10-29 15:19:31 +00:00
Mike McQuaid
ca189437e4
Tweak use of with_env
...
- Use it in more places where it saves code
- Allow using symbolic keys for a cleaner interface
- Use `HOMEBREW_GEM_*` instead of `GEM_OLD_*`
2017-10-29 14:44:43 +00:00
Mike McQuaid
f72aba548d
ENV/std: fully extend from HOMEBREW_PATH.
...
Rather than just re-adding HOMEBREW_PREFIX/bin if it's missing re-add
everything from HOMEBREW_PATH. This works well with or without
environment filtering being enabled but with environment filtering it
ensures that ENV/std just builds on the original user environment.
2017-10-29 13:41:51 +00:00
Mike McQuaid and GitHub
9dbff4ebbe
Merge pull request #3388 from MikeMcQuaid/bump-formula-pr-env-filtering
...
bump-formula-pr: always use HOMEBREW_PATH.
2017-10-29 13:33:16 +00:00
Mike McQuaid
e88fd4a868
bump-formula-pr: always use HOMEBREW_PATH.
...
Fixes this when using environment filtering.
2017-10-28 21:46:30 +01:00
Mike McQuaid
3448335a14
system_config: get perl/ruby from HOMEBREW_PATH.
...
This is the actual user path when env filtering is enabled.
2017-10-28 20:38:00 +01:00
Mike McQuaid and GitHub
7caca57073
Merge pull request #3380 from jmsundar/apfs_tap-info
...
tap-info: handle APFS returning hash order
2017-10-28 13:08:12 +01:00
Jayendra Minakshisundar
ea7d356e08
style changes
2017-10-28 14:56:51 +05:30
Mike McQuaid and GitHub
b2e2e4b917
Merge pull request #3381 from iMichka/flock
...
lock.sh: suppress error output when looking for flock
2017-10-27 16:19:05 +01:00
Mike McQuaid
d985838428
lines_cop: add missing e.g. clang++ regex SOL.
...
You need a start of line check in this regex (like was added in the
others) to allow things like `#{bin}/clang++`.
2017-10-27 14:58:07 +01:00
Michka Popoff
b93ed4124c
lock.sh: suppress error output when looking for flock
...
Fixes (on centos6):
which: no flock in (/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)
2017-10-27 15:54:24 +02:00
Mike McQuaid
47bfad64b0
rubocop.yml: re-add Homebrew metrics maximums.
2017-10-27 14:20:37 +01:00
Mike McQuaid
5a8d2352c2
rubocop.yml: reduce tap maximum line length.
2017-10-27 14:20:33 +01:00
Mike McQuaid
8aa697363b
test.flac: add flac fixture.
2017-10-27 09:33:37 +01:00
Mike McQuaid and GitHub
32ce927cae
Merge pull request #3372 from MikeMcQuaid/rubocop-length-taps
...
rubocop: disable length checks.
2017-10-27 08:45:58 +01:00
Mike McQuaid and GitHub
25d8771518
Merge pull request #3368 from MikeMcQuaid/unhide-readall-update-reset
...
Unhide readall and update-reset from manpage.
2017-10-27 08:45:47 +01:00
Jayendra Minakshisundar
590f06187f
tap-info: sort taps by name to handle APFS
2017-10-27 11:41:00 +05:30
Thomas Andrew
0e991095f1
Fix issue where keychain github credentials wouldn't work
2017-10-26 18:54:48 +01:00
JCount and GitHub
badbb00b08
Merge pull request #3352 from JCount/legacy-java-cask-requirement-support
...
java_requirement: support prompting users to install legacy Java casks
2017-10-26 11:26:00 -04:00
Mike McQuaid
6114f48d5d
Unhide readall and update-reset from manpage.
...
These are both tools that end-users can find useful on occasion so it
doesn't make sense to hide them.
2017-10-26 16:14:14 +01:00
Mike McQuaid
1f259c2777
rubocop: disable length checks.
...
We should keep these enabled for Homebrew/brew but for taps these just
end up being annoying and making `brew style` fail for little benefit
2017-10-26 15:52:14 +01:00
Mike McQuaid and GitHub
40b212322c
Merge pull request #3366 from GauthamGoli/lines-cop-false-positives-fix
...
lines_cop: Fix detection of negated expression
2017-10-26 15:28:40 +01:00
JCount
224864b149
java_requirement: support prompting users to install legacy Java casks
...
This enhances the Java requirement to support prompting the user
to install the correct legacy Java version via Cask for formulae
that don't yet work with the latest version of Java. Previously,
even if the formula had a strict requirement that a specific,
older version of Java be used, the messaging would tell the user to
`brew cask install java` (i.e. to install the latest version of Java),
which wouldn't actually satisfy the requirement.
2017-10-26 09:57:03 -04:00
Gautham Goli
09326909af
lines_cop: Fix detection of negated expression
2017-10-26 15:35:14 +05:30
commitay
783983b652
rubocop-cask: 0.15.1
2017-10-26 10:21:46 +10:00
Mike McQuaid and GitHub
0cec599b28
Merge pull request #3361 from MikeMcQuaid/lines_cop_clang
...
lines_cop: fix clang detection.
2017-10-25 08:02:33 +01:00
Markus Reiter and GitHub
8be34a98f8
Merge pull request #3349 from reitermarkus/rubocop-0.51
...
Rubocop 0.51
2017-10-24 21:21:34 +02:00
Markus Reiter and GitHub
632fdca2d4
Merge pull request #3306 from amyspark/hacktoberfest-quash-cask-help
...
Fixes querying Cask commands' help
2017-10-24 20:54:24 +02:00
Markus Reiter
a99a19819c
Update rubocop-cask to 0.15.0.
2017-10-24 19:39:40 +02:00
Markus Reiter
0ea855c6e6
Add missing require "forwardable".
2017-10-24 19:39:40 +02:00
Markus Reiter
23ec8e07d4
Use / to join path.
2017-10-24 19:39:40 +02:00
Markus Reiter
526299913f
Remove usless comments.
2017-10-24 19:39:40 +02:00
Markus Reiter
b63a5cbd4b
Don't require "thread".
2017-10-24 19:39:40 +02:00
Markus Reiter
8821cdc492
Include FileUtils in spec_helper.
2017-10-24 19:39:40 +02:00
Markus Reiter
f0a512ace4
Don’t use Style/StderrPuts.
2017-10-24 19:39:40 +02:00
Markus Reiter
7e970216a3
Refactor and fix RuboCop specs.
2017-10-24 19:39:40 +02:00
Markus Reiter
fd29511bae
Update to RuboCop 0.51.
2017-10-24 19:39:40 +02:00
Mike McQuaid
d067b5f434
lines_cop: fix clang detection.
...
We only care about e.g. `gcc`/`llvm-gcc`/`clang` being at the beginning
of a `system` call and not anywhere within the string.
2017-10-24 16:03:13 +01:00
L. E. Segovia
09e26b1152
brew style fixes
2017-10-24 10:17:11 -03:00
L. E. Segovia
2bfc7904fb
Simplify cask help check
2017-10-24 08:04:49 -03:00
ilovezfs
1937625d86
github: require formula name to be in issue title
2017-10-24 03:07:33 -07:00
Mike McQuaid and GitHub
7f46dcfa35
Merge pull request #3313 from GauthamGoli/audit_line_rubocop_part_4_rebase_attempt_1
...
audit: Port line_problems to rubocop and add tests part 4
2017-10-24 10:36:31 +01:00
Markus Reiter