Commit Graph
99 Commits
Author SHA1 Message Date
Dawid Dziurla 8ff7601a92 define default prefix constants
also use them to detect if prefix line in bottle block is needed
2019-09-30 16:46:53 +02:00
EricFromCanada 8a8359cdd4 manpages: sentence rewording for readability
Use active voice when applicable, better verbs & adjectives, preposition usage, proper tense, etc.
2019-08-20 09:05:45 -04:00
EricFromCanada b4303cd983 manpages: fix command & option descriptions 2019-08-20 09:03:33 -04:00
Cheng Xu 6437a70a5f Revert "Elide default root_url in the bottle block"
This reverts commit e4f4e0f98b.

This is no longer necessary as `HOMEBREW_FORCE_HOMEBREW_ON_LINUX`
is set when uploading bottles for Homebrew.
2019-05-20 15:09:31 +08:00
Mike McQuaid c4f72312ce Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid fc6bd2ea1c Fixup more frozen string handling. 2019-04-20 14:07:29 +09:00
Mike McQuaid 36dbad3922 Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid e40b171127 Rename cli_parser to cli/parser. 2019-04-17 22:16:50 +09:00
EricFromCanada 560ccddb69 help: rewrap output to 80 columns
Accounts for paragraph breaks and option descriptions. Also fixes some help text nits.
2019-03-11 12:52:07 -04:00
Mike McQuaid d64429a736 rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
Mike McQuaid bbea109926 dev-cmd: remove --help headers and tweak docs. 2019-01-30 21:39:28 +00:00
Mike McQuaid 88b98969a5 bottle: detect vim's lack of relocatableness.
References https://github.com/Homebrew/homebrew-core/issues/35236.
2019-01-21 20:17:59 +00:00
Shaun JackmanandGitHub 81021e6a60 Merge pull request #5365 from iMichka/bottle
brew bottle --keep-old: Combining :any and :any_skip_relocation yields :any
2018-12-04 08:56:14 -08:00
Michka Popoff af92fe2f17 bottle: Fix bottling for Linux
When there is no previous linux bottle, and the bottle block looks like this:
bottle do
  sha256 "5cbcce4556b41ece91f01778068f481514bc3a0d5447ddbff048797236cc9b29" => :mojave
  sha256 "15748ef1ffefa088f7c958e6935c6eec794781858e6190196e18e94ab768adc2" => :high_sierra
  sha256 "49eb0e5d27b8868b2dba20efbde3ef75becc0cbf5ea230c00e5745e2df697cb6" => :sierra
end

then the bottling fails with:
Error: --keep-old was passed but there are changes in:
cellar: old: "/home/linuxbrew/.linuxbrew/Cellar", new: :any_skip_relocation
==> FAILED

This change allows to run the bottling step for these cases.
2018-12-03 23:34:26 +01:00
Shaun Jackman 79b1d4178e bottle: Ignore matches to source code
Ignore matches to source code, which is not required at run time.
These matches may be caused by debugging symbols.
2018-12-03 08:22:29 -08:00
Shaun Jackman cbeb077b2e bottle: Skip matches to files in build deps
Files in build dependencies are not required at run time.
2018-12-02 13:29:43 -08:00
Steven Peters 2f2304ea40 dev-cmd/bottle: recognize version_scheme in merge 2018-11-10 01:41:45 -08:00
Mike McQuaid 737b84b54b brew style --fix fixes. 2018-11-02 17:29:23 +00:00
Steven Peters 7116b74705 dev-cmd/bottle: require arg for --root-url 2018-10-29 14:54:37 -07:00
EricFromCanada 388781f6a7 dev-cmd/: remove colons from command specs.
These aren't needed when converting Parser-based help text to man page or Markdown formats.
Includes regenerated docs.
2018-10-19 13:12:55 -04:00
EricFromCanada ddf057f3dd dev-cmd/: edit help text and descriptions. 2018-10-19 13:12:11 -04:00
Gautham Goli a03d2e0cd1 man: Correct option synopsis 2018-10-03 19:49:46 +05:30
Gautham Goli f60582ca48 man: Remove [] from command synopsis 2018-10-03 19:49:45 +05:30
Gautham Goli 446b1cb9e3 man: Seperate global options into a section 2018-10-03 19:49:45 +05:30
Gautham Goli e0e876cf37 man: Make command heading H3 2018-10-03 19:49:44 +05:30
Gautham Goli 4f58f2db99 man: Generate dev cmd manpages 2018-10-03 19:49:41 +05:30
Gautham Goli b6c456b681 Extract out arg parsing method to <cmd>_args method 2018-10-03 19:19:04 +05:30
Mike McQuaidandGitHub 4d1de3334c Merge pull request #4912 from MikeMcQuaid/activesupport-hash-deep-merge
Use ActiveSupport Hash#deep_merge
2018-09-18 09:19:24 +01:00
Mike McQuaid 0c6331878f Use ActiveSupport Hash#deep_merge
And delete our own implementation.
2018-09-17 14:53:01 +01:00
Markus Reiter e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Markus Reiter 3a0a9f9073 Add String#delete_prefix backport. 2018-09-16 20:07:34 +02:00
Mike McQuaid 955214abc0 Use ActiveSupport Object#blank? and #present? 2018-09-14 17:02:19 +01:00
Mike McQuaidandGitHub f3ea2a85da Merge pull request #4890 from sjackman/elide-root-url
Elide default root_url in the bottle block
2018-09-13 14:29:45 +01:00
Steven Peters c4ba06c9fc dev-cmd/bottle: fix --keep-old with --root-url
Don't strip the : from root_url when using --keep-old.
Closes #4554.
2018-09-12 14:48:43 -07:00
Shaun Jackman e4f4e0f98b Elide default root_url in the bottle block 2018-09-12 13:10:46 -07:00
Shaun Jackman 3c4f9c746e Elide prefix "/usr/local" in bottle block
brew test-bot --ci-upload is run on a Linux machine.
The macOS bottles have a prefix of "/usr/local".
The default prefix on Linux is /home/linuxbrew/.linuxbrew.
Elide prefix "/usr/local" in the bottle block, even it does not match
the default prefix. Ditto for cellar.
2018-09-11 14:21:33 -07:00
Shaun Jackman f6093961ef Add Homebrew::DEFAULT_PREFIX for Linux
The default prefix is /usr/local on macOS
and /home/linuxbrew/.linuxbrew on Linux.
2018-09-11 09:57:08 -07:00
Steven Peters 26e1d17b4d dev-cmd/bottle: save local_filename to json 2018-08-22 01:30:18 -07:00
Markus Reiter d33241bc11 Use -- for bottles. 2018-08-06 17:59:51 +02:00
Mike McQuaid 44eeb59774 bottle: add --json and --merge docs.
Fixes #4519.
2018-07-23 14:51:47 +01:00
Shaun Jackman 1b688a3a25 Relocate bottles on Linux using patchelf
Ensure patchelf is installed to pour bottles and build bottles.
2018-07-12 10:21:26 -07:00
Mike McQuaidandGitHub 61a8c4d1fb Merge pull request #4300 from apjanke/new-rubocop-version
Upgrade to Rubocop 0.57.2
2018-07-01 09:08:16 +01:00
Andrew Janke e0a8a79921 Style fixes for Rubocop 0.57.1 2018-06-30 19:40:14 -04:00
Mike McQuaid facd76bc51 portable-ruby: respect HOMEBREW_BOTTLE_DOMAIN variable.
This was requested in:
https://discourse.brew.sh/t/adding-additional-download-sources-to-homebrew/2446

With this change you can use e.g. Artifactory for Homebrew's portable
ruby.
2018-06-29 19:51:18 +01:00
Mike McQuaid 5e6c40e28f Make versioned formulae regex more consistent.
Share the regex where possible and otherwise ensure they are identical.
2018-06-18 14:36:51 +01:00
Ilya Dmitrichenko 22d88821c3 Ignore any version of Go, when it is a dependency of a bottle 2018-06-15 11:36:41 -07:00
Gautham Goli fba52e2f74 cli_parser: Store parsed args in Homebrew.args and access args everywhere else 2018-05-30 00:05:39 +05:30
Gautham Goli a93e7ab2bd bottle: Use @args 2018-04-10 19:09:59 +05:30
Shaun Jackman df68d12be4 bottle: Add option --or-later
If --or-later is passed, append _or_later to the bottle tag.
2018-04-09 20:58:38 -07:00
Gautham Goli d22b750e17 Store common switch as Homebrew.args global var 2018-04-10 00:00:35 +05:30