Commit Graph
204 Commits
Author SHA1 Message Date
Mike McQuaid 36dbad3922 Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid 2f1c6e9ca5 Cleanup cmd/* tests
- Test `_args` methods
- Remove multiple integration tests (except where essential
  e.g. `install`, `help`)
2019-03-28 08:35:36 +00:00
Mike McQuaid 1e5cfcc028 Separate tap tests into separate, correct files. 2019-03-27 13:35:42 +00:00
Mike McQuaid aa44509be9 Test dev-cmd *_args methods
Also, add a few missing invocations.
2019-03-27 13:35:42 +00:00
Mike McQuaid 3615f891f7 tap-new: improve output.
Note the tap path.

References #5901.
2019-03-23 12:41:35 +00:00
Mike McQuaid 17f3ee1957 Improve Bundler cleanup
Rather than trying to be smart and doing this ourselves in `brew cleanup` let’s just installed Bundler somewhere it doesn’t try to clean itself up and use `bundle install --cleanup` when we need cleanup done.

Also, use `ohai` and `odie` when possible as they look nicer.
2019-02-27 14:02:46 +00:00
Mike McQuaid 4ace1af297 help: improve command --help output. 2019-01-30 21:39:29 +00:00
Mike McQuaid 9eabcdad7d Make install/reinstall/upgrade options more consistent. 2019-01-29 19:25:59 +00:00
Mike McQuaidandGitHub 618f75c071 Merge pull request #5619 from GauthamGoli/install-args
install: Use CLI::Parser to parse args
2019-01-29 14:11:22 +00:00
Mike McQuaid 49d3849507 cmd/install_spec: test new invalid option behaviour. 2019-01-29 10:48:39 +00:00
Mike McQuaid eed1444d61 Update deprecations and cleanup
- Move `odeprecated` to `odisabled`
- Remove `odisabled`
- Enable automatic cleanup on install/reinstall/upgrade.
2019-01-23 21:57:40 +00:00
Gautham Goli 9d287483b7 cat: Use CLI::Parser to parse args 2019-01-19 19:36:55 +05:30
Mike McQuaid 170c5493a4 Update deprecations
- Add some `odeprecated`
- Make some `odeprecated` now `odisabled`
- Remove `odisabled` code.
- Remove old update migrations
- Remove GCC 4.0 compiler
- Remove Tiger-only code
- Remove 32-bit-only code
- Remove use of LD64
- Remove GCC 4.3 - 4.8 support.
2019-01-08 19:13:46 +00:00
Mike McQuaid 8cfcc7fcf0 cleanup: run and replace brew prune.
It's always seemed a bit pointless to me that we have both of these
commands. Given we're doing more and more to recommend (and eventually,
safely, automatically run (see #4760) `brew cleanup` let's roll their
functionality into a single command.
2019-01-02 13:21:34 +00:00
Shaun Jackman f59c417909 test/cmd/uninstall: Prevent can't modify frozen object
Fix the error:
  RuntimeError:
    can't modify frozen object
  # ./test/cmd/uninstall_spec.rb:63:in `block (3 levels) in <top (required)>'

This issue arose after merging PR https://github.com/Homebrew/brew/pull/5300.
2018-12-12 11:52:28 -08:00
Gautham Goli f82a202995 uninstall: Use CLI::Parser to parse args 2018-12-10 23:49:19 +05:30
Claudia 5be80a78f6 Use Homebrew-controlled domain for Cask dummy URLs
In a number of Cask specs, the value of the `homepage` stanza is currently set
to https://example.com. As of 2018-11-28, the TLS certificate served by
example.com seems to be expired, possibly due to an oversight on ICANN’s side.

While the certificate is certainly going to be renewed soon, it would be
desirable for Homebrew’s test result to be less dependent on ICANN’s actions.
This commit changes the homepages of all test Casks to http://brew.sh, whose
domain and TLS certificate are both controlled by Homebrew.
2018-11-28 20:51:55 +01:00
Markus Reiter 04908dcb19 Fix RuboCop for Casks. 2018-11-12 05:01:33 +01:00
Gautham Goli 2736aed1fd reinstall: Use CLI::Parser to parse args 2018-11-07 22:33:32 +05:30
Mike McQuaidandGitHub 6b1d439a87 Merge pull request #5165 from Wojonatior/feature/homebrew_install_cleanup
Implement the HOMEBREW_INSTALL_CLEANUP env to trigger cleanup on reinstall/install/upgrade
2018-11-06 10:29:42 +00:00
Mike McQuaid 737b84b54b brew style --fix fixes. 2018-11-02 17:29:23 +00:00
Jarek Wojciechowski 452d1db109 Merge branch 'master' into feature/homebrew_install_cleanup 2018-10-29 11:24:56 -04:00
Jarek Wojciechowski 51ca60d6d5 add formula cleanup to install and reinstall 2018-10-29 11:23:32 -04:00
Jarek Wojciechowski 18f8adbd5c test and add HOMEBREW_INSTALL_CLEANUP to upgrade 2018-10-23 15:46:07 -04:00
Mike McQuaid 0617dc1c1d info: make verbose analytics use tabular output.
This copies (and slightly improves) the current `brew formula-analytics`
output so `brew formula-analytics` can be adjusted to just output JSON.
2018-10-20 12:06:25 +01:00
Mike McQuaid fe6b78a3f3 Use cache_store for descriptions
This makes use of both the existing interfaces and could use the
existing cache file but we'll create a new one and cleanup the old one
to avoid issues and use a more consistent name.
2018-10-13 08:22:52 -07:00
Mike McQuaidandGitHub 3cba4737a8 Merge pull request #5028 from MikeMcQuaid/setup_remote_tap_symlink
setup_remote_tap: use system taps.
2018-10-03 19:45:52 +01:00
Mike McQuaid ac2aabf287 setup_remote_tap: use system taps.
This saves recloning the taps we use multiple times when already done by
the user.
2018-10-03 19:14:04 +01:00
Gautham Goli b5b988cbb1 help_spec: fix and generate help text in help.rb 2018-10-03 21:12:44 +05:30
Markus Reiter 7a991985a4 Run tests with HOMEBREW_DEVELOPER unset. 2018-09-19 19:43:45 +02:00
alexbostock 188aca1075 Remove blank line 2018-09-17 21:13:19 +01:00
alexbostock 122738709a Add a_json_string matcher and improve tests 2018-09-17 20:49:43 +01:00
alexbostock e733657f04 Separate and improve tests 2018-09-17 09:50:02 +01:00
alexbostock a4020db526 Add test for brew info --json=v1 2018-09-16 22:06:42 +01:00
alexbostock 193b5aa07a Add test for brew commands --quiet 2018-09-16 21:54:19 +01:00
alexbostock 6e1374bef9 Add multiple arguments test for brew cat 2018-09-16 21:41:50 +01:00
Markus Reiter 943e227ca1 Retry all specs with :needs_network. 2018-09-14 16:57:14 +02:00
Mike McQuaidandGitHub 7c056124e5 Merge pull request #4767 from amyspark/upgrade-relink
Upgrade: implement linkage repair
2018-09-13 14:29:58 +01:00
Mike McQuaid 44bcf69d1f cmd/shellenv: use Bash.
This speeds up execution by 3x on my machine and the script is simple
enough to warrant this.
2018-09-13 09:27:44 +01:00
L. E. Segovia d442905719 Upgrade: implement linkage repair
After upgrading existing kegs, we now search and upgrade their
dependents as well. If any are detected that have broken linkage, they
are reinstalled from source.

If there are any formulae in the dependents tree that are pinned, they
are only reinstalled if they're not outdated; in all cases, a suitable
message is printed detailing the kegs that will be acted upon.
2018-09-12 19:28:02 +00:00
James Costian 18d38d7b76 Add brew shellenv - see #4780 2018-09-07 11:37:14 -05:00
Markus Reiter 516a39f5a4 Move migrations into UpdateMigrator module. 2018-08-31 16:51:23 +02:00
Markus Reiter fbcaa8c85a Resolve URL to get real file extension. 2018-08-31 16:51:23 +02:00
Gautham Goli 32bc5535b6 style: Fix npe and add test for corrected offense results 2018-08-28 23:31:35 +05:30
Markus Reiter 888a7073bc Change migration to loop through formulae. 2018-08-06 17:25:29 +02:00
Markus Reiter 7449f9cd15 Fix update-report migration. 2018-08-06 12:52:18 +02:00
Markus Reiter dcf5d8d79b Add test for migrate_cache_entries_to_double_dashes. 2018-08-05 20:38:50 +02:00
Markus Reiter 1003d722bd Use -- to separate download name and version. 2018-08-05 15:57:28 +02:00
Markus Reiter 7762ce32aa Use more descriptive heredoc names. 2018-07-11 18:15:30 +02:00
Mike McQuaid 7cc970fea2 link: refactor, reorder and fix bugs.
The change in #4441 broke the handling of the `elsif`s due to the
change in logic. As every block here has a `next` there's no need to do
an `elsif` in here at all. Additionally, reorder the conditions in here
so you get an appropriate message depending on what you're trying to do.
Finally, tweak some of the messaging to remove things that are ignored
and tell people correct commands to run to link things.
2018-07-10 09:32:42 +01:00