Commit Graph
193 Commits
Author SHA1 Message Date
Alec Clarke af10d13381 Check blacklisted Casks when auditing.
In some cases, certain Casks shouldn't be resubmitted for specific reasons: difficult to maintain, developers maintain their own version, ...

To make sure these cases are restricted - we can add them to a blacklist and have the blacklist checked as part of the `brew cask audit` steps.
2019-09-17 06:29:46 -07:00
Markus Reiter 16d2f8264c Use MacOSRequirement for casks. 2019-08-21 06:57:21 +02:00
Mike McQuaid c4f72312ce Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid 36dbad3922 Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid d1ea6f38d3 Fix mutable constants violations. 2019-04-19 21:46:20 +09:00
Mike McQuaid ef2e297d3b Disable RubyGems by default.
This speeds up all Ruby invocations where we don't need RubyGems by
around 10%. Where we do need RubyGems: include it manually.
2019-04-18 17:45:03 +09:00
Mike McQuaidandGitHub 1281c4a663 Merge pull request #5983 from zachauten/continue-upgrading-casks-after-failure
'brew cask upgrade' will continue upgrading casks after a failure
2019-04-14 10:01:32 +01:00
Zach Auten 41b5b788d5 'brew cask upgrade' will continue upgrading casks after a failure
'cask upgrade' command collects all exceptions thrown
from individual casks during the upgrade process. If
there were more than one cask that raised exceptions
during the upgrade process, a MultipleCaskErrors
exception will be thrown.

Issue #5203
2019-04-12 19:26:33 -04:00
Mike McQuaid 1e5cfcc028 Separate tap tests into separate, correct files. 2019-03-27 13:35:42 +00:00
Mike McQuaid 59d680a626 dev-cmd: only one integration test per command.
Integration tests are useful in detecting breakages but much slower so
let's only use one per command and install formula outside the
integration test framework (which is also slow).
2019-03-27 09:45:48 +00:00
Mike McQuaid e095da4d01 rubocop: enable Layout/EmptyLineAfterGuardClause. 2019-02-21 12:55:49 +00:00
Mike McQuaid d64429a736 rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
Markus Reiter 78d4373543 Simplify DEFAULT_DIRS. 2019-02-15 10:09:14 +01:00
Markus Reiter fda6e0cab3 Split cask config into three tiers. 2019-02-15 10:09:14 +01:00
Markus Reiter 1e1ce1c471 Save config file for casks. 2019-02-15 10:09:14 +01:00
Mike McQuaid 1aa8ad09e2 Deprecate macOS versions below Mavericks
And remove all dead/unneeded code.
2019-01-27 12:27:47 +00:00
Mike McQuaidandGitHub f82f3ffe7c Merge pull request #5571 from MikeMcQuaid/supported-cleanup
Warn more on unsupported configurations
2019-01-21 15:38:49 +00:00
Mike McQuaid 234e4aec96 Improve use of default_prefix? in tests. 2019-01-21 14:33:56 +00:00
Mike McQuaid 5c7fbaf259 Update RuboCop RSpec rules
Create a new, seperate RuboCop file that uses our RSpec rule
configuration if a specified tap has a `spec` directory.

Also, while we're here, fix up the various rules so that we don't have
any outdated TODOs, disable some rules for good and fix `brew style`
for Homebrew/bundle.
2019-01-21 13:39:11 +00:00
Mike McQuaid 170c5493a4 Update deprecations
- Add some `odeprecated`
- Make some `odeprecated` now `odisabled`
- Remove `odisabled` code.
- Remove old update migrations
- Remove GCC 4.0 compiler
- Remove Tiger-only code
- Remove 32-bit-only code
- Remove use of LD64
- Remove GCC 4.3 - 4.8 support.
2019-01-08 19:13:46 +00:00
Claudia 5be80a78f6 Use Homebrew-controlled domain for Cask dummy URLs
In a number of Cask specs, the value of the `homepage` stanza is currently set
to https://example.com. As of 2018-11-28, the TLS certificate served by
example.com seems to be expired, possibly due to an oversight on ICANN’s side.

While the certificate is certainly going to be renewed soon, it would be
desirable for Homebrew’s test result to be less dependent on ICANN’s actions.
This commit changes the homepages of all test Casks to http://brew.sh, whose
domain and TLS certificate are both controlled by Homebrew.
2018-11-28 20:51:55 +01:00
Mike McQuaidandGitHub 2562d270b5 Merge pull request #5033 from amyspark/gitjiro-improved
Cask: complete Git-Jiro's HTTPS audit check
2018-11-24 11:43:09 +00:00
L. E. Segovia 5a2743b50d Merge branch 'master' into gitjiro-improved 2018-11-24 01:01:40 +00:00
Markus Reiter cea9942a1d Fix code style. 2018-11-13 05:04:35 +01:00
Claudia 7b320fc03b Move shared Cask examples closer to its clients
In Cask specs, we have recently introduced a couple of specialized
`shared_examples` directories. Those new directories are organized
below their respective packages (for instance,
`cask/artifact/shared_examples` and `cask/cmd/shared_examples`).

This commit moves the rest of the shared examples accordingly.

See also:
https://github.com/Homebrew/brew/pull/5247
2018-11-06 07:19:41 +01:00
Mike McQuaid 737b84b54b brew style --fix fixes. 2018-11-02 17:29:23 +00:00
Markus Reiter 3dbbcd11cc Remove unused test cask. 2018-11-01 19:46:58 +01:00
L. E. Segovia 70fc2af647 Cask: fix all homepages now that they are audited 2018-10-10 21:36:06 +00:00
commitayandGitHub 5024efa506 Merge pull request #5059 from commitay/remove-checkpoint
remove appcast checkpoint audit
2018-10-09 15:21:24 +10:00
Markus ReiterandGitHub 711bb4977f Merge pull request #5056 from reitermarkus/accessibility_access
Remove the `accessibility_access` stanza.
2018-10-08 18:24:18 +02:00
commitay da7d46aa14 remove appcast checkpoint audit 2018-10-08 10:54:30 +10:00
Markus Reiter c4d418e126 Use ActiveSupport’s #second. 2018-10-07 23:10:56 +02:00
Markus Reiter b7cf925da8 Remove unused methods in Staged module. 2018-10-07 22:00:07 +02:00
Markus Reiter 59e3a532ff Remove the accessibility_access stanza. 2018-10-07 21:53:31 +02:00
Mike McQuaid ac2aabf287 setup_remote_tap: use system taps.
This saves recloning the taps we use multiple times when already done by
the user.
2018-10-03 19:14:04 +01:00
Markus Reiter 2308f0c571 Skip quitting applications when not logged into GUI. 2018-10-02 16:27:45 +02:00
Markus Reiter e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Mike McQuaid 7615d3a812 Improve writable directory handling
Consolidate the handling of which directories need to exist and which
need to be writable. Additionally, add a fatal check for formula
installations to ensure that any directories that need to be writable
are so before attempting an installation.

Fixes #4626.
2018-09-06 18:38:43 +01:00
Markus Reiter a84a1c63db Rename Hbc module to Cask. 2018-09-06 09:30:52 +02:00
Markus Reiter 33ce424399 Remove redundant namespacing. 2018-09-06 06:47:29 +02:00
William WoodruffandGitHub eacdca872e Merge pull request #4819 from woodruffw/error-pipe
utils: Use JSON to marshal child errors
2018-09-04 21:02:29 -04:00
William Woodruff 367629d289 utils: Use JSON to marshal child errors
Replaces our serialization of child process
errors via Marshal with JSON, preventing
unintentional or malicious code execution outside
of the build sandbox.

Additionally, adds tests for the new behavior.
2018-09-04 11:03:32 -04:00
Mike McQuaid e06f8a8beb Rename Homebrew-Cask to Homebrew Cask. 2018-09-04 09:56:57 +01:00
Mike McQuaid 90b3a13909 cask: move cask/lib/hbc/* to cask/*.
Fix the load path, requires and some filenames accordingly.
2018-09-04 09:56:57 +01:00
Mike McQuaidandGitHub 088730c6f1 Revert "Use JSON to marshal errors from children" 2018-09-04 08:37:08 +01:00
Markus Reiter 32ad22395b Remove some #popen_reads. 2018-09-04 05:16:59 +02:00
William WoodruffandGitHub 1eec585afe Merge pull request #4752 from woodruffw/error-pipe
Use JSON to marshal errors from children
2018-09-03 18:59:40 -04:00
William Woodruff 86b9647450 utils: Use JSON to marshal child errors
Replaces our serialization of child process
errors via Marshal with JSON, preventing
unintentional or malicious code execution outside
of the build sandbox.

Additionally, adds tests for the new behavior.
2018-09-03 18:42:59 -04:00
Markus Reiter 89dd608766 Deprecate gpg stanza. 2018-09-03 20:47:52 +02:00
L. E. Segovia f7cafb50ad Enable quarantining of Homebrew-Cask's downloads 2018-08-31 13:16:11 +00:00