vhad/brew
1
0
Fork 0
mirror of https://github.com/gosticks/brew.git synced 2026-08-26 03:20:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
11,597 Commits 4 Branches 271 Tags
3ebd7df62d0b05a8a010bec74793cc4e688a2fc8
Commit Graph
295 Commits
Author SHA1 Message Date
Zhiming Wang 3ebd7df62d bump-formula-pr: fix removal of old mirrors 
Previously, old mirrors are only removed if the requested spec is
stable, and if the mirror lines only have two leading spaces. This leads
to stale mirror line(s) when the formula a stable block like

    stable do
      url "http://example.com/v1.0.tar.gz"
      mirror "http://example.net/v1.0.tar.gz"
    end

where the mirror line is lead by four spaces.

In this commit, we discard the /(^ mirror .*\n)?/ pattern, and instead
create a pattern with the exact url and flexible leading spaces for each
mirror of the requested spec.
 2016-12-22 00:54:08 -05:00
Mike McQuaid 8f85eb64c4 audit: fix 32-bit check. 2016-12-20 14:26:53 +00:00
Mike McQuaidandGitHub ef6b55125c Merge pull request #1695 from MikeMcQuaid/audit-revision-map-nil 
audit: handle a nil revision map.
 2016-12-20 10:55:41 +00:00
Mike McQuaidandGitHub 1d2390b2de Merge pull request #1698 from MikeMcQuaid/deprecate-32-bit 
Deprecate 32-bit options.
 2016-12-20 10:54:54 +00:00
Mike McQuaid f98304026b Deprecate 32-bit options. 
These were formerly supported but as it has been a very long time since
32-bit software was necessary on macOS these have been deprecated with
a `brew audit` warning and a future `odeprecated`.
 2016-12-20 10:22:30 +00:00
Mike McQuaid 41a248786f audit: handle a nil revision map. 2016-12-18 15:46:02 -08:00
Mike McQuaid 339ff9400f audit: don't allow use of OS.mac?/OS.linux?. 
Forbid their use in Homebrew/core which only supports macOS. This may
be added to more/all official taps in future.
 2016-12-18 15:30:06 -08:00
Mike McQuaid 61e370fb7a create: handle Version::NULL correctly. 
Fixes #1688.
 2016-12-18 13:32:29 -08:00
Mike McQuaid cf1fa0c5bc audit: flag use of "fails_with :llvm". 
Also, add TODOs for deprecating this properly at a later point.
 2016-12-13 02:10:11 +00:00
Mike McQuaidandGitHub 60b1be6795 Merge pull request #1629 from zmwangx/bump-formula-pr-download-to-correct-version 
bump-formula-pr: use correct version in download path when --version is specified
 2016-12-07 22:09:54 +00:00
Zhiming Wang 417f27f40f bump-formula-pr: use correct version in download 
When a --version is specified, use this specified version in the name of
the downloaded file rather than the default that is parsed from the URL.
For instance,

  brew bump-formula-pr --devel \
    --url=http://www.zsh.org/pub/development/zsh-5.2-test-2.tar.gz \
    --version=5.2-test-2 zsh

should download to $HOMEBREW_CACHE/zsh-5.2-test-2.tar.gz (correct
behavior after this commit) rather than
$HOMEBREW_CACHE/zsh-2.tar.gz (wrong behavior before this commit).
 2016-12-06 17:30:10 -05:00
Zhiming Wang 59f926cfd3 boneyard-formula-pr: checkout last branch when done 
Make its behavior more consistent with that of bump-formula-pr.
 2016-12-06 15:20:04 -05:00
Zhiming Wang 0fe532c242 boneyard-formula-pr: use ohai to print messages 
Make its behavior more consistent with that of bump-formula-pr.
 2016-12-06 15:19:51 -05:00
Mike McQuaid 0d8fc920d6 tap-new: use latest Travis CI recommended config. 
Pretty sure no-one cares about this except me but this works
consistently across a variety of different taps and is faster than the
old version.
 2016-12-03 13:47:52 +00:00
Mike McQuaid 22b121c4c1 tap-new: cleanup and update Travis configuration. 
- Use macOS Sierra 10.12 and Xcode 8.
- Add indentation.
 2016-11-26 16:30:43 +00:00
Mike McQuaid 1980af52de audit: allow deprecated options on new @ formulae. 
As these may be migrations from another tap where we want to migrate
options across correctly.
 2016-11-23 11:03:10 +00:00
Mike McQuaidandGitHub c3f959d6af Merge pull request #1542 from woodruffw/deprecate-utils-json 
compat: deprecate Utils::JSON in favor of corelib JSON.
 2016-11-21 18:45:20 +00:00
William Woodruff d07b9ed7f2 Replace Utils::JSON with corelib JSON calls. 2016-11-20 20:06:25 -05:00
William Woodruff 4a9601ab82 audit: check formula name against blacklisted names. 2016-11-20 00:40:54 -05:00
Mike McQuaidandGitHub 5e073f1f40 Merge pull request #1528 from MikeMcQuaid/audit-devel-revision 
audit: don't check devel version_scheme/revision.
 2016-11-18 13:53:22 +00:00
Mike McQuaidandGitHub f4810e4eb1 Merge pull request #1530 from MikeMcQuaid/audit-homebrew-prefix-test-path 
audit: check for HOMEBREW_PREFIX test path usage.
 2016-11-18 12:37:46 +00:00
Mike McQuaid e4fb108079 audit: check for HOMEBREW_PREFIX test path usage. 
This is also not allowed.

As seen in https://github.com/Homebrew/homebrew-core/pull/6996.
 2016-11-18 09:02:39 +00:00
Mike McQuaidandGitHub d9ee2d75c5 Merge pull request #1512 from zmwangx/bump-formula-pr-user-supplied-message 
bump-formula-pr: add --message option
 2016-11-18 08:30:22 +00:00
Josh Hagins 0a7307de64 tests: ignore test files in test/vendor/bundle 2016-11-17 19:21:05 -05:00
Zhiming Wang 67999d75f5 bump-formula-pr: add --message option 
For user-supplied PR message.
 2016-11-17 15:29:33 -05:00
Mike McQuaid b7f0edd1fd audit: don't check devel version_scheme/revision. 
These are formulae-wide so doesn't make sense to iterate through these
for specs and get weird results.

As seem in https://github.com/Homebrew/homebrew-core/pull/6952.
 2016-11-17 17:13:52 +00:00
Markus Reiter 7457af2b23 Move test files back directly to test/. 2016-11-16 23:52:38 +01:00
Markus Reiter 4efdbbde06 Rename fs_leak_log to fs_leak.log and move to tmp. 2016-11-16 23:52:37 +01:00
Markus Reiter e3be9c068b Update .rubocop_todo.yml. 2016-11-16 23:52:37 +01:00
Markus Reiter 6b6b27126d Reorder and rename test files. 2016-11-16 23:52:37 +01:00
Mike McQuaidandGitHub edf042ee97 Merge pull request #1522 from MikeMcQuaid/audit-one-previous-commit 
audit: only check previous formula version.
 2016-11-16 10:25:11 +00:00
Mike McQuaid 31caa8ef93 audit: only check previous formula version. 
For calculating the stable/devel versions this should be sufficient as
it's looking at `origin/master` so for a e.g. unmerged pull request this
will stop complaining about mistakes outside the pull request itself.

This will silence all warnings for historic version mistakes (i.e.
before these audit checks were all enabled) which is normally a bad
thing but as this case would rely on modifying history to complete is a
good one.
 2016-11-16 09:03:20 +00:00
Mike McQuaid 27ea94adb8 audit: check that there are any stable revisions. 
Fixes the exception if `revision_map[formula.stable.version]` is `nil`.
 2016-11-16 08:59:52 +00:00
Mike McQuaid 5e0b3d24e5 audit: fix "version should not decrease" (again). 
- output the max version and current version to make the message more
  obvious.
- Don't compare the development spec version to the formula version and
  then complain the formula version is lower (it should always be!)
 2016-11-15 09:02:50 +00:00
Markus Reiter c648518f35 Rename single line block parameters to acc/elem. 2016-11-13 23:36:04 +01:00
Mike McQuaid c78aa43386 audit: fix "version should not decrease" check. 
Fix the "version should not decrease" check so it correctly handles
`version_scheme`s.

Fixes #1489.
 2016-11-13 13:35:25 +00:00
Mike McQuaidandGitHub bc67414b9a Merge pull request #1449 from ilovezfs/bottle-improve-relocatability-check 
bottle: improve relocatability check
 2016-11-06 08:15:13 -05:00
ilovezfs c5bd5c4aa7 bottle: improve relocatability check 
Given how common it is for formulae to hard-code `etc` and `var`, check
for those paths (`/usr/local/etc` and `/usr/local/var`) when determing
relocatability.
 2016-11-06 04:00:14 -08:00
Baptiste Fontaine bfa19b3385 audit: Escape interpolated string in regexp 
This avoids issues with names containing special characters like e.g. [

Fixes #1431
 2016-11-03 18:17:11 +01:00
Mandar Gokhale 0e15ffff62 Correct a few typos 
...and update man pages where applicable
 2016-11-03 12:09:44 +00:00
Mike McQuaidandGitHub 2a865f085e Merge pull request #1424 from MikeMcQuaid/audit-more-test-system 
audit: check more unscoped test calls.
 2016-11-02 21:50:54 -04:00
Steven Peters 72f889fef0 audit: restore check that was lost in #927 
This audit check ensures that certain build dependencies
are explicitly marked either as `:build` or `:run`.
It seems to have been lost in #927.
It was also adjusted in #1290.
 2016-11-02 16:52:09 -07:00
Mike McQuaid f35a86ff70 audit: stricter test system calls check. 
Ensure that the name is suffixed with whitespace or quotes.
 2016-11-02 15:57:19 -04:00
Mike McQuaid 7aa26f7817 audit: check more unscoped test calls. 
Also check `def test`, `shell_output`, `pipe_output` and method calls
using parentheses.
 2016-11-02 13:23:38 -04:00
Mike McQuaidandGitHub b3ef8bd044 Merge pull request #1369 from MikeMcQuaid/boneyard-reason 
boneyard-formula-pr: add reason argument.
 2016-11-02 12:00:33 -04:00
Mike McQuaid 9f382bfd53 boneyard-formula-pr: add reason argument. 
Used to provide a user-facing reason why this formula was boneyarded.
 2016-10-30 15:40:11 -04:00
Baptiste FontaineandMike McQuaid 127461d879 audit: don't check new formulae revision/versions. 2016-10-30 13:51:23 -04:00
Mike McQuaid ef58225749 audit: check the version does not decrease. 
This will prevent brew upgrade from working correctly.
 2016-10-30 13:51:21 -04:00
Mike McQuaidandGitHub 8d5df2ea87 Merge pull request #1402 from MikeMcQuaid/audit-system-test 
audit: check test system calls are fully scoped.
 2016-10-30 13:30:03 -04:00
Mike McQuaidandGitHub 20c8c5958e Merge pull request #1367 from MikeMcQuaid/audit-check-master-branch 
audit: check for master branch tar/zipballs.
 2016-10-30 13:29:47 -04:00