5b3530b23d
Apply suggestions from code review
...
Code review changes
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com >
2020-06-30 22:11:36 +08:00
eca528cccc
util github: remove nil as that is already expected behaviour
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com >
2020-06-19 03:38:36 +08:00
Lionell
610dfe0fc2
audit: fixed with PR comments. Refactored get_repo_license api call and audit_license only new_formula
2020-06-18 00:44:33 +08:00
Sean Molenaar
a99d428f6d
Only search pull requests for artifacts
2020-05-28 15:14:32 +02:00
Mike McQuaid
4f75a77b08
Update deprecations
...
Add more deprecations, disable deprecations and remove disabled code.
2020-05-18 13:50:46 +01:00
Jonathan Chang
286488f753
github: add sponsors GraphQL API
2020-04-17 17:16:54 +10:00
Jonathan Chang
951cf09d4b
pr-pull: eliminate another curl call
...
We're setting the basename, so no need to make a curl call to figure out
what it ought to be. This should speed up bottle pulls even more.
2020-04-14 13:41:35 +10:00
Bo Anderson
a6d3e3c47c
utils/github: form encode workflow branch
2020-04-13 21:22:01 +01:00
Jonathan Chang
c1ba9975b8
pr-pull: fetch artifacts with no-resume strategy
2020-04-13 19:59:22 +10:00
Mike McQuaid
3381cbf5c7
Use Homebrew::EnvConfig.
2020-04-07 09:58:26 +01:00
Dawid Dziurla
e1ce5c852d
github: return output if JSON parsing is not desired
2020-04-01 13:23:54 +02:00
Jonathan Chang
39040fba8b
utils/github: properly use token scopes
2020-03-31 22:11:06 +11:00
Jonathan Chang
5b1d0786a4
utils/github: add fetch_artifact API
2020-03-30 22:18:19 +11:00
Jonathan Chang
7c752e487f
pr-publish: wording fixes
2020-03-24 12:31:58 +11:00
Jonathan Chang
4bb66c12e8
utils/github: add repository_dispatch API
2020-03-22 13:24:07 +11:00
Mike McQuaid
1e265247ca
rubocop: apply autofixes.
2020-03-13 21:16:18 +00:00
Mike McQuaid
8ad50cd4dc
utils/github: refactor and update logic.
...
- better handle `HOMEBREW_GITHUB_API_USERNAME` and
`HOMEBREW_GITHUB_API_PASSWORD` from `brew gist-logs`
- only user personal access tokens from the macOS keychain (fixes #6862 )
- general refactoring and cleanup around the above
2020-01-09 16:13:44 +00:00
Maxim Belkin
2735663dc3
GitHub Actions: get username if we don't have it
2019-11-25 16:43:29 -06:00
Maxim Belkin and Mike McQuaid
c7f065b8da
utils/github.rb: use parallel assignments rather than indices
...
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com >
2019-11-21 11:13:10 -06:00
Maxim Belkin
845f65b945
Factor out some code into functions
2019-11-21 11:13:10 -06:00
Dawid Dziurla
f90612ccf0
bump-formula-pr: make it usable on linux
...
This commit makes it possible to use `bump-formula-pr` on linux to
contribute to `homebrew-core` as easily as it is on macOS, but with some
additional steps made before actual bumping of the formula.
Differences in the process (before bumping):
- add `homebrew-core` remote named `homebrew`
- fetch `homebrew/master`
- check if formula exists in `homebrew-core`
- switch to `homebrew/master` ref
2019-11-15 13:22:31 +01:00
Markus Reiter
f099d44021
Add GitHub::create_check_run function.
2019-10-21 20:12:31 +02:00
Markus Reiter
b1d0c61fea
Update Gems.
2019-10-03 09:22:44 +02:00
Markus Reiter
31f15acc01
Add GitHub::check_runs.
2019-09-13 22:30:25 +02:00
Cheng XU
4f29af08f8
github: redact token in the log
2019-07-18 15:10:15 +08:00
Mike McQuaid
2e817d2644
utils/github: better handle blank scopes.
...
If both provided and required scopes are blank then we cannot display a
good error message so don't try.
Fixes #6134 .
2019-05-15 09:18:05 +01:00
kiendang
5c83729be9
Fix mutable string syntax
2019-04-26 23:03:40 +08:00
Mike McQuaid
261e2e7926
utils/github: fix frozen string usage.
...
See https://discourse.brew.sh/t/error-cant-modify-frozen-string/4691/4
2019-04-25 23:28:50 -07:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files.
2019-04-20 13:27:36 +09:00
EricFromCanada
89f0fcedbe
whitespace fixes
2019-04-13 21:32:04 -04:00
EricFromCanada
fa6404e0f5
grammar fixes
2019-04-13 21:29:32 -04:00
Steven Peters
e91b889e04
utils/github: use tap.full_name
2019-03-03 22:58:31 -08:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier.
2019-02-21 12:55:49 +00:00
Markus Reiter
a4e0413bf9
Let GitHub::open_api return nil when status is 204 No Content.
2019-02-20 02:11:19 +01:00
Markus Reiter
e9c45ff17b
Pass additional options to GitHub.pull_requests.
2019-02-16 11:30:49 +01:00
Markus Reiter
68e0c5f904
Check for write access instead of HOMEBREW_DEVELOPER.
2019-02-15 16:27:37 +01:00
Markus Reiter
57fefff942
Add brew cask automerge command.
2019-02-15 16:27:37 +01:00
Mike McQuaid
ec5ce4b180
utils/github: display max 20 closed PRs.
...
Closes #5553 .
2019-01-19 17:17:21 +00:00
Mike McQuaid and GitHub
b167a88e4d
Merge pull request #5090 from JBallin/gist-token-error
...
Clarify how to set HOMEBREW_GITHUB_API_TOKEN
2018-10-21 15:41:34 +01:00
Mike McQuaid
056dd588b2
utils/github: add ValidationFailedError.
...
These have specific errors returned so would be more useful to output.
2018-10-15 12:03:16 -07:00
JBallin
2bf0db40b3
Normalize formatting of gist-logs errors
2018-10-14 20:40:24 -07:00
JBallin
2a1b936f76
Clarify HOMEBREW_GITHUB_API_TOKEN in gist-logs err
2018-10-14 20:40:24 -07:00
Alyssa Ross
864475e14f
bump-formula-pr: use GitHub error message info
...
This saves an API call, and is more accurate, because the repo API
doesn't actually say whether forking is enabled, but this error message
does.
To do this, the original GitHub error message had to be accessible on
the GitHub exceptions.
2018-10-11 16:39:29 +01:00
Markus Reiter
e9b9ea49a1
Update to RuboCop 0.59.1.
2018-09-17 03:45:59 +02:00
Mike McQuaid
bcb1ec5499
Improve Homebrew/brew line length.
...
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
2018-09-02 16:15:09 +01:00
Gautham Goli
54033d320b
utils/github: Raise exceptions if status code != 200 or exit code is not 0
2018-08-15 20:57:22 +05:30
Markus Reiter
8ae284e871
Use SystemCommand for curl.
2018-08-01 01:04:42 +02:00
ilovezfs and GitHub
cd2b85c40f
Revert "Use SystemCommand for curl."
2018-07-29 21:45:04 -07:00
Markus Reiter
355df64d93
Use SystemCommand for curl.
2018-07-29 01:23:33 +02:00
commitay
7542c4edb7
utils/github: remove full stop from the "skipping" comment
2018-07-25 15:38:14 +10:00
