Commit Graph
12351 Commits
Author SHA1 Message Date
Gautham Goli 7614d2cc8b audit: Port FileUtils, inreplace audit rules in audit_lines to rubocop 2017-08-06 02:28:58 +05:30
Gautham Goli affd9055c2 audit: Port classname and template comments audit rules from line_problems method to rubocop 2017-08-06 02:28:58 +05:30
Markus ReiterandGitHub 7a17a166ec Merge pull request #3006 from reitermarkus/unfocus
Delete `:focus`.
2017-08-05 21:05:08 +02:00
Mike McQuaid eaea27c960 formula_installer: restore build_bottle defaults. 2017-08-05 17:51:47 +01:00
Gautham Goli 66ffdb5b06 Refactor legacy_patches_cop to merge external patch audit rules in a single cop and add tests 2017-08-05 21:51:24 +05:30
Gautham Goli 43cec10000 audit: Port patches audit code to a rubocop 2017-08-05 21:51:24 +05:30
Markus Reiter f5af3fe0cd Delete :focus. 2017-08-05 18:09:09 +02:00
Markus ReiterandGitHub c26c9204fa Merge pull request #2965 from reitermarkus/cask-tap
Detect `Tap` in `CaskLoader`.
2017-08-05 16:54:26 +02:00
Mike McQuaidandGitHub ae0b7cb824 Merge pull request #2991 from javian/additionalphpignores
audit: add additional php header ignore patterns
2017-08-05 15:16:05 +01:00
Markus ReiterandGitHub 42cfb6d238 Merge pull request #2999 from mistydemeo/tap_each_enum
Tap.each: return an enumerable when no block given
2017-08-04 16:14:06 +02:00
Markus Reiter 12d4226bfc Remove _checkurl. 2017-08-04 15:39:32 +02:00
Misty De Meo 1c3ece12b9 Tap.each: return an enumerable when no block given 2017-08-03 17:23:16 -07:00
ilovezfs ee6b0e7c9b formula_cellar_checks: check_non_libraries only for new formulae
This check is overly opinionated and leads to audit failures no one
cares to fix, so let's only run it for new formulae.
2017-08-03 05:21:36 -07:00
Jan Viljanen 85da376233 audit: add additional php header ignore patterns 2017-08-03 06:13:15 +02:00
JCount 68878d73ef formula_desc_cop: add 'x86' to VALID_LOWERCASE_WORDS 2017-08-01 11:36:44 -04:00
Mike McQuaidandGitHub f4983ab16b Merge pull request #2975 from GauthamGoli/audit_urls_rubocop_strict
audit: Port audit_urls strict rules to rubocop, add tests, autocorrect
2017-08-01 11:39:01 +01:00
Mike McQuaidandGitHub 43d68b6dda Merge pull request #2980 from GauthamGoli/audit_style_check_bug_fix
audit: fix bug where `brew audit foo` runs every style check.
2017-08-01 11:36:18 +01:00
Mike McQuaidandGitHub c3c3575b70 Merge pull request #2964 from GauthamGoli/audit_line_rubocop_part_1
audit: Port dependency rules from line_problems to rubocop and add tests
2017-08-01 11:29:26 +01:00
Bob W. Hogg 732e0aa689 formula: Remove reference to Homebrew/Homebrew
That repo is now defunct. Reference homebrew-core instead.

Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-07-31 19:24:33 -07:00
Markus ReiterandGitHub 05e9086355 Merge pull request #2978 from reitermarkus/simplify-dsl
Simplify `assert_only_one_stanza_allowed`.
2017-07-31 16:44:12 +02:00
Mike McQuaid af463a0535 formula_installer: never build dependency bottles.
This also helpfully avoids always building all dependencies from source
when passing `--build-bottle` or forcing all bottles when passing
`--force-bottle`.
2017-07-31 10:36:10 +01:00
Mike McQuaid 044f4d947b Tweak preserve link status on reinstall/upgrade.
Treat a `brew install` command as normal i.e. link by default unless
keg-only and only specify whether a keg should be linked when upgrading
or reinstalling. Also, adjust the naming accordingly so it's more
obvious that this is the case.
2017-07-30 21:44:43 +01:00
Mike McQuaid 9d55446cd0 formula_installer: fix typo. 2017-07-30 20:04:41 +01:00
Mike McQuaidandGitHub e1fd69de42 Merge pull request #2961 from MikeMcQuaid/preserve-link-on-upgrade-reinstall
Preserve link status on reinstall/upgrade.
2017-07-30 18:42:06 +01:00
Mike McQuaidandGitHub e755505c70 Merge pull request #2969 from MikeMcQuaid/default-formula-bottles
formula_installer: use default_formula for bottles
2017-07-30 18:41:10 +01:00
Markus Reiter 0d1162d821 Make zap recognize --force. 2017-07-30 18:51:05 +02:00
Markus Reiter 8779784d70 Fix trash script. 2017-07-30 18:44:53 +02:00
Gautham Goli 5e8e705b50 audit: fix bug where brew audit foo runs every style check. 2017-07-30 22:03:43 +05:30
Markus Reiter 8d7ab78a75 Simplify assert_only_one_stanza_allowed. 2017-07-30 18:06:59 +02:00
Mike McQuaid a83baba8b5 formula_installer: use default_formula for bottles
This was the original, intended functionality before this was broken
in fe117bf79b.

Fixes https://github.com/Homebrew/homebrew-core/issues/13680.
2017-07-30 16:56:24 +01:00
Mike McQuaidandGitHub 896f41f7ed Merge pull request #2899 from MikeMcQuaid/enable-deprecations
Enable more deprecations.
2017-07-30 16:32:34 +01:00
Mike McQuaid 7ec0505200 Preserve link status on reinstall/upgrade.
This means if a user has manually `brew unlink` or `brew link --force`d
something then that status will be preserved after they `brew upgrade`
or `brew reinstall` that formula.

This generally should make things that are keg-only by default easier
to swallow.
2017-07-30 16:20:32 +01:00
Mike McQuaidandGitHub 05956781a2 Merge pull request #2973 from DomT4/keg_only_additions
formula_support: add provided_pre_high_sierra keg_only
2017-07-30 16:16:51 +01:00
Mike McQuaidandGitHub b3a96af069 Merge pull request #2959 from MikeMcQuaid/formula-installer-duplication
formula_installer: simplify callers.
2017-07-30 16:03:01 +01:00
Mike McQuaidandGitHub e8c4989efb Merge pull request #2923 from MikeMcQuaid/alias-fixes
keg: correctly cleanup old aliases.
2017-07-30 16:02:49 +01:00
Mike McQuaidandGitHub 3821132f9e Merge pull request #2898 from MikeMcQuaid/sandbox-all-taps
sandbox: sandbox all taps by default.
2017-07-30 16:02:36 +01:00
Markus Reiter 6d6ce7cf0a Detect Tap in CaskLoader. 2017-07-30 14:22:05 +02:00
Gautham Goli c575f34d5f audit: Port audit_urls strict rules to rubocop, add tests and autocorrect 2017-07-30 12:59:37 +05:30
Dominyk Tiller 0a10ca61dc formula_support: add provided_pre_high_sierra keg_only 2017-07-30 00:21:33 +01:00
Markus ReiterandGitHub 627b1dae70 Merge pull request #2972 from reitermarkus/plist_path
Use `mktmpdir`.
2017-07-30 00:34:59 +02:00
Vítor GalvãoandGitHub f450178763 Fix style error 2017-07-29 21:54:18 +01:00
Markus Reiter 5fea557da3 Use mktmpdir. 2017-07-29 22:21:41 +02:00
Markus Reiter b4381ddcaa Cleanup after each Cask. 2017-07-29 21:48:29 +02:00
Markus Reiter 2ad3a87045 Silence all specs by default. 2017-07-29 20:25:37 +02:00
Mike McQuaid 4440afa99a installer_spec: silence test output. 2017-07-29 16:59:32 +01:00
Gautham Goli e1cb0b43d7 audit: Port dependency rules from line_problems to rubocop and add tests 2017-07-29 16:36:32 +05:30
Mike McQuaid b8611bd988 formula_installer: simplify callers.
There's a bunch of duplication going on that's not really necessary.
2017-07-28 15:27:47 +01:00
Mike McQuaid 1651647a3d keg: correctly cleanup old aliases.
Cleanup old, versioned aliases and tap aliases folders when unlinking
or uninstalling a keg.
2017-07-28 11:41:12 +01:00
Gautham Goli 0c04b9041a audit: Check for style violations when --new-formula is passed 2017-07-28 05:05:34 +05:30
Markus ReiterandGitHub a49d99a2d6 Merge pull request #2949 from reitermarkus/caskroom-messages
Don’t output Caskroom creation messages on non-TTY.
2017-07-27 19:33:01 +02:00