vhad/brew
1
0
Fork 0
mirror of https://github.com/gosticks/brew.git synced 2026-08-19 16:10:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
14,417 Commits 4 Branches 271 Tags
7a68b4a3f96c0cc76f94de2cd72b463b40be0343
Commit Graph
11992 Commits
Author SHA1 Message Date
Mike McQuaid 7a68b4a3f9 Refactor command handling code 
Don’t rely on having external commands always present in the PATH in
order to find them. Instead, provide an accessory method to Tap so
they can be added and used when needed.

While we’re here, do some general refactoring and cleanup of the
command code in these places.
 2017-11-05 15:37:57 +00:00
Mike McQuaid b9d9e63743 spec_helper: fix etc leak. 
Fix the `etc/bash_completion.d/_brew_services` leak from the new
bash completion in the Homebrew/homebrew-services tap.
 2017-11-05 13:20:08 +00:00
Mike McQuaidandGitHub 2af98133ba Merge pull request #3407 from DomT4/x11 
xquartz: add new versions + mark latest
 2017-11-03 18:28:46 +00:00
Mike McQuaidandGitHub 872bd4f703 Merge pull request #3395 from GauthamGoli/parameters-audit-regex-fix 
lines_cop: Update regex patterns to prevent false positives
 2017-11-03 17:48:09 +00:00
Mike McQuaidandGitHub c6f40d5864 Merge pull request #3385 from MikeMcQuaid/path-fixes-cleanup 
Fix and cleanup some PATH usage.
 2017-11-03 17:45:57 +00:00
Mike McQuaid 29f81812cc brew.rb: cleanup PATH setup. 
Avoid adding all the tap commands to the PATH when not necessary.
 2017-11-03 14:50:17 +00:00
Mike McQuaid f0b25b5482 requirement: convert Cellar path to opt path. 2017-11-03 14:50:17 +00:00
Mike McQuaid 5de7ec394b requirement: don't add /usr/local/{bin,sbin}. 
This should be considered a requirement bug if it's added.
 2017-11-03 14:50:17 +00:00
Mike McQuaid c843fd2f12 requirement: prepend rather than append PATH. 
Otherwise this ends up behind e.g. `/usr/bin` so is pretty useless.
 2017-11-03 14:50:17 +00:00
Markus ReiterandGitHub 4eeac6f884 Merge pull request #3389 from amyspark/hacktoberfest-single-zap 
Check that a single uninstall_* and zap stanza is defined
 2017-11-03 13:23:08 +01:00
ilovezfs 3769bcc523 formula: fix safe navigation bug 
Safe navigation needs to be chained to preserve equivalence.

Fixes a bug introduced by 01e9ec9a in #3183.
 2017-11-02 07:26:00 -07:00
L. E. Segovia eaae7f3a5b Fix last remaining style issues 2017-11-02 09:56:51 -03:00
L. E. Segovia 7f398d01b8 Turn ifs into multiple lines 2017-11-01 22:35:41 -03:00
Dominyk Tiller bdc7657456 xquartz: mark 2.7.11 as latest release 2017-10-31 16:21:03 +00:00
Dominyk Tiller eb950644c5 xquartz: add 2.7.10 & 2.7.11 releases 2017-10-31 16:20:47 +00:00
L. E. Segovia c636be07f9 Separate do end into multiple lines 2017-10-31 09:54:30 -03:00
L. E. Segovia 917c138eeb Add tests for uninstall_* and zap stanzas 2017-10-30 20:47:40 -03:00
L. E. Segovia 9b6b0bfed7 Use #count, rewrite warning, and add pre/postflight checks too 2017-10-30 20:47:22 -03:00
Markus Reiter 2eb366ff38 Fix SystemCommand without arguments. 2017-10-30 22:04:54 +01:00
Mike McQuaidandGitHub 2d5bb029a5 Merge pull request #3387 from MikeMcQuaid/env-std-homebrew-paths 
ENV/std: fully extend from HOMEBREW_PATH.
 2017-10-30 16:09:01 +00:00
Mike McQuaid 6ddf3f8796 bump-formula-pr: add --no-browse option. 
If `--no-browse` is passed, don't pass the `--browse` argument to `hub`
which opens the pull request URL in a browser. Instead, output it to the
command line.
 2017-10-30 09:14:53 +00:00
Mike McQuaidandGitHub 7a0fdc3d03 Merge pull request #3393 from MikeMcQuaid/with_env_tweaks 
Tweak use of with_env
 2017-10-30 08:17:06 +00:00
Mike McQuaidandGitHub 4c44266aa5 Merge pull request #3394 from MikeMcQuaid/sh-no-ps1 
cmd/sh: set working PS1 for zsh
 2017-10-29 19:17:26 +00:00
Gautham Goli f648dd03ff lines_cop: Update regex patterns to prevent false positives 2017-10-29 23:40:04 +05:30
Mike McQuaid 3549377478 cmd/sh: set working PS1 for zsh. 
The `bash`, default one is broken on `zsh`.
 2017-10-29 17:23:05 +00:00
Mike McQuaidandGitHub c59c0d6820 Merge pull request #3376 from tomjonandy/fix/keychain-credentials 
Fix issue where keychain github credentials wouldn't work
 2017-10-29 16:57:21 +00:00
Mike McQuaidandGitHub 215f49684b Merge pull request #2795 from issyl0/desc_no_full_stops 
formula_desc_cop: ensure no full stops at the end of desc
 2017-10-29 16:56:00 +00:00
Isabell Long 640b1e9dcb formula_desc_cop: ensure no full stops at the end of desc 
- This was a suggestion by Mike McQuaid in my `homebrew-core` audit
  description PR. Based on ilovezfs's incantation `grep -r -E 'desc
  ".*\."' *.rb`, some formulae descriptions do end in full stops. (My
  initial assessment of this failed to account for the fact that
  descriptions are strings and so end in `"`.)
- Add an autocorrect for this cop, too.
 2017-10-29 15:19:31 +00:00
Mike McQuaid ca189437e4 Tweak use of with_env 
- Use it in more places where it saves code
- Allow using symbolic keys for a cleaner interface
- Use `HOMEBREW_GEM_*` instead of `GEM_OLD_*`
 2017-10-29 14:44:43 +00:00
Mike McQuaid f72aba548d ENV/std: fully extend from HOMEBREW_PATH. 
Rather than just re-adding HOMEBREW_PREFIX/bin if it's missing re-add
everything from HOMEBREW_PATH. This works well with or without
environment filtering being enabled but with environment filtering it
ensures that ENV/std just builds on the original user environment.
 2017-10-29 13:41:51 +00:00
Mike McQuaidandGitHub 9dbff4ebbe Merge pull request #3388 from MikeMcQuaid/bump-formula-pr-env-filtering 
bump-formula-pr: always use HOMEBREW_PATH.
 2017-10-29 13:33:16 +00:00
L. E. Segovia 809e820388 Check that a single uninstall_* and zap stanzas is defined 2017-10-28 20:36:41 -03:00
Mike McQuaid e88fd4a868 bump-formula-pr: always use HOMEBREW_PATH. 
Fixes this when using environment filtering.
 2017-10-28 21:46:30 +01:00
Mike McQuaid 3448335a14 system_config: get perl/ruby from HOMEBREW_PATH. 
This is the actual user path when env filtering is enabled.
 2017-10-28 20:38:00 +01:00
Mike McQuaidandGitHub 7caca57073 Merge pull request #3380 from jmsundar/apfs_tap-info 
tap-info: handle APFS returning hash order
 2017-10-28 13:08:12 +01:00
Jayendra Minakshisundar ea7d356e08 style changes 2017-10-28 14:56:51 +05:30
Mike McQuaidandGitHub b2e2e4b917 Merge pull request #3381 from iMichka/flock 
lock.sh: suppress error output when looking for flock
 2017-10-27 16:19:05 +01:00
Mike McQuaid d985838428 lines_cop: add missing e.g. clang++ regex SOL. 
You need a start of line check in this regex (like was added in the
others) to allow things like `#{bin}/clang++`.
 2017-10-27 14:58:07 +01:00
Michka Popoff b93ed4124c lock.sh: suppress error output when looking for flock 
Fixes (on centos6):
which: no flock in (/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)
 2017-10-27 15:54:24 +02:00
Mike McQuaid 47bfad64b0 rubocop.yml: re-add Homebrew metrics maximums. 2017-10-27 14:20:37 +01:00
Mike McQuaid 8aa697363b test.flac: add flac fixture. 2017-10-27 09:33:37 +01:00
Mike McQuaidandGitHub 25d8771518 Merge pull request #3368 from MikeMcQuaid/unhide-readall-update-reset 
Unhide readall and update-reset from manpage.
 2017-10-27 08:45:47 +01:00
Jayendra Minakshisundar 590f06187f tap-info: sort taps by name to handle APFS 2017-10-27 11:41:00 +05:30
Thomas Andrew 0e991095f1 Fix issue where keychain github credentials wouldn't work 2017-10-26 18:54:48 +01:00
JCountandGitHub badbb00b08 Merge pull request #3352 from JCount/legacy-java-cask-requirement-support 
java_requirement: support prompting users to install legacy Java casks
 2017-10-26 11:26:00 -04:00
Mike McQuaid 6114f48d5d Unhide readall and update-reset from manpage. 
These are both tools that end-users can find useful on occasion so it
doesn't make sense to hide them.
 2017-10-26 16:14:14 +01:00
Mike McQuaidandGitHub 40b212322c Merge pull request #3366 from GauthamGoli/lines-cop-false-positives-fix 
lines_cop: Fix detection of negated expression
 2017-10-26 15:28:40 +01:00
JCount 224864b149 java_requirement: support prompting users to install legacy Java casks 
This enhances the Java requirement to support prompting the user
to install the correct legacy Java version via Cask for formulae
that don't yet work with the latest version of Java. Previously,
even if the formula had a strict requirement that a specific,
older version of Java be used, the messaging would tell the user to
`brew cask install java` (i.e. to install the latest version of Java),
which wouldn't actually satisfy the requirement.
 2017-10-26 09:57:03 -04:00
Gautham Goli 09326909af lines_cop: Fix detection of negated expression 2017-10-26 15:35:14 +05:30
commitay 783983b652 rubocop-cask: 0.15.1 2017-10-26 10:21:46 +10:00