Commit Graph
3213 Commits
Author SHA1 Message Date
Mike McQuaid 7a68b4a3f9 Refactor command handling code
Don’t rely on having external commands always present in the PATH in
order to find them. Instead, provide an accessory method to Tap so
they can be added and used when needed.

While we’re here, do some general refactoring and cleanup of the
command code in these places.
2017-11-05 15:37:57 +00:00
Mike McQuaid 3549377478 cmd/sh: set working PS1 for zsh.
The `bash`, default one is broken on `zsh`.
2017-10-29 17:23:05 +00:00
Mike McQuaidandGitHub 7caca57073 Merge pull request #3380 from jmsundar/apfs_tap-info
tap-info: handle APFS returning hash order
2017-10-28 13:08:12 +01:00
Jayendra Minakshisundar ea7d356e08 style changes 2017-10-28 14:56:51 +05:30
Jayendra Minakshisundar 590f06187f tap-info: sort taps by name to handle APFS 2017-10-27 11:41:00 +05:30
Mike McQuaid 6114f48d5d Unhide readall and update-reset from manpage.
These are both tools that end-users can find useful on occasion so it
doesn't make sense to hide them.
2017-10-26 16:14:14 +01:00
Maxim Belkin 313410035d leaves: account for requirements 2017-10-20 14:21:21 -05:00
Mike McQuaidandGitHub ed28ed78d1 Merge pull request #3304 from richiethomas/refactor_uses
In 'readall.rb', replaced multi-step 'each' loop with one-line method chain of Ruby enumerator methods
2017-10-20 18:10:31 +01:00
richiethomas 43cbf08018 Remove memoization from uses.rb, as it doesn't result in the expected time complexity savings 2017-10-20 09:42:30 -04:00
Mike McQuaidandGitHub 76cd7c7949 Merge pull request #3319 from reitermarkus/squiggly-heredocs
Use “squiggly” heredocs.
2017-10-20 14:10:50 +01:00
Mike McQuaidandGitHub a2374cba6c Merge pull request #3334 from DomT4/ds_store_is_not_a_command
commands: filter out dotfiles from output
2017-10-20 11:01:27 +01:00
Mike McQuaidandGitHub 59238cd343 commands: tweak find_internal_commands.
Use a more typical Ruby style.
2017-10-20 10:19:11 +01:00
Mike McQuaidandGitHub 460048bcb6 Merge pull request #3302 from maxim-belkin/readall-multiple-taps
readall: allow readall-ing multiple taps at once
2017-10-20 10:16:32 +01:00
richiethomas b135a70c57 Fix brew style warnings 2017-10-18 20:21:49 -04:00
richiethomas e5e84eec7d PR feedback- replace '#{HOMEBREW_LIBRARY}/Homebrew/**/*.rb' with '#{HOMEBREW_LIBRARY_PATH}/**/*.rb' 2017-10-18 18:20:44 -04:00
richiethomas 99bccaae13 Remove /cask/ from readall file filter 2017-10-18 17:44:09 -04:00
Maxim Belkin ad3886b462 readall: update documentation 2017-10-18 14:50:44 -05:00
Markus Reiter 9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Dominyk Tiller 2063e0fc52 commands: filter out dotfiles from output 2017-10-18 11:44:12 +01:00
Mike McQuaidandGitHub 270b752f5d Merge pull request #3326 from sjackman/portable-ruby
portable-ruby: use rebuild with coverage support for Linux.
2017-10-18 11:04:56 +01:00
Mike McQuaidandGitHub 1d541804c8 Merge pull request #3316 from DomT4/handle_apfs_love_of_hash_order
Handle APFS returning hash order.
2017-10-18 10:55:22 +01:00
richiethomas dfaaada8b6 Memoize recursive dependency checks; reduces calls to 'f.recursive_dependencies' by an order of magnitude 2017-10-17 20:52:18 -04:00
Mike McQuaid d601edaf57 vendor-install: use full shasum PATH.
Otherwise things can explode if there's a random `shasum`.

See #3281.
2017-10-17 20:51:32 +01:00
Shaun Jackman 90ca552ba6 portable-ruby: use rebuild with coverage support for Linux.
This will allow `simplecov` to generate coverage by rebuilding portable
Ruby with coverage support.
2017-10-16 12:26:55 -07:00
Dominyk Tiller 9a323c5107 info: pass explicit sort to handle APFS 2017-10-14 06:44:37 +01:00
Dominyk Tiller c9684c3727 deps: pass explicit sort to handle APFS 2017-10-14 06:42:53 +01:00
Dominyk Tiller f1b183b287 list: pass explicit sort to handle APFS 2017-10-14 06:35:33 +01:00
Dominyk Tiller d9074b80b7 options: pass explicit sort to handle APFS 2017-10-14 06:35:33 +01:00
Dominyk Tiller 795c7170e3 leaves: pass explicit sort to handle APFS 2017-10-14 06:18:49 +01:00
Dominyk Tiller 7b8ba77ed2 missing: pass explicit sort to handle APFS 2017-10-14 06:18:09 +01:00
Dominyk Tiller 35fae7ce6a tap-info: pass explicit sort to handle APFS 2017-10-14 06:14:27 +01:00
Dominyk Tiller e308df25a9 commands: pass explicit sort to handle APFS 2017-10-14 04:24:10 +01:00
Dominyk Tiller ca69d65456 update-report: pass explicit sort to handle APFS 2017-10-14 04:22:22 +01:00
Dominyk Tiller 60eb7c6216 uses: pass explicit sort to handle APFS 2017-10-14 04:17:48 +01:00
Dominyk Tiller f6bc7dc4c6 search: pass explicit sort to handle APFS 2017-10-14 04:17:03 +01:00
Richie Thomasandrichiethomas 9ef82ae1e2 In 'readall.rb', replaced multi-step 'each' loop with one-line method chain of Ruby enumerator methods 2017-10-12 17:38:02 -04:00
Maxim Belkin 4c0e623bd4 readall: allow readall-ing multiple taps at once 2017-10-10 17:54:42 -05:00
Markus Reiter 71b6e239d7 Set RuboCop maximum to current maximum. 2017-10-10 17:00:04 +02:00
Markus Reiter 175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Mike McQuaid bcca2a7c6b brew: handle Ruby 2.3 more gracefully.
- `brew.rb` needed updated to fail unless on Ruby 2.3
- `brew update` should unset `HOMEBREW_RUBY_PATH` to ensure that this
  doesn't "stick" on a Ruby 2.0 version after a portable Ruby has been
  installed.
2017-09-29 19:53:50 +01:00
Maxim Belkin b8d8049f70 install.rb: stop early if there are no formulae to be installed 2017-09-28 14:17:42 -05:00
Mike McQuaidandGitHub a589303616 Merge pull request #3183 from MikeMcQuaid/rubocop-upgrade
Rubocop: 0.50.0 and Ruby 2.3
2017-09-25 21:29:03 +01:00
Mike McQuaid 222da9de1c portable-ruby: use rebuild with coverage support.
This will allow `simplecov` to generate coverage by rebuilding portable
Ruby with coverage support.
2017-09-25 19:15:58 +01:00
Mike McQuaid 9697c8638c vendor-install: output only to stderr.
This avoids causing errors in scripts that call e.g. `brew --prefix`.
2017-09-25 06:53:23 +01:00
Mike McQuaid cf5fdeef1d Rubocop: manual rule fixes. 2017-09-24 21:23:59 +01:00
Mike McQuaid 01e9ec9a9f Rubocop: automatic rule fixes. 2017-09-24 21:23:59 +01:00
Mike McQuaidandGitHub 3343467475 Merge pull request #3189 from MikeMcQuaid/portable-ruby-messaging
portable-ruby: improve installation messaging.
2017-09-23 10:58:26 +01:00
Mike McQuaid aa665b9458 portable-ruby: improve installation messaging.
- Use “Pouring” to be more consistent with our normal messaging.
- Don’t be silent by default.
2017-09-22 15:54:29 +01:00
Shaun Jackman 353810d934 Upgrade vendored Ruby to 2.3.3 for Linux. 2017-09-21 17:02:42 -07:00
Mike McQuaidandGitHub 7d720e8fac Merge pull request #3164 from MikeMcQuaid/portable-ruby-2.3.3
Upgrade vendored Ruby to 2.3.3.
2017-09-21 15:32:41 +01:00