Gautham Goli
7b2fab8ec5
Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1
2017-10-21 13:53:44 +05:30
Markus Reiter
9bee9ca575
Use “squiggly” heredocs.
2017-10-18 14:39:09 +02:00
Gautham Goli
7fa51f71f1
Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1
2017-10-13 19:50:46 +05:30
Dominyk Tiller
0865ab0d1b
audit: nudge to use predicate for 'executable?' as well
2017-10-10 15:45:41 +01:00
Dominyk Tiller
a0f4861934
audit: broaden refute_predicate nudge
2017-10-09 16:46:01 +01:00
Mike McQuaid and GitHub
56458f03fc
Merge pull request #3277 from sjackman/audit-notable
...
audit: Silence not notable on non-Homebrew taps
2017-10-08 13:41:15 -07:00
Shaun Jackman
53dd0e3f28
audit: Silence not notable on non-Homebrew taps
...
Silence "GitHub repository not notable" on non-Homebrew taps.
2017-10-08 10:35:53 -07:00
Markus Reiter
175ca909ee
Clean up code style and remove .rubocop_todo.yml.
2017-10-08 16:10:37 +02:00
Dominyk Tiller
2a25825a12
audit: tweak assert/refute_predicate audit
...
Addresses some of the issues I raised in https://github.com/Homebrew/homebrew-core/pull/19127#issue-263566817 .
Would still like to work out a way to check `File.exist?`-style language
inside the `test do` block exclusively but for now it's better to be
too conservative on the audit than to be overly-zealous and flag too
much.
2017-10-08 06:54:49 +01:00
Dominyk Tiller
4e957165d1
audit: prefer assert/refute_predicate over File.exist?
2017-10-05 02:52:21 +01:00
Mike McQuaid
134bd00d10
audit: don't care about shadowing official taps.
...
We're trying to import all of these formulae anyway.
2017-09-29 16:23:02 +01:00
Mike McQuaid
cf5fdeef1d
Rubocop: manual rule fixes.
2017-09-24 21:23:59 +01:00
Mike McQuaid
01e9ec9a9f
Rubocop: automatic rule fixes.
2017-09-24 21:23:59 +01:00
ilovezfs
28c7838450
audit: also skip homebrew/science duplicates found by search_taps
...
Follow-up to #3202 .
2017-09-24 00:29:34 -07:00
ilovezfs
e984623214
audit: don't check for homebrew/science duplicates
...
It's just noise to turn the migration PRs red over expected duplicates.
2017-09-23 23:00:29 -07:00
Mike McQuaid
56ab1ef5a8
audit: hack around El Capitan audit failure.
2017-09-23 21:10:25 +01:00
Mike McQuaid
ffdda0eb9f
Tweaks for older Mac OS X versions.
...
- `brew update` should try to install `curl` before `git` on older
versions of Mac OS X where it is needed for accessing modern SSL
certificates.
- We don't need an HTTP mirror for `git` because `curl` will already be
installed before it is downloaded.
- Don't recommend GCC on Mac OS X versions where it can't be built with
the default system compiler.
- Start using the Homebrew `curl` on Mac OS X versions where it is
needed as soon as it is installed.
2017-09-16 12:41:08 +01:00
Mike McQuaid
2e43d95498
audit: fix check_http_content args.
2017-09-15 10:17:40 +01:00
Mike McQuaid
03ace9b110
Require more HTTP mirrors for old OS X versions.
...
This allows the bootstrap of `curl` and `git` on versions of Mac OS X
that cannot reliably download from HTTPS servers any longer. Once these
are both installed users are able to update Homebrew and download files
securely.
Also, as we're doing this, don't point 10.5 users to Tigerbrew as they
are already given caveats for using Homebrew itself.
2017-09-14 19:58:37 +01:00
Mike McQuaid and GitHub
ef60688704
Merge pull request #3126 from DomT4/curl_audit
...
audit: stop demanding a HTTP HEAD mirror for curl
2017-09-12 15:48:11 +01:00
Mike McQuaid and GitHub
bf0ab938e7
Merge pull request #3091 from GauthamGoli/audit_line_rubocop_part_3
...
audit: Port line_problems to rubocop and add tests part 3
2017-09-05 18:10:02 +01:00
Dominyk Tiller
9562cceef1
audit: stop demanding a HTTP HEAD mirror for curl
...
Not sure if this is how you want to handle it but having a HEAD mirror
for `curl` is just silliness.
Ref: https://github.com/Homebrew/homebrew-core/commit/e36b95849ae38ade30605155d75cf6e731b4e38f
2017-09-05 03:35:44 +01:00
Gautham Goli
d45ff9c0fd
audit: Add a global flag to silent warning when auditing
2017-09-04 23:57:09 +05:30
Gautham Goli
4ec26aea40
audit: Port audit_class to rubocop, add tests and autocorrect
2017-09-04 23:43:42 +05:30
Gautham Goli
267def28fa
audit: Port rules from line_problems to rubocop part 3
2017-09-04 15:05:43 +05:30
Mike McQuaid and GitHub
73cd2a1db8
Merge pull request #3119 from MikeMcQuaid/audit-subversion-url-fix
...
audit: fix subversion remote check logic.
2017-09-04 01:54:28 +01:00
Mike McQuaid and GitHub
37293c6f01
Merge pull request #3096 from vszakats/urlchk1
...
audit: Add some heuristics to https upgrade checks
2017-09-03 21:50:53 +01:00
Mike McQuaid
bbf71921eb
audit: fix subversion remote check logic.
...
Stop flagging invalid URLs as valid and vice-versa.
Fixes #3118 .
2017-09-03 21:42:46 +01:00
Viktor Szakats
42e2c71dbc
cleanup range check
2017-09-01 16:47:31 +00:00
Dominyk Tiller
f301e5c4f4
audit: add a nudge to remove ENV.java_cache
2017-08-31 21:33:09 +01:00
Viktor Szakats
18f5b43d90
fix length ratio range
2017-08-29 17:02:27 +00:00
Viktor Szakats
56ccf10efa
limit some heuristics to strict mode
2017-08-29 12:53:45 +00:00
Viktor Szakats
c30b941358
review follow-up #1
2017-08-29 12:31:07 +00:00
mansimarkaur
3d8873ca5b
url skipped if svn not available when auditing urls
2017-08-29 16:16:17 +05:30
mansimarkaur
53be6bb4bd
Added check for svn availability
2017-08-29 16:16:17 +05:30
Viktor Szakats
1c2c390c6f
try addressing style issues #2
2017-08-27 18:00:59 +00:00
Viktor Szakats
11b267a7cf
try addressing style issues
2017-08-27 17:52:26 +00:00
Viktor Szakats
923c84d4f7
add some heuristics to https upgrade check
2017-08-27 09:39:28 +00:00
Mike McQuaid and GitHub
8b7defb3eb
Merge pull request #3086 from MikeMcQuaid/audit-taps-shush
...
audit: don't output when searching taps.
2017-08-24 11:17:31 +01:00
JCount and GitHub
6023e408da
Merge pull request #2995 from GauthamGoli/audit_line_rubocop_part_2
...
audit: Port line_problems to rubocop and add tests part 2
2017-08-23 16:16:07 -04:00
Mike McQuaid
f0605f4a30
audit: don't output when searching taps.
...
This messaging was added for the `brew search` command and having it in
audit is annoying:
(https://github.com/Homebrew/brew/pull/3059#issuecomment-323638672 )
As a side note: this is why randomly including `cmd/*` is a bad idea.
2017-08-23 18:40:30 +01:00
Gautham Goli
087c1ca8d6
audit: Port rules from line_problems to rubocop part 4(WIP-3)
2017-08-12 20:50:43 +05:30
Gautham Goli
4295a4ca78
audit: Port rules from line_problems to rubocop part 4(WIP-2)
2017-08-10 19:57:53 +05:30
JCount
e1ebaab0cb
audit: fix mismatch in versioned alias names in non-core taps
...
Fixes #3022
2017-08-08 16:56:19 -04:00
Markus Reiter
ae4bafdb36
Simplify CurlDownloadStrategy.
2017-08-08 18:10:13 +02:00
ilovezfs and GitHub
986887b413
Revert "Refactor SVN and cURL download strategies."
2017-08-07 14:31:56 -07:00
Markus Reiter
dc5a2c1764
Simplify CurlDownloadStrategy.
2017-08-07 21:31:17 +02:00
Gautham Goli
a92e1eda27
audit: Port rules from line_problems to rubocop part 4(WIP)
2017-08-07 14:08:22 +05:30
Gautham Goli
b8f811cca6
audit: Port rules from line_problems to rubocop part 3
2017-08-06 18:36:09 +05:30
Gautham Goli
b5da76e28d
audit: Port FileUtils, inreplace audit rules in audit_lines to rubocop
2017-08-06 18:36:09 +05:30
Gautham Goli