Mike McQuaid
b9d9e63743
spec_helper: fix etc leak.
...
Fix the `etc/bash_completion.d/_brew_services` leak from the new
bash completion in the Homebrew/homebrew-services tap.
2017-11-05 13:20:08 +00:00
Mike McQuaid and GitHub
872bd4f703
Merge pull request #3395 from GauthamGoli/parameters-audit-regex-fix
...
lines_cop: Update regex patterns to prevent false positives
2017-11-03 17:48:09 +00:00
Mike McQuaid and GitHub
c6f40d5864
Merge pull request #3385 from MikeMcQuaid/path-fixes-cleanup
...
Fix and cleanup some PATH usage.
2017-11-03 17:45:57 +00:00
Mike McQuaid
c843fd2f12
requirement: prepend rather than append PATH.
...
Otherwise this ends up behind e.g. `/usr/bin` so is pretty useless.
2017-11-03 14:50:17 +00:00
Markus Reiter and GitHub
4eeac6f884
Merge pull request #3389 from amyspark/hacktoberfest-single-zap
...
Check that a single uninstall_* and zap stanza is defined
2017-11-03 13:23:08 +01:00
L. E. Segovia
c636be07f9
Separate do end into multiple lines
2017-10-31 09:54:30 -03:00
L. E. Segovia
917c138eeb
Add tests for uninstall_* and zap stanzas
2017-10-30 20:47:40 -03:00
Mike McQuaid and GitHub
7a0fdc3d03
Merge pull request #3393 from MikeMcQuaid/with_env_tweaks
...
Tweak use of with_env
2017-10-30 08:17:06 +00:00
Gautham Goli
f648dd03ff
lines_cop: Update regex patterns to prevent false positives
2017-10-29 23:40:04 +05:30
Isabell Long
640b1e9dcb
formula_desc_cop: ensure no full stops at the end of desc
...
- This was a suggestion by Mike McQuaid in my `homebrew-core` audit
description PR. Based on ilovezfs's incantation `grep -r -E 'desc
".*\."' *.rb`, some formulae descriptions do end in full stops. (My
initial assessment of this failed to account for the fact that
descriptions are strings and so end in `"`.)
- Add an autocorrect for this cop, too.
2017-10-29 15:19:31 +00:00
Mike McQuaid
ca189437e4
Tweak use of with_env
...
- Use it in more places where it saves code
- Allow using symbolic keys for a cleaner interface
- Use `HOMEBREW_GEM_*` instead of `GEM_OLD_*`
2017-10-29 14:44:43 +00:00
Mike McQuaid
8aa697363b
test.flac: add flac fixture.
2017-10-27 09:33:37 +01:00
Markus Reiter
8821cdc492
Include FileUtils in spec_helper.
2017-10-24 19:39:40 +02:00
Markus Reiter
7e970216a3
Refactor and fix RuboCop specs.
2017-10-24 19:39:40 +02:00
Markus Reiter
fd29511bae
Update to RuboCop 0.51.
2017-10-24 19:39:40 +02:00
Mike McQuaid and GitHub
7f46dcfa35
Merge pull request #3313 from GauthamGoli/audit_line_rubocop_part_4_rebase_attempt_1
...
audit: Port line_problems to rubocop and add tests part 4
2017-10-24 10:36:31 +01:00
Shaun Jackman
f9d42659ea
pull: Fix pull --bottle 1234
...
Fix the error:
Error: undefined method `casecmp' for nil:NilClass
2017-10-22 08:52:16 -07:00
Gautham Goli
7b2fab8ec5
Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1
2017-10-21 13:53:44 +05:30
Gautham Goli
ee35d65867
lines_cop: Refactor to multiple cops and fix style violations
2017-10-21 12:50:49 +05:30
Gautham Goli
bdc7eba4b3
Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1
2017-10-21 01:48:00 +05:30
Markus Reiter
487bec9570
Move String#undent to compat.
2017-10-18 14:39:09 +02:00
Markus Reiter
9bee9ca575
Use “squiggly” heredocs.
2017-10-18 14:39:09 +02:00
Mike McQuaid and GitHub
1d40061c69
Merge pull request #3291 from JCount/lines-cop-fix-wine-universal-binary
...
lines_cop: add ENV.universal_binary audit exemption for wine
2017-10-18 10:32:34 +01:00
Shaun Jackman
230c87aff0
Rename MinimumMacOSRequirement to MacOSRequirement
...
Move MinimumMacOSRequirement to compat.
2017-10-17 16:16:44 -07:00
Shaun Jackman
95e144a1c8
Add depends_on :linux and :macos
2017-10-17 16:16:12 -07:00
JCount
85fa79b5cf
lines_cop_spec: improve language in universal_binary and build tests
2017-10-15 10:36:51 -04:00
JCount
ca52eee2ad
lines_cop_spec: add test for ENV.universal_binary audit exemption for wine
2017-10-15 10:26:03 -04:00
Dominyk Tiller
29070e5cbe
formula_desc_cop_spec: add empty string test
2017-10-14 02:50:08 +01:00
Gautham Goli
7fa51f71f1
Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1
2017-10-13 19:50:46 +05:30
Markus Reiter
71b6e239d7
Set RuboCop maximum to current maximum.
2017-10-10 17:00:04 +02:00
Markus Reiter
175ca909ee
Clean up code style and remove .rubocop_todo.yml.
2017-10-08 16:10:37 +02:00
Markus Reiter
efbc1b0cb4
Add specs for CaskLoader.
2017-10-08 15:48:54 +02:00
Markus Reiter
9795195726
Fix RuboCop tests.
2017-10-07 23:30:47 +02:00
Markus Reiter and GitHub
5cbf8bdaa7
Merge pull request #3283 from reitermarkus/cask-loader
...
Add helper method for Cask fixture paths and refactor CaskLoader.
2017-10-07 18:30:32 +02:00
Markus Reiter
97333df4cb
Add helper method for Cask fixture paths and refactor CaskLoader.
2017-10-07 16:11:25 +02:00
Markus Reiter and GitHub
8f43d6b9f7
Merge pull request #3267 from reitermarkus/refactoring
...
Refactor DSL and Artifact classes.
2017-10-07 00:32:42 +02:00
Mike McQuaid and GitHub
dd2083d03d
Merge pull request #3262 from kabel/version-detect-php
...
Add version detection support for php URL
2017-10-06 04:34:12 +01:00
Markus Reiter
e9c587d751
Refactor tests.
2017-10-04 18:52:34 +02:00
Markus Reiter
51a0de6368
Directly save artifacts in DSL.
2017-10-04 18:47:55 +02:00
Markus Reiter
2c7ef064e4
Refactor DSL and Artifacts.
2017-10-04 18:47:55 +02:00
Markus Reiter and GitHub
0fbcbc7864
Merge pull request #3259 from reitermarkus/underscore_supporting_uri
...
Remove `UnderscoreSupportingURI`.
2017-10-04 11:40:38 +02:00
Kevin Abel
4f55565677
Add test for php version in URL middle
2017-10-03 23:39:14 -05:00
Markus Reiter
643b2a168c
Refactor cask/cli specs.
2017-10-03 10:56:40 +02:00
Markus Reiter and GitHub
ec0d8fa7ba
Merge pull request #3220 from yzguy/yzguy/cask_available_languages_to_info
...
add available languages to cask info command
2017-10-03 08:31:56 +02:00
Markus Reiter
a92b6318eb
Remove UnderscoreSupportingURI.
2017-10-03 08:29:20 +02:00
Adam Smith
270bf0506a
stylistic changes for cask info tests
2017-10-02 11:34:50 -07:00
Markus Reiter
3bb89f5440
Only run trash test when collecting coverage.
2017-10-01 22:26:04 +02:00
Adam Smith
92311901c9
add available languages to cask info command
...
add language tests for dsl
add fixtures, tests for languages info output
add extra lines
2017-09-30 18:25:12 -07:00
Vítor Galvão and GitHub
03e37faea4
Merge pull request #3234 from reitermarkus/locale
...
Support UN M.49 region codes.
2017-09-29 19:23:50 +01:00
Markus Reiter
479544665b
Support UN M.49 region codes.
2017-09-29 11:41:23 +02:00
Mike McQuaid