Mike McQuaid
32ce927cae
Merge pull request #3372 from MikeMcQuaid/rubocop-length-taps
...
rubocop: disable length checks.
2017-10-27 08:45:58 +01:00
Mike McQuaid
25d8771518
Merge pull request #3368 from MikeMcQuaid/unhide-readall-update-reset
...
Unhide readall and update-reset from manpage.
2017-10-27 08:45:47 +01:00
Jayendra Minakshisundar
590f06187f
tap-info: sort taps by name to handle APFS
2017-10-27 11:41:00 +05:30
Thomas Andrew
0e991095f1
Fix issue where keychain github credentials wouldn't work
2017-10-26 18:54:48 +01:00
JCount
badbb00b08
Merge pull request #3352 from JCount/legacy-java-cask-requirement-support
...
java_requirement: support prompting users to install legacy Java casks
2017-10-26 11:26:00 -04:00
Mike McQuaid
6114f48d5d
Unhide readall and update-reset from manpage.
...
These are both tools that end-users can find useful on occasion so it
doesn't make sense to hide them.
2017-10-26 16:14:14 +01:00
Mike McQuaid
1f259c2777
rubocop: disable length checks.
...
We should keep these enabled for Homebrew/brew but for taps these just
end up being annoying and making `brew style` fail for little benefit
2017-10-26 15:52:14 +01:00
Mike McQuaid
40b212322c
Merge pull request #3366 from GauthamGoli/lines-cop-false-positives-fix
...
lines_cop: Fix detection of negated expression
2017-10-26 15:28:40 +01:00
JCount
224864b149
java_requirement: support prompting users to install legacy Java casks
...
This enhances the Java requirement to support prompting the user
to install the correct legacy Java version via Cask for formulae
that don't yet work with the latest version of Java. Previously,
even if the formula had a strict requirement that a specific,
older version of Java be used, the messaging would tell the user to
`brew cask install java` (i.e. to install the latest version of Java),
which wouldn't actually satisfy the requirement.
2017-10-26 09:57:03 -04:00
Gautham Goli
09326909af
lines_cop: Fix detection of negated expression
2017-10-26 15:35:14 +05:30
Mike McQuaid
4d02b96c67
Merge pull request #3356 from jonchang/patch-1
...
docs: fix poor visibility in syntax highlighting
2017-10-26 10:16:20 +01:00
Markus Reiter
feb3e35e3c
Merge pull request #3367 from commitay/rubocop-cask
...
rubocop-cask: 0.15.1
2017-10-26 03:50:38 +02:00
commitay
783983b652
rubocop-cask: 0.15.1
2017-10-26 10:21:46 +10:00
Mike McQuaid
0cec599b28
Merge pull request #3361 from MikeMcQuaid/lines_cop_clang
...
lines_cop: fix clang detection.
2017-10-25 08:02:33 +01:00
Markus Reiter
8be34a98f8
Merge pull request #3349 from reitermarkus/rubocop-0.51
...
Rubocop 0.51
2017-10-24 21:21:34 +02:00
Markus Reiter
632fdca2d4
Merge pull request #3306 from amyspark/hacktoberfest-quash-cask-help
...
Fixes querying Cask commands' help
2017-10-24 20:54:24 +02:00
Markus Reiter
a99a19819c
Update rubocop-cask to 0.15.0.
2017-10-24 19:39:40 +02:00
Markus Reiter
0ea855c6e6
Add missing require "forwardable".
2017-10-24 19:39:40 +02:00
Markus Reiter
23ec8e07d4
Use / to join path.
2017-10-24 19:39:40 +02:00
Markus Reiter
526299913f
Remove usless comments.
2017-10-24 19:39:40 +02:00
Markus Reiter
b63a5cbd4b
Don't require "thread".
2017-10-24 19:39:40 +02:00
Markus Reiter
8821cdc492
Include FileUtils in spec_helper.
2017-10-24 19:39:40 +02:00
Markus Reiter
f0a512ace4
Don’t use Style/StderrPuts.
2017-10-24 19:39:40 +02:00
Markus Reiter
7e970216a3
Refactor and fix RuboCop specs.
2017-10-24 19:39:40 +02:00
Markus Reiter
fd29511bae
Update to RuboCop 0.51.
2017-10-24 19:39:40 +02:00
Mike McQuaid
d067b5f434
lines_cop: fix clang detection.
...
We only care about e.g. `gcc`/`llvm-gcc`/`clang` being at the beginning
of a `system` call and not anywhere within the string.
2017-10-24 16:03:13 +01:00
L. E. Segovia
09e26b1152
brew style fixes
2017-10-24 10:17:11 -03:00
Mike McQuaid
cd61430bad
Merge pull request #3360 from ilovezfs/github-formula-name-in-issue-title
...
github: require formula name to be in issue title
2017-10-24 13:28:09 +01:00
L. E. Segovia
2bfc7904fb
Simplify cask help check
2017-10-24 08:04:49 -03:00
ilovezfs
1937625d86
github: require formula name to be in issue title
2017-10-24 03:07:33 -07:00
Mike McQuaid
7f46dcfa35
Merge pull request #3313 from GauthamGoli/audit_line_rubocop_part_4_rebase_attempt_1
...
audit: Port line_problems to rubocop and add tests part 4
2017-10-24 10:36:31 +01:00
Mike McQuaid
78b012740c
Merge pull request #3345 from maxim-belkin/coffee-leaves
...
leaves: account for requirements
2017-10-24 10:28:51 +01:00
Mike McQuaid
d5e32300bf
Merge pull request #3358 from maxim-belkin/build-env2
...
build_environment: add Linux-specific environment variables
2017-10-24 10:04:29 +01:00
Jonathan Chang
6554b2595b
docs: fix poor visibility in syntax highlighting
2017-10-23 11:22:08 -07:00
Mike McQuaid
357b7bb0b7
Merge pull request #3350 from DomT4/gpg_executable
...
gpg: a little intentional yak shaving
2017-10-22 19:48:57 +01:00
Mike McQuaid
a1ff34dfad
Merge pull request #3351 from DomT4/checksum_doc
...
Checksum_Deprecation: tweak phrasing/explanation/etc
2017-10-22 19:48:09 +01:00
Mike McQuaid
7e4f42369f
Merge pull request #3337 from sjackman/pull
...
pull: Fix pull --bottle 1234
2017-10-22 19:40:24 +01:00
Shaun Jackman
f9d42659ea
pull: Fix pull --bottle 1234
...
Fix the error:
Error: undefined method `casecmp' for nil:NilClass
2017-10-22 08:52:16 -07:00
Dominyk Tiller
71ef1b091a
Checksum_Deprecation: tweak phrasing/explanation/etc
2017-10-22 05:31:53 +01:00
Dominyk Tiller
1b084b5aa0
gpg2_requirement: use direct 'available?' logic
2017-10-22 05:11:52 +01:00
Dominyk Tiller
dad939c4d1
gpg: make executable a function, not a constant
...
It's a lot nicer to call `Gpg.executable` rather than
`Gpg::GPG_EXECUTABLE` externally. Also squash some logic.
2017-10-22 05:11:25 +01:00
L. E. Segovia
a8ee54a35f
Actually check that the command name was set before adding it to args
2017-10-21 15:43:20 -03:00
Mike McQuaid
ce0e96c320
Merge pull request #3347 from DomT4/apfs_diagnostic
...
diagnostic: handle APFS returning hash order
2017-10-21 16:52:59 +01:00
Gautham Goli
7b2fab8ec5
Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1
2017-10-21 13:53:44 +05:30
Gautham Goli
ee35d65867
lines_cop: Refactor to multiple cops and fix style violations
2017-10-21 12:50:49 +05:30
L. E. Segovia
10cbc77af9
Fix brew style errors
2017-10-20 20:21:38 -03:00
Markus Reiter
a08f1c6748
Merge pull request #3343 from reitermarkus/rubocop-cask
...
Update `rubocop-cask` version.
2017-10-20 23:47:03 +02:00
Dominyk Tiller
212367ee7e
diagnostic: handle APFS returning hash order
2017-10-20 22:44:11 +01:00
Gautham Goli
bdc7eba4b3
Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1
2017-10-21 01:48:00 +05:30
L. E. Segovia
75de4db003
Let Cask handle the -h flag
2017-10-20 16:51:26 -03:00
Mike McQuaid