Commit Graph
63 Commits
Author SHA1 Message Date
EricFromCanada 89f0fcedbe whitespace fixes 2019-04-13 21:32:04 -04:00
EricFromCanada fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00
Steven Peters e91b889e04 utils/github: use tap.full_name 2019-03-03 22:58:31 -08:00
Mike McQuaid d64429a736 rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
Markus Reiter a4e0413bf9 Let GitHub::open_api return nil when status is 204 No Content. 2019-02-20 02:11:19 +01:00
Markus Reiter e9c45ff17b Pass additional options to GitHub.pull_requests. 2019-02-16 11:30:49 +01:00
Markus Reiter 68e0c5f904 Check for write access instead of HOMEBREW_DEVELOPER. 2019-02-15 16:27:37 +01:00
Markus Reiter 57fefff942 Add brew cask automerge command. 2019-02-15 16:27:37 +01:00
Mike McQuaid ec5ce4b180 utils/github: display max 20 closed PRs.
Closes #5553.
2019-01-19 17:17:21 +00:00
Mike McQuaidandGitHub b167a88e4d Merge pull request #5090 from JBallin/gist-token-error
Clarify how to set HOMEBREW_GITHUB_API_TOKEN
2018-10-21 15:41:34 +01:00
Mike McQuaid 056dd588b2 utils/github: add ValidationFailedError.
These have specific errors returned so would be more useful to output.
2018-10-15 12:03:16 -07:00
JBallin 2bf0db40b3 Normalize formatting of gist-logs errors 2018-10-14 20:40:24 -07:00
JBallin 2a1b936f76 Clarify HOMEBREW_GITHUB_API_TOKEN in gist-logs err 2018-10-14 20:40:24 -07:00
Alyssa Ross 864475e14f bump-formula-pr: use GitHub error message info
This saves an API call, and is more accurate, because the repo API
doesn't actually say whether forking is enabled, but this error message
does.

To do this, the original GitHub error message had to be accessible on
the GitHub exceptions.
2018-10-11 16:39:29 +01:00
Markus Reiter e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Mike McQuaid bcb1ec5499 Improve Homebrew/brew line length.
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
2018-09-02 16:15:09 +01:00
Gautham Goli 54033d320b utils/github: Raise exceptions if status code != 200 or exit code is not 0 2018-08-15 20:57:22 +05:30
Markus Reiter 8ae284e871 Use SystemCommand for curl. 2018-08-01 01:04:42 +02:00
ilovezfsandGitHub cd2b85c40f Revert "Use SystemCommand for curl." 2018-07-29 21:45:04 -07:00
Markus Reiter 355df64d93 Use SystemCommand for curl. 2018-07-29 01:23:33 +02:00
commitay 7542c4edb7 utils/github: remove full stop from the "skipping" comment 2018-07-25 15:38:14 +10:00
Mike McQuaid e2968c7889 Various cleanup and fixes.
Rename some variables and use existing regexes and a single variable.
2018-05-21 15:36:26 +01:00
Gautham Goli 26e77dd75c new-formula: Don't fail CI instead comment on PR about audit violations 2018-04-30 10:59:20 +05:30
Gautham Goli 1e0f9fb835 bump-formula-pr: Replace hub with GH API calls to fork and open Pull request 2018-03-31 19:44:55 +05:30
Mike McQuaid 83cca40fc9 RuboCop 0.53.0 manual fixes. 2018-03-08 14:10:02 +00:00
Mike McQuaid 1f48e17f1b rubocop: fix brew style warnings. 2018-01-17 10:42:43 +00:00
Thomas Andrew 0e991095f1 Fix issue where keychain github credentials wouldn't work 2017-10-26 18:54:48 +01:00
ilovezfs 1937625d86 github: require formula name to be in issue title 2017-10-24 03:07:33 -07:00
Markus Reiter 9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Mike McQuaid cf5fdeef1d Rubocop: manual rule fixes. 2017-09-24 21:23:59 +01:00
Dominyk Tiller 0ea4da4ef6 github: limit PR search to Homebrew
Not sure whether this is the way you want to handle this problem but
it's really darn irritating so here's a PR that handles it one way.

Fixes: https://github.com/Homebrew/brew/pull/3086#issuecomment-324519156
2017-08-31 03:59:33 +01:00
Markus Reiter 56ef168e70 Move fix from #3070 inside GitHub module. 2017-08-20 16:31:46 +02:00
Ben Muschol ca05c7f010 Change var name 2017-08-17 14:38:50 -04:00
Ben Muschol 5f8d212ccc Unify vocabulary in github module, remove unnecessary logic
Fix duplication bug
2017-08-14 14:45:24 -04:00
Ben Muschol 68cdb550f7 Spec for issues search 2017-08-14 12:06:12 -04:00
Ben Muschol 603bdd01a8 Implement PR feedback 2017-08-14 11:08:56 -04:00
Ben Muschol d052f503f9 fix typo 2017-08-13 16:41:18 -04:00
Ben Muschol 91b139aca2 Fix syntax error 2017-08-13 16:15:26 -04:00
Ben Muschol acf46fce5f Rename path_to -> url_to since it returns a url 2017-08-13 15:03:52 -04:00
Ben Muschol e93ec12b32 Remove duplicate url generation logic in Github module 2017-08-13 15:03:44 -04:00
Markus Reiter ae4bafdb36 Simplify CurlDownloadStrategy. 2017-08-08 18:10:13 +02:00
ilovezfsandGitHub 986887b413 Revert "Refactor SVN and cURL download strategies." 2017-08-07 14:31:56 -07:00
Markus Reiter dc5a2c1764 Simplify CurlDownloadStrategy. 2017-08-07 21:31:17 +02:00
Jason Karns c2899b6559 Tap learns to form its own full_name
full_name is formed from `{user}/homebrew-{repo}` and is always
lowercase.
2017-06-19 09:42:59 -04:00
Markus Reiter 5828eefd01 Remove to_s from some Pathnames. 2017-05-08 13:37:28 +02:00
Markus Reiter 133e5ddf6a Remove unnecessary block. 2017-04-25 12:29:01 +02:00
Markus Reiter 2bda194bd9 Add GitHub::search_code method. 2017-04-25 12:29:01 +02:00
Mike McQuaid d0bbadde22 github: don't print when searching PRs. 2017-03-23 08:39:28 +00:00
William Woodruff d07b9ed7f2 Replace Utils::JSON with corelib JSON calls. 2016-11-20 20:06:25 -05:00
Mike McQuaid 3c7446f3ff Improve GitHub API scopes output.
Improve the GitHub API scope and token related messaging by
autopopulating the scopes we need on the new scopes page and, in the
case of a lacking a scope we need, output what scope was required.

Also, DRY up the personal access token code.
2016-10-30 15:38:19 -04:00