Commit Graph
21093 Commits
Author SHA1 Message Date
Seeker 8fa263bcb9 rubocops/text: add "in homebrew/core" to applicable tests 2021-01-15 08:41:47 -08:00
Seeker 3893cb312e rubocops/text: improve test descriptions 2021-01-14 18:08:05 -08:00
Mike McQuaidandGitHub e989a0fb01 Merge pull request #10327 from MikeMcQuaid/keg-fix-alias-handling
Keg: fix alias and versioned symlink handling.
2021-01-14 16:58:53 +00:00
Mike McQuaid eaae52edb8 tab: return default values on existing, blank install receipt contents. 2021-01-14 16:26:58 +00:00
Mike McQuaid 2f018d1a98 cask/cmd/info_spec: remove skipped test.
Unfortunately skipping this test makes it show up in the PR diff every
time. Let's just delete it for now instead.
2021-01-14 16:10:07 +00:00
Mike McQuaid 128aeba3a4 Keg: fix alias and versioned symlink handling.
Previously, `brew upgrade gcc@10` could get overzealous and remove the
`LinkedKeg` record for `gcc@9`. This is bad because we then think
`gcc@9` is unlinked when it is not and it causes a tonne of conflicts
when trying to link `gcc@9` again.

Instead, fix up the alias and versioned alias cleanup to be more
precise and only delete the symlinks that point to the current `rack`,
`opt_record` or `linked_keg_record` and unify the logic so it's
performed consistently.

While we're here:
- don't `remove_old_aliases` every time we try to unlink a directory
  but just perform it once per `unlink` operation
- remove the linked keg record on `uninstall`
2021-01-14 16:02:06 +00:00
Mike McQuaid 17a073b6cc Revert "Keg: allow overwriting same-formula conflicts" 2021-01-14 12:04:59 +00:00
Mike McQuaid 591e9d6a52 dev-cmd/tap-new: fix output on newer versions of Git.
Otherwise this prints to `stderr` to ask for configuration of the branch
name:
https://github.com/Homebrew/brew/pull/10323/checks?check_run_id=1701105141#step:5:51
2021-01-14 10:47:44 +00:00
Markus ReiterandGitHub 1094e6dccb Merge pull request #10321 from Homebrew/dependabot/bundler/Library/Homebrew/tapioca-0.4.12
build(deps): bump tapioca from 0.4.11 to 0.4.12 in /Library/Homebrew
2021-01-14 08:27:17 +01:00
BrewTestBot 2e11080c8f Update RBI files for tapioca. 2021-01-14 06:21:40 +00:00
BrewTestBot b0da94b989 brew vendor-gems: commit updates. 2021-01-14 06:20:53 +00:00
dependabot[bot]andGitHub e8c5b63c09 build(deps): bump tapioca from 0.4.11 to 0.4.12 in /Library/Homebrew
Bumps [tapioca](https://github.com/Shopify/tapioca) from 0.4.11 to 0.4.12.
- [Release notes](https://github.com/Shopify/tapioca/releases)
- [Commits](https://github.com/Shopify/tapioca/compare/v0.4.11...v0.4.12)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-14 06:18:49 +00:00
Jonathan Chang 641afdd2de rubocops: permit mirror in OS-specific resources 2021-01-14 17:04:40 +11:00
SeekerandGitHub 663b972f44 Merge pull request #10306 from SeekingMeaning/git-repo-pwd
utils/git_repository: use `Pathname.pwd` if no `repo` specified
2021-01-13 16:14:27 -08:00
Rylan PolsterandGitHub 701989968d Merge pull request #10268 from Rylan12/completions-opt-out
completions: make opt-in only
2021-01-13 16:08:30 -05:00
Seeker 4f02c1c8a8 utils/git_repository: use Pathname.pwd if no repo specified 2021-01-13 13:02:37 -08:00
Misty De Meo a2e0da89e4 Keg: only instantiate Keg.for if target exists 2021-01-13 12:18:49 -08:00
Mike McQuaidandMisty De Meo 66f0a35587 keg: remove trailing whitespace. 2021-01-13 12:18:49 -08:00
Mike McQuaidandMisty De Meo e01fa7d2ae keg: tweak retry comment. 2021-01-13 12:18:49 -08:00
Misty De Meo 53fe6b518f Keg: allow overwriting same-formula conflicts
This is weird. We're seeing some installs where formulae
have no opt prefix and no linked keg record, *but* still
ended up linked into the prefix. Upgrades will blow up in
this case because the old symlinks won't get deleted and
Homebrew will report a nonsensical error message about
not being able to link over another link from the same
formula!

Since the optpath is either missing or pointing to the
wrong destination at this point, the checks for conflict
linking above will have failed. We should instead be safe
to simply blow away these conflicting symlinks and replace
them with the new targets.

Fixes https://github.com/Homebrew/homebrew-core/issues/68866.
2021-01-13 12:18:49 -08:00
Misty De Meo 847897fdac Popen spec: ensure Rubocop is happy
These were introduced in #10305 but only started going red
after that PR was merged.
2021-01-13 11:21:10 -08:00
Misty De MeoandGitHub c197e9a27d Merge pull request #10315 from mistydemeo/cask_is_unavailable_hotfix
Cask tests: temporarily disable broken test
2021-01-13 11:14:33 -08:00
SeekerandGitHub be6dd72c16 Merge pull request #10305 from SeekingMeaning/safe-popen-tests
utils/popen: add `safe` argument to `popen_read` and `popen_write`
2021-01-13 10:51:46 -08:00
Misty De Meo 79aff82c39 Cask: skip test that is currently broken in master 2021-01-13 10:42:46 -08:00
SeekerandGitHub c72b375a57 Merge pull request #10269 from SeekingMeaning/style-cc-shim
shims/super/cc: fix most style errors
2021-01-13 09:07:55 -08:00
Rylan Polster 4b8477ba70 Completions, Settings: move to Homebrew namespace 2021-01-13 11:20:28 -05:00
Sam FordandGitHub ec93e91909 Merge pull request #10208 from samford/livecheck-skip-archived-stable-urls
Livecheck: Skip archived stable URLs in formulae
2021-01-13 08:42:58 -05:00
Mike McQuaidandGitHub 4520b3a52b Merge pull request #10311 from Homebrew/dependabot/bundler/Library/Homebrew/tapioca-0.4.11
build(deps): bump tapioca from 0.4.10 to 0.4.11 in /Library/Homebrew
2021-01-13 11:02:06 +00:00
Markus ReiterandGitHub 759fc12089 Merge pull request #10304 from reitermarkus/cask-config-keys
Ignore invalid keys when reading existing `Cask::Config`.
2021-01-13 11:31:57 +01:00
BrewTestBot 2c3bc08c04 Update RBI files for tapioca. 2021-01-13 10:22:22 +00:00
BrewTestBot 95d7e5730e brew vendor-gems: commit updates. 2021-01-13 10:21:24 +00:00
Jonathan ChangandGitHub 71f7ef0058 Merge pull request #10300 from jonchang/rubocop-v1-api
rubocops: migrate to rubocop v1 API
2021-01-13 21:20:55 +11:00
dependabot[bot]andGitHub 250b3dc361 build(deps): bump tapioca from 0.4.10 to 0.4.11 in /Library/Homebrew
Bumps [tapioca](https://github.com/Shopify/tapioca) from 0.4.10 to 0.4.11.
- [Release notes](https://github.com/Shopify/tapioca/releases)
- [Commits](https://github.com/Shopify/tapioca/compare/v0.4.10...v0.4.11)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-13 10:19:10 +00:00
Mike McQuaidandGitHub 4dac964043 Merge pull request #10310 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.6206
build(deps): bump sorbet from 0.5.6205 to 0.5.6206 in /Library/Homebrew
2021-01-13 10:15:22 +00:00
Markus Reiter b1000952b1 Make LazyObject type-checkable. 2021-01-13 10:46:28 +01:00
Markus ReiterandGitHub 028e733e79 Merge pull request #10260 from reitermarkus/audit-livecheck
Improve audit for `livecheck` in casks.
2021-01-13 08:46:57 +01:00
Markus Reiter 9922ad382f Ignore invalid keys when reading existing Cask::Config. 2021-01-13 08:30:50 +01:00
Markus Reiter 92b58666ef Improve audit for livecheck in casks. 2021-01-13 08:12:11 +01:00
SeekerandGitHub 82901036f9 Merge pull request #10298 from SeekingMeaning/ast
utils/ast: move helper functions from `FormulaAST` to `AST`
2021-01-12 22:32:23 -08:00
BrewTestBot 473e10db94 brew vendor-gems: commit updates. 2021-01-13 06:18:58 +00:00
dependabot[bot]andGitHub 37de7e6775 build(deps): bump sorbet from 0.5.6205 to 0.5.6206 in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.6205 to 0.5.6206.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-13 06:16:49 +00:00
Sam FordandMike McQuaid 12e5f4dce1 Livecheck: Refactor #skip_conditions into a module
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-01-12 18:34:33 -05:00
Sam Ford aae91cacae Livecheck: Skip Internet Archive stable URLs 2021-01-12 18:04:26 -05:00
Sam Ford f36d1a7fb6 Livecheck: Skip Google Code Archive stable URLs 2021-01-12 18:04:26 -05:00
Sam Ford 84e058f6ca Livecheck: Refactor memoized helpers 2021-01-12 18:04:26 -05:00
Seeker b58571a90b shims/super/cc: add CXX_REGEX constant 2021-01-12 13:49:36 -08:00
Seeker 0f2ed88f9f shims/super/cc: require English 2021-01-12 13:49:33 -08:00
SeekerandGitHub 99a7e2192c Merge pull request #10296 from SeekingMeaning/utils-named-subject
test/utils/*: use `described_class` or named `subject`
2021-01-12 13:38:55 -08:00
Rylan PolsterandMike McQuaid eb3a662841 completions: clarify that only external tap completions are affected
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2021-01-12 16:31:24 -05:00
Rylan Polster f1f3fdc315 settings: add module for managing git config settings 2021-01-12 16:27:25 -05:00