Commit Graph
21494 Commits
Author SHA1 Message Date
Carlos ÁlvaroandRylan Polster aebf4c9100 Safe access to tap attributes
Prevent calling name tap attribute when the tap is nil

Co-Authored-By: Rylan Polster <rslpolster@gmail.com>
2021-02-08 13:20:41 +01:00
Carlos Álvaro 7ca79553f0 Add test to check --json=v2 format 2021-02-08 13:20:41 +01:00
Carlos Álvaro a20b601120 Add tap to formula json output 2021-02-08 13:20:40 +01:00
Carlos Álvaro 84d80cf0bf Add tap to cask json output 2021-02-08 13:20:40 +01:00
Carlos Álvaro 4f5f3824c6 Add full_token to cask json output 2021-02-08 13:20:40 +01:00
Mike McQuaid cdbc1d43a6 homebrew_bootsnap: fail more gracefully.
If `bootsnap` isn't available then print out an error message rather
than failing all of Homebrew.
2021-02-05 15:43:55 +00:00
Mike McQuaid 4e5a48df8d brew vendor-gems: commit updates. 2021-02-05 15:07:52 +00:00
Mike McQuaid 72cb6ffd12 utils: import {ohai,puts}_stdout_or_stderr
Fixes #10536
2021-02-05 15:03:31 +00:00
Issy LongandGitHub 984eb3f878 Merge pull request #10535 from issyl0/utils-github-error-if-no-creds-are-detected-and-scopes-are-required
utils/github: Provide a better error message when users don't have any GitHub credentials set
2021-02-05 14:19:28 +00:00
f71ea65ee0 utils/github: Say "macOS keychain" in MissingAuthenticationError
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-02-05 13:52:32 +00:00
Mike McQuaidandGitHub 4c8fe984c6 Merge pull request #10533 from Bo98/arm-devtools
os/mac/diagnostic: always require dev tools on Apple Silicon
2021-02-05 13:42:46 +00:00
Issy Long 9394fe2b52 utils/github: Use constant everywhere for "create a PAT" message
- This way if we ever change this messaging, we only have to do so once.
2021-02-05 12:45:11 +00:00
Issy Long ccb6d5e834 utils/github: Handle users not having any GitHub credentials
- When running `brew request-bottle`, users who don't have credentials
  in the macOS keychain (ie, Linux users) or `HOMEBREW_GITHUB_API_TOKEN`
  receive "Error: Not Found" from the GitHub API returning a 404.
- This is cryptic and confusing for newcomers to Linux maintenance, and
  potentially confusing to other folks using `open_api` where
  credentials are expected yet unset.
- This adds a new `MissingAuthenticationError` to handle the case where
  the GitHub API returns 404 and there are no creds yet API scopes are
  required.

Before:

```
issyl0@sky:/home/linuxbrew/.linuxbrew/Homebrew$ brew request-bottle hello
==> Dispatching request to Homebrew/linuxbrew-core for hello
Error: Not Found
```

After:

```
issyl0@sky:/home/linuxbrew/.linuxbrew/Homebrew$ brew request-bottle hello
==> Dispatching request to Homebrew/linuxbrew-core for hello
Error: No GitHub credentials found in Keychain or environment.
Create a GitHub personal access token:
    https://github.com/settings/tokens/new?scopes=gist,public_repo&description=Homebrew
  echo 'export HOMEBREW_GITHUB_API_TOKEN=your_token_here' >> ~/.profile
```
2021-02-05 12:44:46 +00:00
Bo Anderson ec3e078bcb os/mac/diagnostic: always require dev tools on Apple Silicon 2021-02-05 12:26:28 +00:00
Mike McQuaidandGitHub e98a913783 Merge pull request #10501 from MikeMcQuaid/update-stderr
cmd/update-report: output to stderr when not a TTY.
2021-02-05 12:15:30 +00:00
Mike McQuaidandGitHub ebc7cc36a0 Merge pull request #10530 from Homebrew/dependabot/bundler/Library/Homebrew/codecov-0.4.3
build(deps): bump codecov from 0.4.2 to 0.4.3 in /Library/Homebrew
2021-02-05 09:31:49 +00:00
Mike McQuaidandGitHub bc5a8c8055 Merge pull request #10531 from Homebrew/dependabot/bundler/Library/Homebrew/bootsnap-1.7.1
build(deps): bump bootsnap from 1.7.0 to 1.7.1 in /Library/Homebrew
2021-02-05 09:26:59 +00:00
Mike McQuaidandGitHub ea464b746f Merge pull request #10532 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.6274
build(deps): bump sorbet from 0.5.6267 to 0.5.6274 in /Library/Homebrew
2021-02-05 09:26:50 +00:00
Mike McQuaidandGitHub 6bf4cf06e7 Merge pull request #10489 from carlocab/unbrewed
cmd/--prefix: ignore shared-mime-info and mactex
2021-02-05 08:54:12 +00:00
dependabot[bot]andGitHub 1332f6d15b build(deps): bump sorbet from 0.5.6267 to 0.5.6274 in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.6267 to 0.5.6274.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-05 06:03:07 +00:00
dependabot[bot]andGitHub 11e3ec4110 build(deps): bump bootsnap from 1.7.0 to 1.7.1 in /Library/Homebrew
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.7.0...v1.7.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-05 06:02:38 +00:00
dependabot[bot]andGitHub f14f98c4f9 build(deps): bump codecov from 0.4.2 to 0.4.3 in /Library/Homebrew
Bumps [codecov](https://github.com/codecov/codecov-ruby) from 0.4.2 to 0.4.3.
- [Release notes](https://github.com/codecov/codecov-ruby/releases)
- [Changelog](https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-ruby/compare/v0.4.2...v0.4.3)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-05 06:02:23 +00:00
Jonathan ChangandGitHub f516eded8f Merge pull request #10458 from jonchang/xcode-12.4
xcode: update for Xcode 12.4
2021-02-05 16:49:08 +11:00
Rylan Polster 5f57601fd8 style: re-enable bottle order cop 2021-02-04 17:18:20 -05:00
Rylan PolsterandGitHub 42b755e13f Merge pull request #10522 from Rylan12/bottle-correct-order
bottle: write bottles in correct order
2021-02-04 17:17:19 -05:00
Dawid DziurlaandGitHub 55ae994d61 Merge pull request #10521 from dawidd6/untap-force-fix
untap: add missing --force switch
2021-02-04 23:11:35 +01:00
Rylan Polster 3dccea251f bottle: write bottles in correct order 2021-02-04 16:04:13 -05:00
Sam FordandGitHub 6df0a49fb5 Merge pull request #10504 from samford/skip-archived-repo-audits-if-disabled
formula_auditor: skip archived repository audits if disabled
2021-02-04 13:08:19 -05:00
Dawid Dziurla a90fb27adb untap: add missing --force switch 2021-02-04 18:36:32 +01:00
Carlo Cabrera 2de172e050 rubocops/bottle: disable bottle order check
This is causing CI failures at homebrew/core [1], so let's disable this
for now.

[1] https://github.com/Homebrew/homebrew-core/commit/01b6830646c216a80e4747154963942626ce4cbe
2021-02-04 11:18:09 +00:00
BrewTestBot 902e00968c brew vendor-gems: commit updates. 2021-02-04 06:06:21 +00:00
dependabot[bot]andGitHub 824b38102e build(deps): bump sorbet from 0.5.6262 to 0.5.6267 in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.6262 to 0.5.6267.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-04 06:01:35 +00:00
Rylan PolsterandGitHub 020c53283c Merge pull request #10453 from SeekingMeaning/old-bottle-rubocop
rubocops: add rubocop for old bottle syntax
2021-02-03 22:05:49 -05:00
Rylan Polster 727ac9b47f bottle: write bottles with new syntax 2021-02-03 20:46:20 -05:00
SeekerandRylan Polster 4c42d717fd rubocops: add cops to check bottle format, indentation, and order
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
2021-02-03 20:46:20 -05:00
Mike McQuaid 7f6f915178 homebrew_bootsnap: disable on ARM.
From https://github.com/Homebrew/homebrew-core/pull/70310/checks?check_run_id=1823920962
this looks very broken indeed.
2021-02-03 17:39:15 +00:00
Sam Ford 6de5de788b formula_auditor: skip archived audits if disabled 2021-02-03 10:12:36 -05:00
Rylan Polster dee57c307d style: allow long lines for bottle digests 2021-02-03 09:32:08 -05:00
Mike McQuaid dbf65770af cmd/update-report: output to stderr when not a TTY.
Otherwise things like `$(brew bundle list --formula)` become a bit
useless as they can auto-update and then will always fail.
2021-02-03 13:31:24 +00:00
Mike McQuaidandGitHub 04dab8428b Merge pull request #10499 from MikeMcQuaid/release-blog-post-notes
dev-cmd/release: output blog post release notes.
2021-02-03 10:46:04 +00:00
Mike McQuaid 1cf9f0f789 dev-cmd/release: output blog post release notes.
I forgot until I started to work on the 3.0.0 release that there was an
added step I would do for a major/minor release:

```
brew release-notes --markdown 2.7.0 | pbcopy
```

This would generate for 3.0.0/2.8.0 the release notes since 2.7.0 for
editing down into a blog post.

Add this behaviour to `brew release` and, because we're doing it
programmatically anyway, take this chance to also reject Dependabot
lines and sort them for easier grouping by pull request subject.
2021-02-03 10:06:10 +00:00
Mike McQuaidandGitHub dcf9d9368d Merge pull request #10495 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-rspec-2.2.0
build(deps): bump rubocop-rspec from 2.1.0 to 2.2.0 in /Library/Homebrew
2021-02-03 09:54:22 +00:00
BrewTestBot 440803e98b Update RBI files for rubocop-rspec. 2021-02-03 09:07:26 +00:00
BrewTestBot 023999a103 brew vendor-gems: commit updates. 2021-02-03 09:06:34 +00:00
Mike McQuaidandGitHub 8eeb838440 Merge pull request #10490 from nandahkrishna/fix-api-credentials-error
utils/github: fix false positive API credential error
2021-02-03 08:58:33 +00:00
dependabot[bot]andGitHub c15d625d32 build(deps): bump rubocop-rspec from 2.1.0 to 2.2.0 in /Library/Homebrew
Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v2.1.0...v2.2.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-03 08:58:10 +00:00
Mike McQuaidandGitHub d964e550be Merge pull request #10496 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.6262
build(deps): bump sorbet from 0.5.6259 to 0.5.6262 in /Library/Homebrew
2021-02-03 08:55:57 +00:00
Mike McQuaidandGitHub c5c151d2b3 Merge pull request #10494 from hyuraku/utils/curl_refactor-curl_with_workarounds
utils/curl: refactor curl_with_workarounds
2021-02-03 08:55:34 +00:00
Mike McQuaidandGitHub 97f1a03811 Merge pull request #10493 from Homebrew/sorbet-files-update
sorbet: Update RBI files.
2021-02-03 08:54:37 +00:00
nandahkrishna d0200e8737 cask/config: fix explicit_s 2021-02-03 13:37:53 +05:30