* Move GitHub API module to utils/github.rb.
* Move curl method to utils/curl.rb.
* global: use long curl arguments and an array.
This makes the code more self-documenting.
* utils/curl: support reading curl's output.
* utils/github: use curl instead of open-uri.
It has far better proxy support.
* pull: set Homebrew user agent.
* gist-logs: remove trailing whitespace.
* gist-logs: use first instead of [0].
Easier to read.
* gist-logs: use curl-based GitHub.open method.
I'm not completely sure this is "sane" logic but I'm leery of just reverting
Andrew's work this morning and making him rebuild that PR from scratch for one
syntax issue.
Sadly, because we run:
```
brew readall --aliases --syntax
```
On every CI job, and that flags this line previously as:
```
pull.rb:555: warning: possibly useless use of a variable in void context
```
Every single PR has "failed" since it was merged, and it's reached the point
of being a bit annoying, so let's try this.
Do the bottle check using any platform's bottle, so `brew pull` works
on bottled formulae which don't include a bottle for the current system.
Make output more concise and informative
* Remove expected download error messages when waiting for Bintray publishing
* Replace patch download progress bars with patch file name
* Silence git output about switching to and from bottle-pulling branch
* Include formula name and patch type in some progress messages
Looks like the bintray publish_wait_for_secs was being ignored because the
content type wasn't being set, so it defaulted to x-www-form-urlencoded
instead of application/json.
Changes the timeout to 0 to preserve current non-blocking behavior, which
we want in case multiple formulae are being updated.
ClosesHomebrew/homebrew#49951.
Signed-off-by: Andrew Janke <andrew@apjanke.net>
Return true if given path would present a Formula file in this Tap.
Accepts both absolute path and relative path (relative to this Tap's path)
It offer an abstraction such that caller would not need to worry about
low level file system in the tap.
It will be used in `brew pull` and `brew update`.
ClosesHomebrew/homebrew#49191.
Signed-off-by: Xu Cheng <xucheng@me.com>
`Formula[name]` gets called with an unqualified name and thus will throw
`TapFormulaAmbiguityError` exceptions (silently ignored) if both the old
and the new tap are present and changes for the new tap are pulled
before the migrated formulae are removed from the old tap.
The result is an empty or incomplete `changed_formulae`, causing issues
with pulling the corresponding bottles and possibly other problems, too.
For users whose local brew is at around 2015-06-11 to 2015-08-06,
running `brew update` will emit following error:
Error: uninitialized constant Formulary::CoreFormulaRepository
This is caused by the same bug described in Homebrew/homebrew#42553.
This commit workarounds this issue and restores `brew update` compatibility
for users mentioned above.
Also cleanup legacy `require "cmd/tap"`.
```
Fast-forward
Library/Formula/ant.rb | 8 ++++----
Library/Formula/nailgun.rb | 10 +++++-----
2 files changed, 9 insertions(+), 9 deletions(-)
Deleted branch pull-bottle-45902 (was 1fdb73d).
==> Publishing on Bintray:
{"files":3}
==> Publishing on Bintray:
Error: Failure while executing
```
In that case, "jetty-runner" is bottle unneeded, but because I've passed the
pull bottle command for the other two formulae, it attempts to publish a bottle
that isn't there.
Use an exponential back-off on the sleep and try the fetch more times.
Hopefully this will mean that we spent less time waiting for Bintray.
ClosesHomebrew/homebrew#43240.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Baptiste Fontaine