Commit Graph
782 Commits
Author SHA1 Message Date
Mike McQuaid 0408b78a23 tests: remove linkage cache env.
Otherwise this will mess with `brew tests`.
2018-05-24 15:09:41 +01:00
Mike McQuaidandGitHub 97645d061d Merge pull request #3720 from AndrewMcBurney/cache-optimization
Cache optimization for `brew linkage` command.
2018-05-24 09:14:02 +01:00
commitayandGitHub dc96e6f735 Merge pull request #4170 from commitay/new-formulae-options
audit: new formulae should not have options
2018-05-24 07:16:11 +10:00
Mike McQuaidandGitHub 63ffbd3298 Merge pull request #4161 from alyssais/pull-gpg
Fix brew pull with git commit.gpgsign enabled
2018-05-23 14:21:40 +01:00
commitay c297d39420 audit: add back new formulae condition for patches 2018-05-23 07:36:59 +10:00
Alyssa Ross bdfbc70c87 pull: only add gpg to path if enabled in git 2018-05-22 23:35:50 +02:00
Mike McQuaid c7aa286336 audit: tweak line length/style. 2018-05-22 14:52:02 +01:00
Mike McQuaid 44f5d3ec79 Refactor cache store code. 2018-05-22 14:46:14 +01:00
Gautham Goli 38c832b029 audit: exit with code 1 if regular audit errors or new formula audit errors when comment is not created 2018-05-22 19:14:18 +05:30
Gautham Goli b01446d059 audit: Add condition check on new_formula_audits 2018-05-22 17:55:40 +05:30
commitay 9d55fed15f audit: new formulae should not have options 2018-05-22 19:39:14 +10:00
Mike McQuaid 8401cffe41 audit: remove "new formula" from messaging. 2018-05-22 09:55:41 +01:00
Andrew R. McBurney 010207b982 Changed cache usage behavior.
1. Running `brew linkage some_package` does not set the cache.
2. Running `brew linkage --cached some_package` when `DatabaseCache.empty?` returns `true` should build the cache.
3. Running `brew linkage --cached some_package` when `DatabaseCache.empty?` returns `false` should use the cache.
2018-05-21 17:36:30 -04:00
Mike McQuaid 1c91c83eac Merge branch 'master' into bot-comment 2018-05-21 17:16:19 +01:00
Mike McQuaid e2968c7889 Various cleanup and fixes.
Rename some variables and use existing regexes and a single variable.
2018-05-21 15:36:26 +01:00
Andrew R. McBurney e93e8f3266 Lazily load db of type DBM instance variable for DatabaseCache so the corresponding database file isn't created in the .use block for a DatabaseCache. 2018-05-18 16:37:01 -04:00
Andrew R. McBurney cd6f89ca76 Made DatabaseCache.new private, and changes instances in code that call it to use DatabaseCache.use instead. 2018-05-18 10:06:30 -04:00
Alyssa Ross 96b95a838a Fix brew pull with git commit.gpgsign enabled
Because of environment filtering, git tries to sign the commit but
can't find gpg, which means that the patch won't be applied.
2018-05-12 21:25:55 +01:00
Mike McQuaid 840c97c1cc formula: add versioned formulae method. 2018-05-12 15:02:29 -04:00
Mike McQuaid c6f21f1dc1 bump-formula-pr: rename @args.
This shadows the Homebrew variable so let's rename it for now so that
`--force` works again.
2018-05-03 14:24:37 +01:00
Mike McQuaid 494bb624cc Merge remote-tracking branch 'origin/master' into cache-optimization 2018-05-03 09:27:09 +01:00
Mike McQuaid 555e2a2fc8 Merge remote-tracking branch 'origin/master' into cache-optimization 2018-05-02 09:46:58 +01:00
Mike McQuaid ea9c9494a6 bump-formula-pr: fix tag/revision argument.
Can't do `@args[hash_type]` if `hash_type` is `nil`.
2018-05-02 09:42:55 +01:00
Mike McQuaidandGitHub b1a92ba14a Merge pull request #3987 from GauthamGoli/bump-formula-pr-args
bump-formula-pr: Use Parser to parse args
2018-05-01 07:50:29 +01:00
Gautham Goli 07ee23d711 cli_parser: Refactor interface for depends, conflicts and add tests 2018-04-30 15:47:13 +05:30
Gautham Goli 26e77dd75c new-formula: Don't fail CI instead comment on PR about audit violations 2018-04-30 10:59:20 +05:30
AndrewMcBurney 916247b920 Merge remote-tracking branch 'origin/master' into cache-optimization 2018-04-24 16:49:51 -04:00
Mike McQuaid 4a03145c1c linkage: fix --test exit code.
Ensure that a non-zero exit code is set both for missing random dylibs
and random missing dependencies.

Additionally, while we are here, drastically trim down the public
interface for this class to the bare minimum and allow getting the
output from `display_test_output` as a variable.

Fixes issue mentioned by @ilovezfs in:
https://github.com/Homebrew/brew/pull/3940#issuecomment-383794520
2018-04-24 09:52:51 +01:00
Markus Reiter 33a9521576 Fix MissingFormula namespacing. 2018-04-22 17:27:44 +02:00
Markus Reiter 16fb563d49 Refactor MissingFormula spec. 2018-04-20 19:11:22 +02:00
Markus Reiter 5e2d4d52ba Refactor OsxfuseRequirement spec. 2018-04-20 19:11:22 +02:00
Mike McQuaidandGitHub 01c7df8860 Merge pull request #4071 from commitay/audit-head
audit: new formulae should not have a HEAD spec
2018-04-16 13:16:51 +01:00
Gautham Goli 36c1ad9f64 cli_parser: Add depends, conflicts option constraints 2018-04-14 21:44:47 +05:30
Gautham Goli 20155c8df9 bump-formula-pr: Use Parser to parse args 2018-04-14 21:44:47 +05:30
Gautham Goli 48aecf2fa7 cli_parser: Refactor required argument for flag to '=' 2018-04-14 19:04:24 +05:30
commitay 909312f9a4 audit: new formulae should not have a HEAD spec 2018-04-14 19:24:07 +10:00
Mike McQuaidandGitHub df19f7103c Merge pull request #4050 from maxim-belkin/fix-release-notes
Make release-notes command work from any location
2018-04-10 11:41:47 -07:00
Mike McQuaidandGitHub 3e173d8e5e Merge pull request #4048 from GauthamGoli/bottle-minor-fix
bottle: Use @args
2018-04-10 10:20:12 -07:00
Maxim Belkin 40b0d0b584 Make release-notes command work from any location
* specify repository location using `-C` option
* change `newest` to `latest` when talking about the latest tagged
commit
2018-04-10 10:23:40 -05:00
Gautham Goli a93e7ab2bd bottle: Use @args 2018-04-10 19:09:59 +05:30
Gautham Goli e809f93c45 mirror: Add missing import for cli_parser 2018-04-10 18:54:12 +05:30
Shaun Jackman df68d12be4 bottle: Add option --or-later
If --or-later is passed, append _or_later to the bottle tag.
2018-04-09 20:58:38 -07:00
Gautham Goli d22b750e17 Store common switch as Homebrew.args global var 2018-04-10 00:00:35 +05:30
AndrewMcBurney dcdd16237c Merge remote-tracking branch 'origin/master' into cache-optimization 2018-04-09 13:49:58 -04:00
Mike McQuaidandGitHub 54a594ea23 Merge pull request #3870 from GauthamGoli/bump-formula-gh-api
bump-formula-pr: Replace `hub` with GH API calls
2018-04-08 16:02:51 -07:00
Mike McQuaidandGitHub 010d593a8d bump-formula-pr: sleep for fork creation. 2018-04-08 15:37:16 -07:00
Mike McQuaidandGitHub b584e24ad1 Merge pull request #4033 from MikeMcQuaid/audit-depend-if-build-with
audit (strict): check for build.with? dependencies.
2018-04-08 22:54:07 +01:00
Mike McQuaidandGitHub af9ddfe899 Merge pull request #4035 from MikeMcQuaid/ruby-warnings
Fix HOMEBREW_RUBY_WARNINGS="-w"
2018-04-08 22:51:25 +01:00
Mike McQuaid 544dc1b0d0 audit: check for build.with? dependencies.
These don't behave as expected; depending on when and where in Homebrew
(or even an installation process) these are evaluated they return
different results. This means that sometimes these will be seen as
dependencies and sometimes they will be ignored entirely by the DSL.

Instead `:optional` or `:recommended` dependencies should be used. We
don't have a solution yet for grouping dependencies together but this is
another case for removing more optional dependencies altogether (as
there are no designs or proposed implementations).
2018-04-07 20:41:25 +01:00
Mike McQuaid 9fca172d03 Fix HOMEBREW_RUBY_WARNINGS="-w"
Fix various circular requirements, method redefinitions, etc.
2018-04-07 20:28:56 +01:00