vhad/brew
1
0
Fork 0
mirror of https://github.com/gosticks/brew.git synced 2026-08-30 05:20:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
13,489 Commits 4 Branches 271 Tags
fd5e673d2d367eff03f1411d909ca0bbb2003a2c
Commit Graph
542 Commits
Author SHA1 Message Date
Misty De Meo 87fa20076c audit: ask for full_index patches 2017-06-28 20:49:37 -07:00
Mike McQuaidandGitHub 3ce667f3b9 Merge pull request #2823 from MikeMcQuaid/test-simplify-minitest 
test: simplify minitest inclusion.
 2017-06-25 13:30:47 +01:00
Mike McQuaid c45cca8e36 test: simplify minitest inclusion. 
The previous version seems needlessly complicated given we only support
a single Ruby version. It was also blowing up on Bundler 1.15.X.
 2017-06-25 13:04:36 +01:00
Mike McQuaidandGitHub f4cdd7a051 Merge pull request #2790 from GauthamGoli/audit_legacy_patches_rubocop 
audit: Port audit_legacy_patches method to rubocop and add tests
 2017-06-25 08:54:59 +01:00
Mike McQuaidandGitHub 5f8a86c178 Merge pull request #2816 from MikeMcQuaid/test-needs-link 
test: require non-keg-only formulae to be linked.
 2017-06-24 13:30:21 +01:00
Gautham Goli 2e82754776 audit: Port audit_legacy_patches method to rubocop and add tests 2017-06-24 17:06:26 +05:30
Mike McQuaid b9e3daac70 audit: don't use Fossies as a primary URL. 
As requested in:
https://github.com/Homebrew/homebrew-core/issues/14486#issuecomment-307753234
 2017-06-23 19:34:25 +01:00
Mike McQuaid 7d5cce569d test: require non-keg-only formulae to be linked. 
This can be overridden with `--force`.

As mentioned in:
https://github.com/Homebrew/homebrew-core/pull/14525#issuecomment-307838164
 2017-06-23 17:42:09 +01:00
Gautham Goli 4d7a983415 audit: Port audit_checksum method to rubocop and add tests 2017-06-16 19:45:16 +05:30
Mike McQuaidandGitHub ed9942fbd1 Merge pull request #2769 from MikeMcQuaid/rubocop-no-perl-backrefs 
rubocop: don’t allow Perl regex backrefs.
 2017-06-12 16:47:28 +01:00
Mike McQuaidandGitHub 22c431d221 Merge pull request #2767 from MikeMcQuaid/rubocop-no-special-global-vars 
rubocop: don’t allow special global variables.
 2017-06-12 16:16:37 +01:00
Mike McQuaid 021cef4b2b Autocorrect Rubocop Style/SpecialGlobalVars. 2017-06-12 09:11:42 +01:00
Mike McQuaid 5d8b96a0c7 create: specify homebrew-core test requirements. 
As requested in https://github.com/Homebrew/homebrew-core/pull/14419.
 2017-06-10 20:27:44 +03:00
Mike McQuaid 7a0aff1080 Autocorrect Rubocop Style/PerlBackrefs. 2017-06-10 20:23:20 +03:00
Mike McQuaidandGitHub 113a7a81d0 Revert "audit: Port audit_checksum method to rubocop and add tests" 2017-06-09 11:16:11 +03:00
Gautham Goli d09d5ecc55 audit: Port audit_checksum method to rubocop and add tests 2017-06-08 21:53:46 +05:30
Mike McQuaidandGitHub 2269518768 Merge pull request #2746 from MikeMcQuaid/cleanup-tests 
tests: cleanup tests.
 2017-06-08 16:16:55 +03:00
Mike McQuaid cc8bc44286 audit: ensure curl always has an HTTP url. 
This makes using `HOMEBREW_CURL` significantly nicer as then the system
`curl` (that, on old versions, sucks at SSL) can download a version of
`curl` that it can build from source.
 2017-06-08 14:20:04 +03:00
Mike McQuaid 7d5b8a5cea tests: cleanup tests. 
Remove pending tests that are never run on CI (i.e. require `--online`),
remove fixtures for those tests and just make `--official-cmd-taps`
run by `--online` instead.
 2017-06-07 16:25:07 +01:00
Mike McQuaid 486d3d84b1 edit: tweak default editors. 
Add `atom` (not my editor of choice [TextMate for life!]) but widely
used enough to probably warrant it. Also, reorder based on my best
guestimates of current usage and cleanup the editor code while we're
here.
 2017-06-07 16:07:53 +01:00
Mike McQuaid 98959f1fb9 release-notes: fix style complaint. 2017-06-03 20:52:36 +01:00
Mike McQuaid 3a08f81470 audit: fix pypi strict audit capture group. 2017-06-03 20:25:12 +01:00
Mike McQuaid 4676e2f35a release-notes: include PR author names. 
Attribution is love.
 2017-06-03 19:06:19 +01:00
Mike McQuaidandGitHub 1d034265af Merge pull request #2726 from MikeMcQuaid/audit-pypi-urls 
audit: check pypi URLs
 2017-06-03 10:01:22 +01:00
Mike McQuaidandGitHub d6c4dfc783 Merge pull request #2725 from MikeMcQuaid/audit-formulae-options-fix 
audit: fix false negative for formulae options.
 2017-06-03 10:01:10 +01:00
Mike McQuaid cbfc83309f audit: check pypi URLs 
#373 implemented as a strict check (thanks nijikon)
 2017-06-02 22:28:07 +01:00
Mike McQuaid 6a0086a0a7 audit: fix false negative for formulae options. 
Handle the case where an if/unless is detected and then write off this
line for option handling.
 2017-06-02 22:26:37 +01:00
Markus Reiter 2d6ae61314 Re-revert "Fix operator spacing." 2017-06-02 19:22:05 +02:00
Gautham Goli cf848a14d2 audit: Port audit_caveats method to rubocop and add tests 2017-05-31 22:59:48 +05:30
Mike McQuaidandGitHub 90c971625e Merge pull request #2704 from MikeMcQuaid/jenkins-brew-sh 
Update jenkins.brew.sh links.
 2017-05-30 20:28:50 +01:00
Mike McQuaid 9032574038 Update jenkins.brew.sh links. 
These previously, incorrectly pointed to bot.brew.sh.

Fixes #2703.
 2017-05-30 19:14:40 +01:00
Gautham Goli 51f2338dd5 audit: Port audit_text method to rubocop and add tests 2017-05-30 15:28:05 +05:30
Mike McQuaid 2cbbdb51bf tests: install specific Bundler version. 
Otherwise `brew tests` fails with the latest. See the failing
Homebrew/homebrew-test-bot `master` build as an example.
 2017-05-29 20:52:17 +01:00
Mike McQuaid 7a38bab333 Fixup all RuboCop warnings. 2017-05-29 18:43:18 +01:00
Mike McQuaid 4356016b4a Use parallel RuboCop 
This requires updating to Rubocop 0.49.0 which will require some fixes
to rules, in Homebrew/brew and Homebrew/homebrew-core but opening this
for now so I remember.
 2017-05-29 18:42:02 +01:00
Mike McQuaid d7e2d5be36 update-test: tweak more edge cases. 
Don't try to `fetch --depth=1` unless we've confirmed the repository is
already shallow. Otherwise this can discard history from a full clone.

Additionally, if the repository wasn't shallow but there's no tags found
assume that Git is too old and try a naive sort if on Linux where `sort`
is able to sort versions.
 2017-05-29 15:13:08 +01:00
Mike McQuaid 224d2c21ca update-test: improve no tags found messaging. 
Currently you just get `Could not find start commit!` which is not as
explicit as it could be.
 2017-05-29 10:06:04 +01:00
JCountandGitHub dd5d4880dc Merge pull request #2658 from JCount/audit-fix-versioned-aliases-homebrew-core 
audit: fix versioned alias errors in homebrew/core introduced in a7c6a57
 2017-05-21 21:54:17 -04:00
Markus Reiter 473bdadbcd Change error messages. 2017-05-22 02:04:02 +02:00
Markus Reiter 330307b01a Use FormulaVersions for checksum check. 2017-05-22 02:01:57 +02:00
Markus Reiter ade62aa1b1 Add the same check for Formulae. 2017-05-22 02:01:57 +02:00
JCount aa81f56356 audit: fix versioned alias errors in homebrew/core introduced in a7c6a57 
This fixes #2657 which in turn were caused by an oversight in #2664
 2017-05-21 12:00:56 -04:00
Mike McQuaidandGitHub a7c6a57c8e Merge pull request #2644 from JCount/audit-fix-tap-versioned-aliases 
audit: fix full versioned alias name resolution in taps
 2017-05-20 10:57:30 +01:00
Markus ReiterandGitHub f0dc1d96c5 Merge pull request #2537 from reitermarkus/pathname-to_str 
Remove `to_s` from some `Pathname`s.
 2017-05-18 09:39:07 +02:00
JCount cd8d7a8a44 audit: fix full versioned alias name resolution in taps 
This fixes an issue where audit would prompt for the creation
of an already existing versioned alias while at the same time
declaring the existing alias invalid.
 2017-05-17 15:18:59 -04:00
Mike McQuaidandGitHub ea8be174f6 Merge pull request #2631 from GauthamGoli/audit_homepage_rubocop 
audit: Port audit_homepage method to rubocop and add tests
 2017-05-15 10:02:47 +01:00
Gautham Goli 91efcb045e Port audit_homepage method to rubocop and add tests 2017-05-14 22:05:46 +05:30
Mike McQuaidandGitHub 75d230318a Merge pull request #2627 from MikeMcQuaid/audit-fix-option-detection 
audit: fix dependency option detection.
 2017-05-14 15:09:07 +01:00
Mike McQuaid d5006ef012 audit: fix dependency option detection. 
Instead of trying to do this all with a single regex give up and do a
two stage process. Eventually I'll end up implementing a full ruby
parser here 🧌.
 2017-05-13 13:00:00 +01:00
Mike McQuaid b14f1572b7 audit: more checks for versioned aliases. 
Check that a required versioned alias has a valid name (rather than
assuming it’s fine based on it’s existence alone) and check for
the presence of invalid version aliases.

This should handle the case where someone bumps a formula but forgets
to rename the alias that’s mentioned in #2596.
 2017-05-09 15:10:29 +01:00