237 Commits
Author SHA1 Message Date
Mike McQuaid 84d1661b9a Merge pull request #1365 from MikeMcQuaid/audit-stable-url-beta
audit: check for alpha/beta/rc usage in URLs.
2016-10-25 08:17:40 -04:00
Zhiming Wang dd527bfcdc bottle: fix nonexistent pyc bug
We were deleting pyc files *after* replace_locations_with_placeholders
and recording changed_files, meaning that some of the recorded files
were to be deleted. The correct order is the opposite.

A sample failed session: https://bot.brew.sh/job/Homebrew%20Core/10080/version=el_capitan/testReport/junit/brew-test-bot/el_capitan/bottle_buku/.
2016-10-25 01:44:40 -04:00
Josh Hagins 9c519bbdbc keg_relocate: refactor relocate_text_files
Replace relocate_text_files with three methods that clarify intent:
replace_locations_with_placeholders, replace_placeholders_with_locations
and replace_text_in_files, the first two calling the third.
2016-10-24 16:21:08 -04:00
Josh Hagins c46155aba4 keg_relocate: cache files rewritten during brew bottle
`brew bottle` replaces instances of the Homebrew prefix, cellar, and
repository with placeholders in all text files. Cache these files in
INSTALL_RECEIPT.json so that we don't have to check every single text
file for placeholders on install.
2016-10-24 16:21:08 -04:00
Markus Reiter b28b21fd7f Don’t use bare percent literals. 2016-10-24 17:27:20 +02:00
Mike McQuaid b39f87e710 audit: check for alpha/beta/rc usage in URLs.
Stable URLs should not use unstable versions.
2016-10-24 14:54:28 +01:00
Josh Hagins 1d8e59b31f dev-cmd/man: use SOURCE_PATH instead of HOMEBREW_LIBRARY
Don't Repeat Yourself.
2016-10-23 01:22:56 -04:00
Mike McQuaid c521ff4a94 Merge pull request #1345 from MikeMcQuaid/rubocop-style
Update Rubocop style.
2016-10-22 15:25:28 +01:00
Mike McQuaid 22182403c5 Merge pull request #1310 from MikeMcQuaid/changelog
Add `brew release-notes` developer command.
2016-10-22 13:40:05 +01:00
Mike McQuaid 1f963267b6 Update Rubocop style.
Another look at the current Rubocop rules and how they fit with our
existing and desired future style. Almost all of these changes were
automatic. Split some rules between formulae/brew where brew doesn't
have millions of cases that need fixed.
2016-10-22 13:32:46 +01:00
Mike McQuaid 0c661f5c90 Add brew release-notes developer command.
Outputs the merged pull requests on Homebrew/brew between two Git refs.
2016-10-22 12:10:48 +01:00
Mike McQuaid 56ae868cf1 audit: don't complain about trailing whitespace.
This is handled by `brew style` now.
2016-10-18 08:11:02 +01:00
Mike McQuaid 7ac90613fd Merge pull request #1290 from maxnordlund/patch-1
Fix wrong ordering on when clauses in audit.rb
2016-10-15 17:52:54 +01:00
Max Nordlund c7fde5ddc9 Fix when clause ordering. 2016-10-15 18:31:06 +02:00
Mike McQuaid f435adc2d0 Rename tap-readme command to tap-new.
Write the README but also a `.travis.yml` file (and in future perhaps a
`Jenkinsfile`).
2016-10-15 12:32:34 +01:00
Max Nordlund d9242c540d Fix wrong ordering on when clauses in audit.rb
It looks like a rebase/merge conflict remmenet.
2016-10-14 23:05:34 +02:00
Mike McQuaid 26e4899fde Deprecate apr requirement.
It's not used on enough configurations now that there's little point in
keeping it around. See e.g. `:autoconf` for prior art.
2016-10-12 15:37:33 +01:00
Jonathan Chang 5b360c57e3 audit: forbid deprecated_option in new formulae 2016-10-05 15:59:16 -07:00
Markus Reiter cafe149780 Merge pull request #1145 from reitermarkus/module-function
Use `module_function` for `Homebrew` module.
2016-10-04 10:31:49 +02:00
Mike McQuaid ea5aff8d7c Merge pull request #1193 from MatzFan/fix_verbose_tests
fix tests failing when verbose set
2016-10-03 16:50:24 +01:00
Mike McQuaid c6f5d24238 update-test: fix tag updating, skip core tap.
Fix updating the `stable` branch used for tagged updates and ensure
that the core tap isn’t retapped (the slowest part by far of this test).
2016-10-02 17:16:35 +01:00
Markus Reiter 6201f01722 Fix Tty.gray. 2016-10-02 08:40:38 +02:00
Markus Reiter 8b06a01e5b Merge pull request #823 from reitermarkus/refactoring-tty
Refactor Tty.
2016-10-02 05:36:50 +02:00
Markus Reiter c36f42ce95 Remove private_class_method from commands. 2016-10-02 00:24:47 +02:00
Markus Reiter 0ab750bf24 Use module_function for commands. 2016-10-02 00:24:47 +02:00
Mike McQuaid fa14c26245 Merge pull request #1169 from reitermarkus/rubocop-separate-configs
Use separate RuboCop configs for formulae and core code.
2016-10-01 21:20:18 +01:00
Markus Reiter 75e8b59aad Add Formatter module. 2016-10-01 20:00:49 +02:00
Markus Reiter 6d8ee395fa Refactor Tty. 2016-10-01 20:00:49 +02:00
Mike McQuaid 009fe4fafa Merge pull request #1201 from MikeMcQuaid/update-test-to-tag
update-test: add --to-tag option.
2016-10-01 18:23:08 +01:00
Mike McQuaid 842ae5dfee update-test: add --to-tag option.
This option is used to test updating between tags.
2016-10-01 13:29:18 +01:00
Mike McQuaid 099f69e612 man: note --fail-if-changed date behaviour change.
As requested in #1199 this updates the documentation accordingly for
that change.
2016-10-01 12:19:51 +01:00
Mike McQuaid c4adc68016 man: set date when --fail-if-changed.
Set the manpage date to the existing one if we're checking for changes.
This avoids the only change being e.g. a new date.
2016-10-01 11:49:39 +01:00
Bruce Steedman 15462cc817 delete verbose env vars in brew tests 2016-10-01 09:49:06 +01:00
Steven Peters 44d13ce256 dev-cmd/man: display diff --stat, add --exit-code
The --fail-if-changed option will cause `brew man`
to return a failing status code if the man files
have changed.
2016-09-29 18:21:49 -07:00
Markus Reiter 5b2ae6885b Fix Lint/NestedMethodDefinition in dev-cmd/bottle.rb`. 2016-09-29 22:58:41 +02:00
Mike McQuaid 4488eddf91 Merge pull request #1128 from reitermarkus/rubocop
RuboCop changes.
2016-09-27 12:49:34 +01:00
ilovezfs 3811f57006 bump-formula-pr: document new options 2016-09-27 03:31:05 -07:00
ilovezfs 5247cb83d7 bump-formula-pr: style fixes 2016-09-27 03:31:04 -07:00
ilovezfs ff51e09e17 bump-formula-pr: forced_version support for devel 2016-09-27 02:50:46 -07:00
ilovezfs f4cfb9ee87 bump-formula-pr: add --write option
intended to be used in combination with --dry-run for a not-so-dry run

the expected file modifications are made, but no git actions are taken
2016-09-27 02:46:08 -07:00
ilovezfs 394b0884eb bump-formula-pr: handle gnu mirrors
and add explicit version when not preexisting
2016-09-27 02:46:08 -07:00
ilovezfs a9a62972bd bump-formula-pr: handle explicit version DSL
--version=1.2.3 option to set `version "1.2.3"`

Note that --version=0 will remove a no-longer-needed explicit version
2016-09-27 02:46:08 -07:00
ilovezfs 19df03219b bump-formula-pr: --mirror option 2016-09-27 02:46:08 -07:00
ilovezfs 743e9bbdaa bump-formula-pr: formula name guessing 2016-09-27 02:46:08 -07:00
ilovezfs ce092d90fa bump-formula-pr: set sha256 automatically when possible 2016-09-27 02:46:07 -07:00
Markus Reiter 573aea0b3d RuboCop: Style/IfUnlessModifier 2016-09-25 19:55:34 +02:00
Mike McQuaid 232078df57 Merge pull request #1123 from reitermarkus/rubocop
RuboCop: Style/AccessorMethodName
2016-09-24 20:40:00 +01:00
Mike McQuaid d5b403b1e9 test-bot: move to tap.
Migrate to https://github.com/Homebrew/homebrew-test-bot to be able to
work on this with a different, non-tagged workflow.
2016-09-24 18:55:03 +01:00
Markus Reiter 6c6a4c9fa7 RuboCop: Style/AccessorMethodName 2016-09-24 19:28:26 +02:00
Markus Reiter 58e36c7319 Fix Style/GuardClause. 2016-09-24 12:24:35 +02:00