3789 Commits
Author SHA1 Message Date
Mike McQuaid 6123cdb767 Improve Homebrew Portable Ruby messaging
As-of https://github.com/Homebrew/homebrew-portable-ruby/pull/100 we've
removed ARM builds for Portable Ruby due to months of breakage.
Similarly, when we last bumped Portable Ruby the ARM build was much
delayed but, despite Homebrew/brew being completely unusable to anyone
using it on ARM in that case, no-one complained or filed issues.

Instead of attempting to maintain and update a Portable Ruby on niche
(Homebrew) platforms like ARM (or, in past/future PPC) improve the
messaging to provide users with a workaround.

Now we allow only a major/minor version match it should be pretty
doable for those users to install e.g. a prebuilt Ruby binary from a PPA
or built it from source if needed using `ruby-build` and `rbenv`.

The messaging could be improved further but we're somewhat limited by
`ruby.sh` and `vendor-install.sh` being separate. I'm tempted to combine
them (or at least have `vendor-install.sh` not be so generic as to not
be able to give Ruby-specific advice).
2020-05-02 13:53:45 +01:00
Gautham G 38c24d134c ARGV: Deprecate ARGV.casks and replace with Homebrew.args.casks 2020-05-02 13:21:16 +05:30
Mike McQuaid fdc5096e09 Merge pull request #7461 from herder/shell_detection
[fix] Improve shell detection in shellenv
2020-04-29 10:00:12 +01:00
Niklas Herder 2f4d4b8684 [fix] Improve shell detection in shellenv
$SHELL is set to only the binary name in some environments (e.g. fish, not /usr/bin/fish), causing detection of fish/csh/tsch to fail without this change.
2020-04-29 08:20:06 +02:00
Bo Anderson 95f226cf51 cmd/list: fix Hombrew typo 2020-04-27 00:47:24 +01:00
Mike McQuaid 701c1811d5 cleanup: all configuring max age days.
Fixes #7320
2020-04-20 10:33:15 +01:00
EricFromCanada 9d6eb41fc5 cmd/dev-cmd: misc. usage and wording fixes 2020-04-19 13:31:54 -04:00
EricFromCanada b6809f2dda analytics: rearrange help into subcommand format 2020-04-19 11:50:28 -04:00
Mike McQuaid 4e5c8a35e5 cmd/upgrade: handle nil runtime_dependencies.
Fixes #7360
2020-04-15 10:52:48 +01:00
Mike McQuaid 85e65f6d9c Move some cmd to dev-cmd.
None of these made sense as end-user commands.
2020-04-14 14:29:38 +01:00
Mike McQuaid a11eacc143 cmd/gist-logs: use named DSL. 2020-04-14 14:21:53 +01:00
Mike McQuaid 4fb649cad1 cmd, dev-cmd: use args.formulae_paths.
This makes these commands robust to invalid syntax.
2020-04-14 14:21:38 +01:00
Mike McQuaid 20795b5cc7 cmd/style: do FormulaAudit by default.
Otherwise this is just doing `rubocop` checks.
2020-04-13 16:01:26 +01:00
Mike McQuaid d52e870b07 rubocop: remove NewFormulaAudit.
This is no longer used anywhere.
2020-04-13 16:01:26 +01:00
Alessandro Di Felice b752efbd37 Fix KeyOnlyReason property access. 2020-04-12 10:08:35 -05:00
Mike McQuaid 7f32e23a65 cmd/link: don't link shadowed macOS software. 2020-04-12 13:12:03 +01:00
Jonathan ChangandMike McQuaid bec303de86 tap: update shallowing logic
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-04-11 22:41:04 +10:00
Jonathan Chang 945fb11d51 tap: default to --shallow on CI 2020-04-11 13:12:09 +10:00
Jonathan Chang 2acb4771fe tap: permit creating shallow taps for CI 2020-04-09 18:46:47 +10:00
Mike McQuaid 3381cbf5c7 Use Homebrew::EnvConfig. 2020-04-07 09:58:26 +01:00
Mike McQuaid 79bc4f1136 update: make git rebase quiet on Mojave system Git.
Fix regression from https://github.com/Homebrew/brew/pull/7260.

This code makes me sad.
2020-04-03 08:59:11 +01:00
Mike McQuaid fe5717519c update: make rebase quiet.
I tested the workaround with the newest Git and the Catalina system Git
and it wasn't needed in either case. We can re-add it if we get
complaints with supported Git versions.

Fixes https://github.com/Homebrew/brew/issues/7259
2020-04-02 09:00:25 +01:00
Bo Anderson 870bae8ce6 cmd/update-report: check for HOMEBREW_DISABLE_LOAD_FORMULA 2020-03-28 22:15:07 +00:00
Charles Gould 871974650b shellenv: use PATH variable, fish_user_paths should remain universal in scope 2020-03-26 09:38:25 -05:00
Mike McQuaid 1e265247ca rubocop: apply autofixes. 2020-03-13 21:16:18 +00:00
Mike McQuaid 020d6e2843 upgrade: suggest full_name when appropriate.
Otherwise `brew install foo/bar/baz` when an older version of `baz` is
installed will tell you to run `brew upgrade baz` which won't work.
2020-03-11 17:06:42 +00:00
Mike McQuaid 60ec0881fe Merge pull request #7153 from MikeMcQuaid/uninstall-test-fix
cmd/uninstall: handle unparsed arguments.
2020-03-11 11:54:07 +00:00
Mike McQuaid 40432d86f9 cmd/uninstall: handle unparsed arguments.
If `Homebrew.args` hasn't yet been populated then `named` will return
`nil`. Instead, ensure it is an array before we try to `join` it.

This is pretty much only a test-time problem but has been causing flaky
builds.
2020-03-11 11:21:28 +00:00
EricFromCanada d068d87b1d desc: fix search options 2020-03-10 23:18:40 -04:00
EricFromCanada b75b39097d update: highlight currently-installed casks 2020-03-05 11:26:55 -05:00
Mike McQuaid a7fe0ed847 cmd: use more and cleanup new args APIs. 2020-03-05 09:40:15 +00:00
Mike McQuaid 6ead927500 cmd/search: tweak documentation text. 2020-03-04 13:14:39 +00:00
vidusheeamoli 67d012afcc search: add separate flag for formulae 2020-03-04 17:58:19 +05:30
Michelle Nguyen(she/her)andMike McQuaid 352774e80f Add deleted casks to report dump.
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-03-03 13:46:08 -05:00
Michelle Nguyen(she/her)andMike McQuaid 1f5f9b37c7 Change if statement to elsif.
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-03-03 13:45:46 -05:00
Michelle Nguyen 948ad02c84 Display updated casks when running Already up-to-date.. Fixes #7011. 2020-03-02 17:17:52 -05:00
Boris KlimenkoandBo Anderson 00aa4b7a0b Apply suggestions from code review
Co-Authored-By: Bo Anderson <mail@boanderson.me>
2020-02-26 16:49:48 +03:00
Boris KlimenkoandMike McQuaid 4bde62b651 Apply suggestions from code review
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-02-26 15:56:45 +03:00
Boris Klimenko 22375bae7c Fix style 2020-02-26 13:49:12 +03:00
Boris Klimenko da5d804bd9 Inline versions of upgraded formulae 2020-02-26 13:42:18 +03:00
Dawid Dziurla f11ddb9aab log: use user path
Without this, one can't use a custom pager, if it's present in
non-standard PATH, like for example Homebrew on Linux prefix.
2020-02-24 13:26:42 +01:00
Mike McQuaid 8f98b2bcc4 analytics: tweak behaviour.
- Use separate method for `not_this_run?` so we can still set the
  analytics message as seen when set.
- Clarify when analytics message is printed that we haven't sent any
  analytics yet.
2020-02-22 17:13:51 +00:00
Mike McQuaid e9419e48e5 tap: update docs to note non-shallow default.
Also, while we're here, `rsync` and `git` are not acronyms.
2020-02-19 10:56:44 +00:00
Mike McQuaid ac97c8545a cmd/upgrade, reinstall: don't install on dry-run.
Fixes #7033.
2020-02-14 12:18:55 +00:00
Mike McQuaid 1b2bb2380e Merge pull request #7025 from dawidd6/deps-tree-consistent
deps: give consistent results
2020-02-13 09:43:19 +00:00
Dawid DziurlaandMike McQuaid 967b9b8112 deps: give consistent results
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-02-12 22:38:20 +01:00
Mike McQuaid 59958777c1 update: allow setting Git name and email.
This is needed for `brew test-bot` when no global Git configuration is
present.
2020-02-12 20:00:14 +00:00
Samuel Cochran b922ebec2a Add --interactive to brew upgrade 2020-02-06 09:57:49 +11:00
Samuel Cochran 4c91ca06db Add --interactive to brew reinstall
More often than I realised, I want to `brew reinstall
--build-from-source --interactive $FORMULA` to add some custom
configuration. It seems like a useful addition?
2020-02-06 09:56:51 +11:00
Mike McQuaid a915114ea7 tap: fix arguments.
- Use Ruby attribute arguments.
- Fix use of `full_clone` in `cmd/tap` to be on by default.
- Remove unnecessary argument in test.
2020-02-05 20:22:21 +00:00