82 Commits
Author SHA1 Message Date
Mike McQuaid 3a91c37e66 Fix RuboCop checks. 2020-08-19 17:12:32 +01:00
William Ma a7b063efb5 named_args: Warn when cask with same name exists 2020-08-17 13:06:47 -04:00
Mike McQuaid c565a2130e Merge pull request #8332 from MLH-Fellowship/named-args
args: Move named args parsing to separate class
2020-08-17 15:15:26 +01:00
Markus Reiter 4c833b241d Fix parsing of negative options. 2020-08-14 20:03:15 +02:00
William Ma 13bc69385c args: Move named args parsing to separate class 2020-08-14 13:49:03 -04:00
Markus Reiter b48bc316e0 Use CLI::Parser for cask commands. 2020-08-13 05:15:15 +02:00
Markus Reiter 490e503b1b Replace Homebrew.args with Context. 2020-08-06 16:13:14 +02:00
Markus Reiter 9d6350037f Use try instead of send. 2020-08-06 16:13:14 +02:00
William Ma cf961caa27 caskroom: Add --caskroom command 2020-08-03 12:35:03 -04:00
Bo Anderson 5e98d4df08 cli/parser: restore env setting for global options 2020-08-01 17:36:16 +01:00
Markus Reiter 0de9eb0382 Rename split_double_dash to split_non_options. 2020-07-31 17:46:54 +02:00
Markus Reiter be2d19fe07 Refactor handling of formula options in CLI::Parser. 2020-07-31 17:46:54 +02:00
Markus Reiter 4381c32524 Add test for parsing with ignore_invalid_options. 2020-07-31 15:07:17 +02:00
Markus Reiter d4c2ffd705 Refactor CLI::Parser. 2020-07-31 15:07:17 +02:00
Markus Reiter 8d97029b03 Merge pull request #8084 from reitermarkus/cli-parser
Refactor usage of global `Homebrew.args`.
2020-07-30 11:44:12 +02:00
Mike McQuaid 4888a677c7 Merge pull request #8126 from MLH-Fellowship/integrate-deps
deps: Print cask dependencies
2020-07-30 10:20:30 +01:00
Markus Reiter 05365b5542 Pass args more explicitly in FormulaInstaller. 2020-07-30 03:21:12 +02:00
Markus Reiter c470a6ff43 Pass args directly to prevent_build_flags. 2020-07-30 03:21:12 +02:00
Markus Reiter db467497ca Fix indentation. 2020-07-30 03:21:12 +02:00
Markus Reiter 24eff8f81a Pass args in SoftwareSpec instead of using global args. 2020-07-30 03:21:12 +02:00
William Ma cc63cece76 deps: print cask dependencies
* Allow references to commands when using `brew deps`, e.g. `brew deps
cellery`
* Fix crash when using `brew deps <formula> --installed
--include-requirements`
* Do not include runtime dependencies as direct dependencies when using
`--tree`
2020-07-28 20:24:19 -04:00
Markus Reiter c0d42dd922 Remove --force from global_options. 2020-07-28 10:31:11 +02:00
Markus Reiter bf13db3367 Make Parser#parse return args. 2020-07-25 02:37:10 +02:00
Jonathan Chang 76709d82c5 Fix brew style. 2020-07-13 23:24:14 +10:00
William Ma df8d22a29b Remove debugging markers (oops) 2020-07-03 18:27:19 -04:00
William Ma 6e8f5d0958 Modify MultipleVersionsInstalledError to have a generic message 2020-07-03 18:25:49 -04:00
William Ma 525d1ac27d Fix PR issues 2020-07-03 10:33:38 -04:00
William Ma dff61c9eab style: Fix style issues 2020-06-30 12:21:21 -04:00
William Ma 8a05b5258a args: Refactor to load casks directly 2020-06-30 12:08:03 -04:00
William Ma 5900263cab args: Add resolved_formulae_and_unknowns 2020-06-24 14:53:03 -04:00
William Ma cbfea6c125 args: Add field for kegs and unknowns 2020-06-24 11:59:07 -04:00
Mike McQuaid ef95b59ed4 Remove HomebrewArgvExtension
Fixes #5730
2020-05-23 19:39:11 +01:00
Mike McQuaid e1f3c8d2b3 Merge pull request #7579 from MikeMcQuaid/deprecations
Update deprecations
2020-05-23 14:38:10 +01:00
Bo Anderson a2939be08a formula_installer: don't propagate --include-test unless requested 2020-05-19 19:12:47 +01:00
Mike McQuaid 4f75a77b08 Update deprecations
Add more deprecations, disable deprecations and remove disabled code.
2020-05-18 13:50:46 +01:00
Mike McQuaid fa0d454817 Replace ARGV#flags_only with Homebrew.args.flags_only
Take two on https://github.com/Homebrew/brew/pull/7490
2020-05-10 15:12:25 +01:00
Mike McQuaid af278b15de cli/parser: add formulae method.
This removes the coupling on args.formulae before it has been parsed.
2020-05-10 15:10:36 +01:00
Mike McQuaid 38bd4e6d10 Merge pull request #7521 from MikeMcQuaid/fix-options
cli: fix options handling.
2020-05-07 11:14:27 +01:00
Mike McQuaid c91f397605 cli: fix options handling.
Fix breaking options on taps again (second time in two weeks, sob).

To avoid doing this again: also add a test for this case (that I've
verified would have caught these cases).
2020-05-07 10:33:02 +01:00
Mike McQuaid 85a9fc4abe cli/args: cleanup weird style.
This got autofixed by RuboCop but looks weird.
2020-05-07 10:02:34 +01:00
Mike McQuaid 20a1199375 Refactor CLI to remove unless args_parsed
Refactor the CLI::Args module so it doesn't have different paths to
check arguments depending on whether the arguments have been parsed or
not. Instead, set the values we need from the global ARGV at
first, global initialisation time where they will be thrown away when
the actual arguments are parsed.

To do this some other general refactoring was needed:
- more methods made private when possible
- e.g. `HEAD?` used consistently instead of `head` before arguments
  are parsed.
- formula options are only parsed after named arguments are extracted
2020-05-05 17:47:51 +01:00
Mike McQuaid 9324a85955 cli: readability improvements.
- Rename `cmdline_args` to `argv` to make it more obvious where they
  come from.
- Make the `if args_parsed` early return into `unless args_parsed` to
  (hopefully) make it clearer that this is not the "normal" case and
  to not check `argv` unless arguments haven't been parsed.
2020-05-04 12:42:29 +01:00
Gautham G b0ac5bab31 ARGV: Deprecate ARGV.build_bottle? and replace with Homebrew.args.build_bottle 2020-04-26 13:28:44 +01:00
Gautham G 676ebf7419 ARGV: Deprecate ARGV.force_bottle? 2020-04-20 16:45:43 +01:00
Mike McQuaid af8091a279 Remove ARGV_WITHOUT_MONKEY_PATCHING
Our usage of `ARGV` will go away soon enough and maintaining state
between `ARGV` and `ARGV_WITHOUT_MONKEY_PATCHING` is futile.

Fixes #7397
2020-04-20 10:27:14 +01:00
Mike McQuaid 2bbcab5615 Merge pull request #7333 from GauthamGoli/argv-cleanup-21
cli/args: Make build_from_source public instance method
2020-04-19 13:23:34 +01:00
Mike McQuaid 8d868b739c cli/args: simplify initialisation.
Move some logic from `CLI::Parser` to `CLI::Args` to simplify and make
more consistent the initialisation process.
2020-04-18 21:14:35 +01:00
Mike McQuaid bff0a90b37 cli/args: fix formulae_paths.
The `Pathname`s don't have `name`s to `uniq`.
2020-04-15 16:27:22 +01:00
Mike McQuaid 5366da76fd cli/args: add formulae_paths helper.
This allows getting the formulae passed as arguments while not having
to read the file or raising an exception on invalid syntax.
2020-04-14 14:20:43 +01:00
Gautham G b05c72b98b cli/args: Make build_from_source public instance method 2020-04-12 19:12:16 +05:30