mirror of
https://github.com/gosticks/brew.git
synced 2026-10-06 15:36:59 +00:00
Issy Long
2c3b2f68cd
- My refactoring of #7933 went wrong in that the tests passed for `brew extract` and my manual testing, but both forgot about third-party taps exist, so that functionality broke as follows (courtesy of Misty). Before: ``` # Git.last_revision_commit_of_files("/usr/local/Homebrew", ["LICENSE.txt", "README.md"]) => ["ac0665d", ["README.md"]] ``` After: ``` # Git.last_revision_commit_of_files("/usr/local/Homebrew", ["LICENSE.txt", "README.md"]) => [nil, []] ``` - While we think about how to do splats in Sorbet, revert this so that users are able to `brew extract` from third party taps again. - A TODO for later in a separate PR is to write a test for `brew extract` that tests the behaviour of third-party taps. --- - Reverted this manually because the GitHub UI couldn't do it. - Arguably I didn't need to remove the RBI file, but it's easier to have everything gone for now and then revert this revert in future once we have a strategy for dealing with splats in Sorbet than have inconsistency.