[WEB-2365] fix: Misaligned tooltips in few components (#5486)

* fix mis-aligned tooltips in few components

* fix tooltip for kanban title
This commit is contained in:
rahulramesha 2024-09-02 15:09:55 +05:30 committed by GitHub
parent 65b9cfbfe2
commit 10c253471c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 50 additions and 11 deletions

View File

@ -30,6 +30,7 @@ interface ITooltipProps {
openDelay?: number; openDelay?: number;
closeDelay?: number; closeDelay?: number;
isMobile?: boolean; isMobile?: boolean;
renderByDefault?: boolean;
} }
export const Tooltip: React.FC<ITooltipProps> = ({ export const Tooltip: React.FC<ITooltipProps> = ({
@ -42,10 +43,11 @@ export const Tooltip: React.FC<ITooltipProps> = ({
openDelay = 200, openDelay = 200,
closeDelay, closeDelay,
isMobile = false, isMobile = false,
renderByDefault = true,
}) => { }) => {
const toolTipRef = useRef<HTMLDivElement | null>(null); const toolTipRef = useRef<HTMLDivElement | null>(null);
const [shouldRender, setShouldRender] = useState(false); const [shouldRender, setShouldRender] = useState(renderByDefault);
const onHover = () => { const onHover = () => {
setShouldRender(true); setShouldRender(true);

View File

@ -58,6 +58,7 @@ const BorderButton: React.FC<ButtonProps> = (props) => {
tooltipContent={tooltipContent} tooltipContent={tooltipContent}
disabled={!showTooltip} disabled={!showTooltip}
isMobile={isMobile} isMobile={isMobile}
renderByDefault={false}
> >
<div <div
className={cn( className={cn(
@ -81,6 +82,7 @@ const BackgroundButton: React.FC<ButtonProps> = (props) => {
tooltipContent={tooltipContent} tooltipContent={tooltipContent}
disabled={!showTooltip} disabled={!showTooltip}
isMobile={isMobile} isMobile={isMobile}
renderByDefault={false}
> >
<div <div
className={cn( className={cn(
@ -103,6 +105,7 @@ const TransparentButton: React.FC<ButtonProps> = (props) => {
tooltipContent={tooltipContent} tooltipContent={tooltipContent}
disabled={!showTooltip} disabled={!showTooltip}
isMobile={isMobile} isMobile={isMobile}
renderByDefault={false}
> >
<div <div
className={cn( className={cn(

View File

@ -102,12 +102,18 @@ const ButtonContent: React.FC<ButtonContentProps> = (props) => {
tooltipContent={moduleDetails?.name} tooltipContent={moduleDetails?.name}
disabled={!showTooltip} disabled={!showTooltip}
isMobile={isMobile} isMobile={isMobile}
renderByDefault={false}
> >
<span className="max-w-40 flex-grow truncate text-xs font-medium">{moduleDetails?.name}</span> <span className="max-w-40 flex-grow truncate text-xs font-medium">{moduleDetails?.name}</span>
</Tooltip> </Tooltip>
)} )}
{!disabled && ( {!disabled && (
<Tooltip tooltipContent="Remove" disabled={!showTooltip} isMobile={isMobile}> <Tooltip
tooltipContent="Remove"
disabled={!showTooltip}
isMobile={isMobile}
renderByDefault={false}
>
<button <button
type="button" type="button"
className="flex-shrink-0" className="flex-shrink-0"

View File

@ -76,6 +76,7 @@ const BorderButton = (props: ButtonProps) => {
tooltipContent={priorityDetails?.title ?? "None"} tooltipContent={priorityDetails?.title ?? "None"}
disabled={!showTooltip} disabled={!showTooltip}
isMobile={isMobile} isMobile={isMobile}
renderByDefault={false}
> >
<div <div
className={cn( className={cn(
@ -156,6 +157,7 @@ const BackgroundButton = (props: ButtonProps) => {
tooltipContent={priorityDetails?.title ?? "None"} tooltipContent={priorityDetails?.title ?? "None"}
disabled={!showTooltip} disabled={!showTooltip}
isMobile={isMobile} isMobile={isMobile}
renderByDefault={false}
> >
<div <div
className={cn( className={cn(
@ -237,6 +239,7 @@ const TransparentButton = (props: ButtonProps) => {
tooltipContent={priorityDetails?.title ?? "None"} tooltipContent={priorityDetails?.title ?? "None"}
disabled={!showTooltip} disabled={!showTooltip}
isMobile={isMobile} isMobile={isMobile}
renderByDefault={false}
> >
<div <div
className={cn( className={cn(

View File

@ -84,11 +84,11 @@ const KanbanIssueDetailsBlock: React.FC<IssueDetailsBlockProps> = observer((prop
</div> </div>
</WithDisplayPropertiesHOC> </WithDisplayPropertiesHOC>
<div className="w-full line-clamp-1 text-sm text-custom-text-100 mb-1.5"> <Tooltip tooltipContent={issue.name} isMobile={isMobile} renderByDefault={false}>
<Tooltip tooltipContent={issue.name} isMobile={isMobile}> <div className="w-full line-clamp-1 text-sm text-custom-text-100">
<span>{issue.name}</span> <span>{issue.name}</span>
</Tooltip> </div>
</div> </Tooltip>
<IssueProperties <IssueProperties
className="flex flex-wrap items-center gap-2 whitespace-nowrap text-custom-text-300 pt-1.5" className="flex flex-wrap items-center gap-2 whitespace-nowrap text-custom-text-300 pt-1.5"

View File

@ -171,6 +171,7 @@ export const IssueBlock = observer((props: IssueBlockProps) => {
</> </>
} }
disabled={issue.project_id === projectId} disabled={issue.project_id === projectId}
renderByDefault={false}
> >
<div className="flex-shrink-0 grid place-items-center w-3.5"> <div className="flex-shrink-0 grid place-items-center w-3.5">
<MultipleSelectEntityAction <MultipleSelectEntityAction
@ -229,6 +230,7 @@ export const IssueBlock = observer((props: IssueBlockProps) => {
isMobile={isMobile} isMobile={isMobile}
position="top-left" position="top-left"
disabled={isCurrentBlockDragging} disabled={isCurrentBlockDragging}
renderByDefault={false}
> >
<p className="truncate">{issue.name}</p> <p className="truncate">{issue.name}</p>
</Tooltip> </Tooltip>
@ -242,7 +244,7 @@ export const IssueBlock = observer((props: IssueBlockProps) => {
className="w-full truncate cursor-pointer text-sm text-custom-text-100" className="w-full truncate cursor-pointer text-sm text-custom-text-100"
disabled={!!issue?.tempId} disabled={!!issue?.tempId}
> >
<Tooltip tooltipContent={issue.name} isMobile={isMobile} position="top-left"> <Tooltip tooltipContent={issue.name} isMobile={isMobile} position="top-left" renderByDefault={false}>
<p className="truncate">{issue.name}</p> <p className="truncate">{issue.name}</p>
</Tooltip> </Tooltip>
</ControlLink> </ControlLink>

View File

@ -437,7 +437,12 @@ export const IssueProperties: React.FC<IIssueProperties> = observer((props) => {
displayPropertyKey="sub_issue_count" displayPropertyKey="sub_issue_count"
shouldRenderProperty={(properties) => !!properties.sub_issue_count && !!subIssueCount} shouldRenderProperty={(properties) => !!properties.sub_issue_count && !!subIssueCount}
> >
<Tooltip tooltipHeading="Sub-issues" tooltipContent={`${subIssueCount}`} isMobile={isMobile}> <Tooltip
tooltipHeading="Sub-issues"
tooltipContent={`${subIssueCount}`}
isMobile={isMobile}
renderByDefault={false}
>
<div <div
onClick={(e) => { onClick={(e) => {
e.stopPropagation(); e.stopPropagation();
@ -463,7 +468,12 @@ export const IssueProperties: React.FC<IIssueProperties> = observer((props) => {
displayPropertyKey="attachment_count" displayPropertyKey="attachment_count"
shouldRenderProperty={(properties) => !!properties.attachment_count && !!issue.attachment_count} shouldRenderProperty={(properties) => !!properties.attachment_count && !!issue.attachment_count}
> >
<Tooltip tooltipHeading="Attachments" tooltipContent={`${issue.attachment_count}`} isMobile={isMobile}> <Tooltip
tooltipHeading="Attachments"
tooltipContent={`${issue.attachment_count}`}
isMobile={isMobile}
renderByDefault={false}
>
<div <div
className="flex h-5 flex-shrink-0 items-center justify-center gap-2 overflow-hidden rounded border-[0.5px] border-custom-border-300 px-2.5 py-1" className="flex h-5 flex-shrink-0 items-center justify-center gap-2 overflow-hidden rounded border-[0.5px] border-custom-border-300 px-2.5 py-1"
onClick={handleEventPropagation} onClick={handleEventPropagation}
@ -480,7 +490,12 @@ export const IssueProperties: React.FC<IIssueProperties> = observer((props) => {
displayPropertyKey="link" displayPropertyKey="link"
shouldRenderProperty={(properties) => !!properties.link && !!issue.link_count} shouldRenderProperty={(properties) => !!properties.link && !!issue.link_count}
> >
<Tooltip tooltipHeading="Links" tooltipContent={`${issue.link_count}`} isMobile={isMobile}> <Tooltip
tooltipHeading="Links"
tooltipContent={`${issue.link_count}`}
isMobile={isMobile}
renderByDefault={false}
>
<div <div
className="flex h-5 flex-shrink-0 items-center justify-center gap-2 overflow-hidden rounded border-[0.5px] border-custom-border-300 px-2.5 py-1" className="flex h-5 flex-shrink-0 items-center justify-center gap-2 overflow-hidden rounded border-[0.5px] border-custom-border-300 px-2.5 py-1"
onClick={handleEventPropagation} onClick={handleEventPropagation}

View File

@ -162,6 +162,7 @@ export const IssuePropertyLabels: React.FC<IIssuePropertyLabels> = observer((pro
tooltipHeading="Labels" tooltipHeading="Labels"
tooltipContent={label?.name ?? ""} tooltipContent={label?.name ?? ""}
isMobile={isMobile} isMobile={isMobile}
renderByDefault={false}
> >
<div <div
key={label?.id} key={label?.id}
@ -196,6 +197,7 @@ export const IssuePropertyLabels: React.FC<IIssuePropertyLabels> = observer((pro
?.filter((l) => value.includes(l?.id)) ?.filter((l) => value.includes(l?.id))
.map((l) => l?.name) .map((l) => l?.name)
.join(", ")} .join(", ")}
renderByDefault={false}
> >
<div className="flex h-full items-center gap-1.5 text-custom-text-200"> <div className="flex h-full items-center gap-1.5 text-custom-text-200">
<span className="h-2 w-2 flex-shrink-0 rounded-full bg-custom-primary" /> <span className="h-2 w-2 flex-shrink-0 rounded-full bg-custom-primary" />
@ -205,7 +207,13 @@ export const IssuePropertyLabels: React.FC<IIssuePropertyLabels> = observer((pro
</div> </div>
) )
) : ( ) : (
<Tooltip position="top" tooltipHeading="Labels" tooltipContent="None" isMobile={isMobile}> <Tooltip
position="top"
tooltipHeading="Labels"
tooltipContent="None"
isMobile={isMobile}
renderByDefault={false}
>
<div <div
className={`flex h-full items-center justify-center gap-2 rounded px-2.5 py-1 text-xs hover:bg-custom-background-80 ${ className={`flex h-full items-center justify-center gap-2 rounded px-2.5 py-1 text-xs hover:bg-custom-background-80 ${
noLabelBorder ? "" : "border-[0.5px] border-custom-border-300" noLabelBorder ? "" : "border-[0.5px] border-custom-border-300"