From 73e8701bde7fa216a1e0683941316ddf9e056176 Mon Sep 17 00:00:00 2001 From: SmaranSingh <45625831+SmaranSingh@users.noreply.github.com> Date: Thu, 4 Apr 2019 15:37:34 +0530 Subject: [PATCH 1/2] Update select.js --- .../src/components/select.js | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/packages/react-bootstrap-table2-filter/src/components/select.js b/packages/react-bootstrap-table2-filter/src/components/select.js index 973bdb3..66384b3 100644 --- a/packages/react-bootstrap-table2-filter/src/components/select.js +++ b/packages/react-bootstrap-table2-filter/src/components/select.js @@ -8,15 +8,19 @@ import { FILTER_TYPE } from '../const'; function optionsEquals(currOpts, prevOpts) { if (Array.isArray(currOpts)) { - for (let i = 0; i < currOpts.length; i += 1) { - if ( - currOpts[i].value !== prevOpts[i].value || - currOpts[i].label !== prevOpts[i].label - ) { - return false; + if (currOpts.length === prevOpts.length) { + for (let i = 0; i < currOpts.length; i += 1) { + if ( + currOpts[i].value !== prevOpts[i].value || + currOpts[i].label !== prevOpts[i].label + ) { + return false; + } } + return true; + } else { + return false; } - return currOpts.length === prevOpts.length; } const keys = Object.keys(currOpts); for (let i = 0; i < keys.length; i += 1) { From 3606fa3b7baebe8c198bd0be80baf2a87408b2a7 Mon Sep 17 00:00:00 2001 From: SmaranSingh <45625831+SmaranSingh@users.noreply.github.com> Date: Thu, 4 Apr 2019 16:11:01 +0530 Subject: [PATCH 2/2] Update select.js --- .../react-bootstrap-table2-filter/src/components/select.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/react-bootstrap-table2-filter/src/components/select.js b/packages/react-bootstrap-table2-filter/src/components/select.js index 66384b3..36d3e6d 100644 --- a/packages/react-bootstrap-table2-filter/src/components/select.js +++ b/packages/react-bootstrap-table2-filter/src/components/select.js @@ -17,10 +17,8 @@ function optionsEquals(currOpts, prevOpts) { return false; } } - return true; - } else { - return false; } + return currOpts.length === prevOpts.length; } const keys = Object.keys(currOpts); for (let i = 0; i < keys.length; i += 1) {