diff --git a/package.json b/package.json index ae5416b..8830bfa 100644 --- a/package.json +++ b/package.json @@ -52,6 +52,7 @@ "css-loader": "0.28.1", "enzyme": "3.3.0", "enzyme-adapter-react-16": "1.1.1", + "enzyme-to-json": "^3.3.4", "eslint": "4.5.0", "eslint-config-airbnb": "15.1.0", "eslint-loader": "1.9.0", diff --git a/packages/react-bootstrap-table2/src/row-selection/selection-cell.js b/packages/react-bootstrap-table2/src/row-selection/selection-cell.js index e7571a2..cdd6bbd 100644 --- a/packages/react-bootstrap-table2/src/row-selection/selection-cell.js +++ b/packages/react-bootstrap-table2/src/row-selection/selection-cell.js @@ -75,6 +75,7 @@ export default class SelectionCell extends Component { checked={ selected } disabled={ disabled } className={ bootstrap4 ? 'selection-input-4' : '' } + onChange={ () => {} } /> ) } diff --git a/packages/react-bootstrap-table2/src/row-selection/selection-header-cell.js b/packages/react-bootstrap-table2/src/row-selection/selection-header-cell.js index 169740f..3658e0a 100644 --- a/packages/react-bootstrap-table2/src/row-selection/selection-header-cell.js +++ b/packages/react-bootstrap-table2/src/row-selection/selection-header-cell.js @@ -12,6 +12,7 @@ export const CheckBox = ({ className, checked, indeterminate }) => ( ref={ (input) => { if (input) input.indeterminate = indeterminate; // eslint-disable-line no-param-reassign } } + onChange={ () => {} } /> ); diff --git a/packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-cell.test.js.snap b/packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-cell.test.js.snap new file mode 100644 index 0000000..2f5e4dc --- /dev/null +++ b/packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-cell.test.js.snap @@ -0,0 +1,14 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[` render should render component correctly 1`] = ` + + + +`; diff --git a/packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-header-cell.test.js.snap b/packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-header-cell.test.js.snap new file mode 100644 index 0000000..522b3e5 --- /dev/null +++ b/packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-header-cell.test.js.snap @@ -0,0 +1,9 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[` render should render component correctly 1`] = ` + +`; diff --git a/packages/react-bootstrap-table2/test/row-selection/selection-cell.test.js b/packages/react-bootstrap-table2/test/row-selection/selection-cell.test.js index d3c9eac..311c361 100644 --- a/packages/react-bootstrap-table2/test/row-selection/selection-cell.test.js +++ b/packages/react-bootstrap-table2/test/row-selection/selection-cell.test.js @@ -1,6 +1,7 @@ import 'jsdom-global/register'; import React from 'react'; import { shallow } from 'enzyme'; +import toJson from 'enzyme-to-json'; import sinon from 'sinon'; import { shallowWithContext } from '../test-helpers/new-context'; @@ -61,7 +62,8 @@ describe('', () => { mode={ mode } rowIndex={ rowIndex } onRowSelect={ mockOnRowSelect } - />, { bootstrap4: false } + />, + { bootstrap4: false } ); wrapper.find('td').simulate('click'); }); @@ -72,9 +74,7 @@ describe('', () => { it('should calling onRowSelect callback correctly', () => { expect(mockOnRowSelect.calledOnce).toBe(true); - expect( - mockOnRowSelect.calledWith(rowKey, !selected, rowIndex) - ).toBe(true); + expect(mockOnRowSelect.calledWith(rowKey, !selected, rowIndex)).toBe(true); }); }); @@ -88,7 +88,8 @@ describe('', () => { rowIndex={ rowIndex } onRowSelect={ mockOnRowSelect } disabled - />, { bootstrap4: false } + />, + { bootstrap4: false } ); wrapper.find('td').simulate('click'); }); @@ -111,7 +112,8 @@ describe('', () => { mode="radio" rowIndex={ rowIndex } onRowSelect={ mockOnRowSelect } - />, { bootstrap4: false } + />, + { bootstrap4: false } ); }); @@ -132,11 +134,12 @@ describe('', () => { rowIndex={ rowIndex } selected onRowSelect={ mockOnRowSelect } - />, { bootstrap4: false } + />, + { bootstrap4: false } ); }); - it('should be called with correct paramters', () => { + it('should be called with correct parameters', () => { // first click wrapper.find('td').simulate('click'); expect(mockOnRowSelect.callCount).toBe(1); @@ -151,12 +154,8 @@ describe('', () => { beforeEach(() => { wrapper = shallowWithContext( - , { bootstrap4: false } + , + { bootstrap4: false } ); }); @@ -165,6 +164,7 @@ describe('', () => { expect(wrapper.find('input')).toHaveLength(1); expect(wrapper.find('input').get(0).props.type).toBe(mode); expect(wrapper.find('input').get(0).props.checked).toBe(selected); + expect(toJson(wrapper)).toMatchSnapshot(); }); describe('when disabled prop give as true', () => { @@ -176,7 +176,8 @@ describe('', () => { rowIndex={ rowIndex } selected={ selected } disabled - />, { bootstrap4: false } + />, + { bootstrap4: false } ); }); @@ -198,7 +199,8 @@ describe('', () => { rowIndex={ rowIndex } selected={ selected } selectionRenderer={ selectionRenderer } - />, { bootstrap4: false } + />, + { bootstrap4: false } ); }); @@ -219,12 +221,8 @@ describe('', () => { describe('when bootstrap4 context is true', () => { beforeEach(() => { wrapper = shallowWithContext( - , { bootstrap4: true } + , + { bootstrap4: true } ); }); diff --git a/packages/react-bootstrap-table2/test/row-selection/selection-header-cell.test.js b/packages/react-bootstrap-table2/test/row-selection/selection-header-cell.test.js index 4423dbf..be9a519 100644 --- a/packages/react-bootstrap-table2/test/row-selection/selection-header-cell.test.js +++ b/packages/react-bootstrap-table2/test/row-selection/selection-header-cell.test.js @@ -1,5 +1,6 @@ import React from 'react'; import { shallow } from 'enzyme'; +import toJson from 'enzyme-to-json'; import sinon from 'sinon'; import { shallowWithContext } from '../test-helpers/new-context'; @@ -201,6 +202,7 @@ describe('', () => { expect(wrapper.find('input').length).toBe(1); expect(wrapper.find('input').prop('checked')).toBe(checked); expect(wrapper.find('input').prop('type')).toBe('checkbox'); + expect(toJson(wrapper)).toMatchSnapshot(); }); }); });