From 41dc3ef6191e9f6d7528fffdb1a125a202c64dc0 Mon Sep 17 00:00:00 2001
From: Patrick O'Meara <pat@fixd.io>
Date: Sun, 1 Apr 2018 15:32:24 +1000
Subject: [PATCH] empty noDataIndication when empty (#275)

* don't display unneeded empty row when noDataIndication isn't set
---
 packages/react-bootstrap-table2/src/body.js       | 3 +++
 packages/react-bootstrap-table2/test/body.test.js | 8 +++-----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/packages/react-bootstrap-table2/src/body.js b/packages/react-bootstrap-table2/src/body.js
index 9ee9e89..b4ca400 100644
--- a/packages/react-bootstrap-table2/src/body.js
+++ b/packages/react-bootstrap-table2/src/body.js
@@ -35,6 +35,9 @@ const Body = (props) => {
 
   if (isEmpty) {
     const indication = _.isFunction(noDataIndication) ? noDataIndication() : noDataIndication;
+    if (!indication) {
+      return null;
+    }
     content = <RowSection content={ indication } colSpan={ visibleColumnSize } />;
   } else {
     const nonEditableRows = cellEdit.nonEditableRows || [];
diff --git a/packages/react-bootstrap-table2/test/body.test.js b/packages/react-bootstrap-table2/test/body.test.js
index 5674b83..ea624e5 100644
--- a/packages/react-bootstrap-table2/test/body.test.js
+++ b/packages/react-bootstrap-table2/test/body.test.js
@@ -53,12 +53,10 @@ describe('Body', () => {
         />);
     });
 
-    it('should render successfully', () => {
+    it('should not render', () => {
       expect(wrapper.length).toBe(1);
-      expect(wrapper.find('tbody').length).toBe(1);
-      expect(wrapper.find(RowSection).length).toBe(1);
-      expect(wrapper.find(RowSection).prop('colSpan')).toBe(columns.length);
-      expect(wrapper.find(RowSection).prop('content')).toBe(null);
+      expect(wrapper.find('tbody').length).toBe(0);
+      expect(wrapper.find(RowSection).length).toBe(0);
     });
 
     describe('when noDataIndication props is defined', () => {