From f35d644608b0e8eb1642984b467e5be6c69d5cf3 Mon Sep 17 00:00:00 2001 From: Jeremy Nagel Date: Mon, 16 Jul 2018 11:18:02 +1000 Subject: [PATCH 1/3] [BUGFIX] Fix issue with missing onChange prop for selection checkbox --- .../src/row-selection/selection-header-cell.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-bootstrap-table2/src/row-selection/selection-header-cell.js b/packages/react-bootstrap-table2/src/row-selection/selection-header-cell.js index 9879026..c92e7c3 100644 --- a/packages/react-bootstrap-table2/src/row-selection/selection-header-cell.js +++ b/packages/react-bootstrap-table2/src/row-selection/selection-header-cell.js @@ -77,6 +77,7 @@ export default class SelectionHeaderCell extends Component { { ...this.props } checked={ checked } indeterminate={ indeterminate } + onChange={ this.handleCheckBoxClick } /> ); attrs.onClick = this.handleCheckBoxClick; From 96d33a60ba14874ae6fb5592be50962a15bd2d5c Mon Sep 17 00:00:00 2001 From: Jeremy Nagel Date: Mon, 13 Aug 2018 16:50:43 +1000 Subject: [PATCH 2/3] Add snapshot tests --- .../__snapshots__/selection-cell.test.js.snap | 14 ++++++++++++++ .../selection-header-cell.test.js.snap | 9 +++++++++ .../test/row-selection/selection-cell.test.js | 8 +++++++- 3 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-cell.test.js.snap create mode 100644 packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-header-cell.test.js.snap diff --git a/packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-cell.test.js.snap b/packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-cell.test.js.snap new file mode 100644 index 0000000..2f5e4dc --- /dev/null +++ b/packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-cell.test.js.snap @@ -0,0 +1,14 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[` render should render component correctly 1`] = ` + + + +`; diff --git a/packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-header-cell.test.js.snap b/packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-header-cell.test.js.snap new file mode 100644 index 0000000..522b3e5 --- /dev/null +++ b/packages/react-bootstrap-table2/test/row-selection/__snapshots__/selection-header-cell.test.js.snap @@ -0,0 +1,9 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[` render should render component correctly 1`] = ` + +`; diff --git a/packages/react-bootstrap-table2/test/row-selection/selection-cell.test.js b/packages/react-bootstrap-table2/test/row-selection/selection-cell.test.js index 967c626..311c361 100644 --- a/packages/react-bootstrap-table2/test/row-selection/selection-cell.test.js +++ b/packages/react-bootstrap-table2/test/row-selection/selection-cell.test.js @@ -170,7 +170,13 @@ describe('', () => { describe('when disabled prop give as true', () => { beforeEach(() => { wrapper = shallowWithContext( - , + , { bootstrap4: false } ); }); From 28249c9089b06309726c4ebb165b3f9592fdd19e Mon Sep 17 00:00:00 2001 From: AllenFang Date: Mon, 20 Aug 2018 23:36:22 +0800 Subject: [PATCH 3/3] fixed version --- package.json | 2 +- yarn.lock | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 8830bfa..4437f6e 100644 --- a/package.json +++ b/package.json @@ -52,7 +52,7 @@ "css-loader": "0.28.1", "enzyme": "3.3.0", "enzyme-adapter-react-16": "1.1.1", - "enzyme-to-json": "^3.3.4", + "enzyme-to-json": "3.3.4", "eslint": "4.5.0", "eslint-config-airbnb": "15.1.0", "eslint-loader": "1.9.0", diff --git a/yarn.lock b/yarn.lock index 4329d62..b44934f 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2711,6 +2711,12 @@ enzyme-adapter-utils@^1.3.0: object.assign "^4.1.0" prop-types "^15.6.0" +enzyme-to-json@3.3.4: + version "3.3.4" + resolved "https://registry.yarnpkg.com/enzyme-to-json/-/enzyme-to-json-3.3.4.tgz#67c6040e931182f183418af2eb9f4323258aa77f" + dependencies: + lodash "^4.17.4" + enzyme@3.3.0: version "3.3.0" resolved "https://registry.yarnpkg.com/enzyme/-/enzyme-3.3.0.tgz#0971abd167f2d4bf3f5bd508229e1c4b6dc50479"