From 6482869e8a3896855419e0b81725bccd571789ea Mon Sep 17 00:00:00 2001 From: Tanner Linsley Date: Tue, 10 Mar 2020 12:05:13 -0600 Subject: [PATCH] Fix possible empty page options --- src/plugin-hooks/tests/usePagination.test.js | 2 +- src/plugin-hooks/usePagination.js | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/plugin-hooks/tests/usePagination.test.js b/src/plugin-hooks/tests/usePagination.test.js index a467bf1..56aae85 100644 --- a/src/plugin-hooks/tests/usePagination.test.js +++ b/src/plugin-hooks/tests/usePagination.test.js @@ -5,7 +5,7 @@ import { useTable } from '../../hooks/useTable' import { usePagination } from '../usePagination' import { useFilters } from '../useFilters' -const data = [...new Array(1000)].map((d, i) => ({ +const data = [...new Array(1000)].fill(null).map((d, i) => ({ firstName: `tanner ${i + 1}`, lastName: 'linsley', age: 29, diff --git a/src/plugin-hooks/usePagination.js b/src/plugin-hooks/usePagination.js index 8a9e4bb..735f108 100755 --- a/src/plugin-hooks/usePagination.js +++ b/src/plugin-hooks/usePagination.js @@ -117,7 +117,10 @@ function useInstance(instance) { : Math.ceil(rows.length / pageSize) const pageOptions = React.useMemo( - () => (pageCount > 0 ? [...new Array(pageCount)].map((d, i) => i) : []), + () => + pageCount > 0 + ? [...new Array(pageCount)].fill(null).map((d, i) => i) + : [], [pageCount] )