vhad/react-table
1
0
Fork 0
mirror of https://github.com/gosticks/react-table.git synced 2025-10-16 11:55:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

useTable: Fixes memoizing of headerGroups (#1920)

Browse Source 
Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com>
This commit is contained in:
Roman Komarov 2020-02-21 15:04:41 +01:00 committed by GitHub
parent 7498059e98
commit 73ed7efbe6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 34 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
src/hooks/useTable.js
View File

@ -380,40 +380,42 @@ export const useTable = (props, ...plugins) => {
}
)
getInstance().headerGroups = getInstance().headerGroups.filter(
(headerGroup, i) => {
// Filter out any headers and headerGroups that don't have visible columns
headerGroup.headers = headerGroup.headers.filter(column => {
const recurse = headers =>
headers.filter(column => {
if (column.headers) {
return recurse(column.headers)
}
return column.isVisible
}).length
if (column.headers) {
return recurse(column.headers)
getInstance().headerGroups = React.useMemo(
() =>
headerGroups.filter((headerGroup, i) => {
// Filter out any headers and headerGroups that don't have visible columns
headerGroup.headers = headerGroup.headers.filter(column => {
const recurse = headers =>
headers.filter(column => {
if (column.headers) {
return recurse(column.headers)
}
return column.isVisible
}).length
if (column.headers) {
return recurse(column.headers)
}
return column.isVisible
})
// Give headerGroups getRowProps
if (headerGroup.headers.length) {
headerGroup.getHeaderGroupProps = makePropGetter(
getHooks().getHeaderGroupProps,
{ instance: getInstance(), headerGroup, index: i }
)
headerGroup.getFooterGroupProps = makePropGetter(
getHooks().getFooterGroupProps,
{ instance: getInstance(), headerGroup, index: i }
)
return true
}
return column.isVisible
})
// Give headerGroups getRowProps
if (headerGroup.headers.length) {
headerGroup.getHeaderGroupProps = makePropGetter(
getHooks().getHeaderGroupProps,
{ instance: getInstance(), headerGroup, index: i }
)
headerGroup.getFooterGroupProps = makePropGetter(
getHooks().getFooterGroupProps,
{ instance: getInstance(), headerGroup, index: i }
)
return true
}
return false
}
return false
}),
[headerGroups, getInstance, getHooks]
)
getInstance().footerGroups = [...getInstance().headerGroups].reverse()