From a6036004afba997114c20daa0c6ae4b319b2e679 Mon Sep 17 00:00:00 2001 From: Will Olson Date: Wed, 22 Nov 2017 09:07:26 -0800 Subject: [PATCH] refactor: Fix defaultProps.js linter errors --- src/defaultProps.js | 36 ++++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/src/defaultProps.js b/src/defaultProps.js index 46f8962..b618c3e 100644 --- a/src/defaultProps.js +++ b/src/defaultProps.js @@ -29,12 +29,14 @@ export default { defaultFiltered: [], defaultResized: [], defaultExpanded: {}, + // eslint-disable-next-line no-unused-vars defaultFilterMethod: (filter, row, column) => { const id = filter.pivotId || filter.id return row[id] !== undefined ? String(row[id]).startsWith(filter.value) : true }, + // eslint-disable-next-line no-unused-vars defaultSortMethod: (a, b, desc) => { // force null and undefined to the bottom a = a === null || a === undefined ? '' : a @@ -49,7 +51,8 @@ export default { if (a < b) { return -1 } - // returning 0, undefined or any falsey value will use subsequent sorts or the index as a tiebreaker + // returning 0, undefined or any falsey value will use subsequent sorts or + // the index as a tiebreaker return 0 }, @@ -176,24 +179,24 @@ export default { TbodyComponent: _.makeTemplateComponent('rt-tbody', 'Tbody'), TrGroupComponent: _.makeTemplateComponent('rt-tr-group', 'TrGroup'), TrComponent: _.makeTemplateComponent('rt-tr', 'Tr'), - ThComponent: ({ toggleSort, className, children, ...rest }) => { - return ( -
{ - toggleSort && toggleSort(e) - }} - {...rest} - > - {children} -
- ) - }, + ThComponent: ({ toggleSort, className, children, ...rest }) => ( +
( + toggleSort && toggleSort(e) + )} + role="button" + tabIndex={0} + {...rest} + > + {children} +
+ ), TdComponent: _.makeTemplateComponent('rt-td', 'Td'), TfootComponent: _.makeTemplateComponent('rt-tfoot', 'Tfoot'), FilterComponent: ({ filter, onChange }) => ( typeof d[column.id] !== 'undefined') .map((row, i) => ( + // eslint-disable-next-line react/no-array-index-key {row[column.id]} {i < subRows.length - 1 ? ', ' : ''} @@ -236,7 +240,7 @@ export default { className={classnames('-loading', { '-active': loading }, className)} {...rest} > -
+
{loadingText}