From 7fddc47d4464c8f62d17686d39767826127f57d7 Mon Sep 17 00:00:00 2001 From: Mcat12 Date: Fri, 26 Oct 2018 01:30:20 -0400 Subject: [PATCH 1/2] Don't handle empty input in DomainInput The test was broken when the component changed to use a form, because simply clicking the button didn't activate the handler. Signed-off-by: Mcat12 --- src/components/list/DomainInput.js | 6 ++++++ src/components/list/DomainInput.test.js | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/components/list/DomainInput.js b/src/components/list/DomainInput.js index c6c1d9b..7a5d8fd 100644 --- a/src/components/list/DomainInput.js +++ b/src/components/list/DomainInput.js @@ -25,6 +25,12 @@ class DomainInput extends Component { e.preventDefault(); const domain = this.state.domain; + + // Don't do anything for empty inputs + if(domain.length === 0) { + return; + } + const isValid = this.props.isValid(domain); this.setState({ isValid }); if (isValid) { diff --git a/src/components/list/DomainInput.test.js b/src/components/list/DomainInput.test.js index 57a90b3..052c914 100644 --- a/src/components/list/DomainInput.test.js +++ b/src/components/list/DomainInput.test.js @@ -128,15 +128,15 @@ it("does not call onEnter when input is empty", () => { true} onValidationError={jest.fn()} /> ); wrapper - .find("button") + .find("form") .first() - .simulate("click"); + .simulate("submit", { preventDefault: jest.fn() }); expect(onEnter).not.toHaveBeenCalled(); }); From 438e8bf890afb9bbc6842273929e346108b02a02 Mon Sep 17 00:00:00 2001 From: Mcat12 Date: Fri, 26 Oct 2018 01:31:24 -0400 Subject: [PATCH 2/2] Reformat DomainInput Signed-off-by: Mcat12 --- src/components/list/DomainInput.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/list/DomainInput.js b/src/components/list/DomainInput.js index 7a5d8fd..cbe1d4d 100644 --- a/src/components/list/DomainInput.js +++ b/src/components/list/DomainInput.js @@ -27,7 +27,7 @@ class DomainInput extends Component { const domain = this.state.domain; // Don't do anything for empty inputs - if(domain.length === 0) { + if (domain.length === 0) { return; }