From 001528df12d47bd817a399e47ee3da46c4396fdb Mon Sep 17 00:00:00 2001 From: Jorge Costa Date: Fri, 4 Nov 2022 18:22:17 +0000 Subject: [PATCH] Fix: Category specific templates always appear as not found. According to the docs in developer.wordpress.org/reference/classes/wp_term_query/query WP_Term_Query:->query( string|array $query ) returns WP_Term[]|int[]|string[]|string, and we were using an inexistent object property terms making it always empty and look like the taxonomy did not exist. Props mamaduka, mikachan, ockham, franz00. See #56902. git-svn-id: https://develop.svn.wordpress.org/trunk@54751 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/block-template-utils.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/wp-includes/block-template-utils.php b/src/wp-includes/block-template-utils.php index 5db20bf08c..3cdcb19ceb 100644 --- a/src/wp-includes/block-template-utils.php +++ b/src/wp-includes/block-template-utils.php @@ -637,7 +637,7 @@ function _wp_build_title_and_description_for_taxonomy_block_template( $taxonomy, $args = wp_parse_args( $args, $default_args ); $terms_query = $term_query->query( $args ); - if ( empty( $terms_query->terms ) ) { + if ( empty( $terms_query ) ) { $template->title = sprintf( /* translators: Custom template title in the Site Editor, referencing a taxonomy term that was not found. 1: Taxonomy singular name, 2: Term slug. */ __( 'Not found: %1$s (%2$s)' ), @@ -647,7 +647,7 @@ function _wp_build_title_and_description_for_taxonomy_block_template( $taxonomy, return false; } - $term_title = $terms_query->terms[0]->name; + $term_title = $terms_query[0]->name; $template->title = sprintf( /* translators: Custom template title in the Site Editor. 1: Taxonomy singular name, 2: Term title. */ @@ -671,7 +671,7 @@ function _wp_build_title_and_description_for_taxonomy_block_template( $taxonomy, $args = wp_parse_args( $args, $default_args ); $terms_with_same_title_query = $term_query->query( $args ); - if ( count( $terms_with_same_title_query->terms ) > 1 ) { + if ( count( $terms_with_same_title_query ) > 1 ) { $template->title = sprintf( /* translators: Custom template title in the Site Editor. 1: Template title, 2: Term slug. */ __( '%1$s (%2$s)' ),