From 042aeb58a0b6f89c065cd7527b7ed890a550407d Mon Sep 17 00:00:00 2001 From: Jb Audras Date: Wed, 21 Jun 2023 07:56:06 +0000 Subject: [PATCH] Twenty Nineteen: Always set background color and foreground color together. On the `` element, as a best practice background color and text color should always be set together. This makes it easier to quickly understand the underlying color scheme. Props allancole, joyously, samful, sabernhardt, oglekler, ronakganatra, tb1909, ugyensupport. Fixes #45916. git-svn-id: https://develop.svn.wordpress.org/trunk@55960 602fd350-edb4-49c9-b593-d223f7449a82 --- .../themes/twentynineteen/sass/elements/_elements.scss | 1 + .../themes/twentynineteen/sass/typography/_typography.scss | 1 + src/wp-content/themes/twentynineteen/style-rtl.css | 2 +- src/wp-content/themes/twentynineteen/style.css | 2 +- 4 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/wp-content/themes/twentynineteen/sass/elements/_elements.scss b/src/wp-content/themes/twentynineteen/sass/elements/_elements.scss index edc11cdf91..0eb7c5b1c8 100644 --- a/src/wp-content/themes/twentynineteen/sass/elements/_elements.scss +++ b/src/wp-content/themes/twentynineteen/sass/elements/_elements.scss @@ -18,6 +18,7 @@ html { body { background-color: $color__background-body; + color: $color__text-main; } a { diff --git a/src/wp-content/themes/twentynineteen/sass/typography/_typography.scss b/src/wp-content/themes/twentynineteen/sass/typography/_typography.scss index 055b7a63d4..84438b2efa 100644 --- a/src/wp-content/themes/twentynineteen/sass/typography/_typography.scss +++ b/src/wp-content/themes/twentynineteen/sass/typography/_typography.scss @@ -6,6 +6,7 @@ html { body { -webkit-font-smoothing: antialiased; -moz-osx-font-smoothing: grayscale; + background-color: $color__background-body; color: $color__text-main; @include font-family( $font__body ); font-weight: 400; diff --git a/src/wp-content/themes/twentynineteen/style-rtl.css b/src/wp-content/themes/twentynineteen/style-rtl.css index cab1ba0dcc..d5c4ffa8bb 100644 --- a/src/wp-content/themes/twentynineteen/style-rtl.css +++ b/src/wp-content/themes/twentynineteen/style-rtl.css @@ -2219,7 +2219,6 @@ html { body { -webkit-font-smoothing: antialiased; -moz-osx-font-smoothing: grayscale; - color: #111; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: 400; font-size: 1em; @@ -2495,6 +2494,7 @@ html { body { background-color: #fff; + color: #111; } a { diff --git a/src/wp-content/themes/twentynineteen/style.css b/src/wp-content/themes/twentynineteen/style.css index e43f6647c7..61ca22b3ae 100644 --- a/src/wp-content/themes/twentynineteen/style.css +++ b/src/wp-content/themes/twentynineteen/style.css @@ -2219,7 +2219,6 @@ html { body { -webkit-font-smoothing: antialiased; -moz-osx-font-smoothing: grayscale; - color: #111; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: 400; font-size: 1em; @@ -2495,6 +2494,7 @@ html { body { background-color: #fff; + color: #111; } a {