Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47550 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2020-04-05 03:00:44 +00:00
parent 2e589142eb
commit 0b4e2c4604
140 changed files with 584 additions and 484 deletions

View File

@@ -9,7 +9,7 @@ require __DIR__ . '/wp-blog-header.php';
nocache_headers();
if ( is_array( get_site_option( 'illegal_names' ) ) && isset( $_GET['new'] ) && in_array( $_GET['new'], get_site_option( 'illegal_names' ) ) ) {
if ( is_array( get_site_option( 'illegal_names' ) ) && isset( $_GET['new'] ) && in_array( $_GET['new'], get_site_option( 'illegal_names' ), true ) ) {
wp_redirect( network_home_url() );
die();
}
@@ -169,7 +169,7 @@ function show_blog_form( $blogname = '', $blog_title = '', $errors = '' ) {
}
// Use US English if the default isn't available.
if ( ! in_array( $lang, $languages ) ) {
if ( ! in_array( $lang, $languages, true ) ) {
$lang = '';
}
@@ -438,7 +438,7 @@ function validate_another_blog_signup() {
$languages = signup_get_available_languages();
if ( in_array( $_POST['WPLANG'], $languages ) ) {
if ( in_array( $_POST['WPLANG'], $languages, true ) ) {
$language = wp_unslash( sanitize_text_field( $_POST['WPLANG'] ) );
if ( $language ) {
@@ -789,7 +789,7 @@ function validate_blog_signup() {
$languages = signup_get_available_languages();
if ( in_array( $_POST['WPLANG'], $languages ) ) {
if ( in_array( $_POST['WPLANG'], $languages, true ) ) {
$language = wp_unslash( sanitize_text_field( $_POST['WPLANG'] ) );
if ( $language ) {