From 0bc5d361c348b871ffdab5b87000cb81372995da Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Fri, 25 Feb 2022 14:08:53 +0000 Subject: [PATCH] Tests: Rename the `$success` variable to `$result` in the `wp_mail()` test for an empty home URL. The previously name could be a bit confusing if the function is expected to fail. Follow-up to [52799]. See #54730. git-svn-id: https://develop.svn.wordpress.org/trunk@52800 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/mail.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/phpunit/tests/mail.php b/tests/phpunit/tests/mail.php index 8bf0a083c9..718a585673 100644 --- a/tests/phpunit/tests/mail.php +++ b/tests/phpunit/tests/mail.php @@ -241,9 +241,9 @@ class Tests_Mail extends WP_UnitTestCase { // Single site test runs. add_filter( 'home_url', '__return_empty_string' ); - $success = wp_mail( $to, $subject, $message ); + $result = wp_mail( $to, $subject, $message ); - $this->assertFalse( $success, 'wp_mail() should have returned false' ); + $this->assertFalse( $result, 'wp_mail() should have returned false' ); $this->assertGreaterThan( 0, did_action( 'wp_mail_failed' ), 'wp_mail_failed action was not called' ); }