diff --git a/src/wp-includes/option.php b/src/wp-includes/option.php index fc2f8ddce1..c207c5ca1d 100644 --- a/src/wp-includes/option.php +++ b/src/wp-includes/option.php @@ -161,33 +161,6 @@ function get_option( $option, $default_value = false ) { $passed_default = func_num_args() > 1; if ( ! wp_installing() ) { - // Prevent non-existent options from triggering multiple queries. - $notoptions = wp_cache_get( 'notoptions', 'options' ); - - // Prevent non-existent `notoptions` key from triggering multiple key lookups. - if ( ! is_array( $notoptions ) ) { - $notoptions = array(); - wp_cache_set( 'notoptions', $notoptions, 'options' ); - } - - if ( isset( $notoptions[ $option ] ) ) { - /** - * Filters the default value for an option. - * - * The dynamic portion of the hook name, `$option`, refers to the option name. - * - * @since 3.4.0 - * @since 4.4.0 The `$option` parameter was added. - * @since 4.7.0 The `$passed_default` parameter was added to distinguish between a `false` value and the default parameter value. - * - * @param mixed $default_value The default value to return if the option does not exist - * in the database. - * @param string $option Option name. - * @param bool $passed_default Was `get_option()` passed a default value? - */ - return apply_filters( "default_option_{$option}", $default_value, $option, $passed_default ); - } - $alloptions = wp_load_alloptions(); if ( isset( $alloptions[ $option ] ) ) { @@ -196,6 +169,31 @@ function get_option( $option, $default_value = false ) { $value = wp_cache_get( $option, 'options' ); if ( false === $value ) { + // Prevent non-existent options from triggering multiple queries. + $notoptions = wp_cache_get( 'notoptions', 'options' ); + + // Prevent non-existent `notoptions` key from triggering multiple key lookups. + if ( ! is_array( $notoptions ) ) { + $notoptions = array(); + wp_cache_set( 'notoptions', $notoptions, 'options' ); + } elseif ( isset( $notoptions[ $option ] ) ) { + /** + * Filters the default value for an option. + * + * The dynamic portion of the hook name, `$option`, refers to the option name. + * + * @since 3.4.0 + * @since 4.4.0 The `$option` parameter was added. + * @since 4.7.0 The `$passed_default` parameter was added to distinguish between a `false` value and the default parameter value. + * + * @param mixed $default_value The default value to return if the option does not exist + * in the database. + * @param string $option Option name. + * @param bool $passed_default Was `get_option()` passed a default value? + */ + return apply_filters( "default_option_{$option}", $default_value, $option, $passed_default ); + } + $row = $wpdb->get_row( $wpdb->prepare( "SELECT option_value FROM $wpdb->options WHERE option_name = %s LIMIT 1", $option ) ); // Has to be get_row() instead of get_var() because of funkiness with 0, false, null values. @@ -203,10 +201,6 @@ function get_option( $option, $default_value = false ) { $value = $row->option_value; wp_cache_add( $option, $value, 'options' ); } else { // Option does not exist, so we must cache its non-existence. - if ( ! is_array( $notoptions ) ) { - $notoptions = array(); - } - $notoptions[ $option ] = true; wp_cache_set( 'notoptions', $notoptions, 'options' ); diff --git a/tests/phpunit/tests/option/option.php b/tests/phpunit/tests/option/option.php index d510528e07..a16a6431d9 100644 --- a/tests/phpunit/tests/option/option.php +++ b/tests/phpunit/tests/option/option.php @@ -100,6 +100,62 @@ class Tests_Option_Option extends WP_UnitTestCase { $this->assertSame( 1, $filter->get_call_count() ); } + /** + * @ticket 58277 + * + * @covers ::get_option + */ + public function test_get_option_notoptions_cache() { + $notoptions = array( + 'invalid' => true, + ); + wp_cache_set( 'notoptions', $notoptions, 'options' ); + + $before = get_num_queries(); + $value = get_option( 'invalid' ); + $after = get_num_queries(); + + $this->assertSame( 0, $after - $before ); + } + + /** + * @ticket 58277 + * + * @covers ::get_option + */ + public function test_get_option_notoptions_set_cache() { + get_option( 'invalid' ); + + $before = get_num_queries(); + $value = get_option( 'invalid' ); + $after = get_num_queries(); + + $notoptions = wp_cache_get( 'notoptions', 'options' ); + + $this->assertSame( 0, $after - $before, 'The notoptions cache was not hit on the second call to `get_option()`.' ); + $this->assertIsArray( $notoptions, 'The notoptions cache should be set.' ); + $this->assertArrayHasKey( 'invalid', $notoptions, 'The "invalid" option should be in the notoptions cache.' ); + } + + /** + * @ticket 58277 + * + * @covers ::get_option + */ + public function test_get_option_notoptions_do_not_load_cache() { + add_option( 'foo', 'bar', '', 'no' ); + wp_cache_delete( 'notoptions', 'options' ); + + $before = get_num_queries(); + $value = get_option( 'foo' ); + $after = get_num_queries(); + + $notoptions = wp_cache_get( 'notoptions', 'options' ); + + $this->assertSame( 0, $after - $before, 'The options cache was not hit on the second call to `get_option()`.' ); + $this->assertFalse( $notoptions, 'The notoptions cache should not be set.' ); + } + /** * @covers ::get_option * @covers ::add_option