From 101e686f7a3fd06860a8dd2cdfb8ed2c1fab9248 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Sun, 7 Aug 2022 14:48:42 +0000 Subject: [PATCH] Code Modernization: Remove dynamic properties in `Tests_File`. Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0. In this case, as the `$badchars` property never changes, declaring this as a class constant is the sensible option. As for the `$dir` property (which cannot be turned into a constant due to the function call), this is used in multiple tests, so making this property explicit makes sense. Follow-up to [139/tests], [53557], [53558], [53850], [53851], [53852], [53853]. Props jrf. See #56033. git-svn-id: https://develop.svn.wordpress.org/trunk@53854 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/file.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/phpunit/tests/file.php b/tests/phpunit/tests/file.php index 311ba30339..8e315e33aa 100644 --- a/tests/phpunit/tests/file.php +++ b/tests/phpunit/tests/file.php @@ -5,12 +5,14 @@ */ class Tests_File extends WP_UnitTestCase { + const BADCHARS = '"\'[]*&?$'; + + private $dir; + public function set_up() { parent::set_up(); $this->dir = untrailingslashit( get_temp_dir() ); - - $this->badchars = '"\'[]*&?$'; } /** @@ -137,7 +139,7 @@ class Tests_File extends WP_UnitTestCase { public function test_unique_filename_is_sanitized() { $name = __FUNCTION__; - $filename = wp_unique_filename( $this->dir, $name . $this->badchars . '.txt' ); + $filename = wp_unique_filename( $this->dir, $name . self::BADCHARS . '.txt' ); // Make sure the bad characters were all stripped out. $this->assertSame( $name . '.txt', $filename );