From 108574a053fddbb1c1f8481f394fd99f962d2aaa Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Mon, 3 Oct 2022 16:01:57 +0000 Subject: [PATCH] Build/Test Tools: Remove PHP 8.1 and 8.2 from allowed failures. With all known unit test failures now addressed, WordPress 6.1 aims to support PHP 8.1 and 8.2 as much as possible. While full compatibility with PHP 8.1 and 8.2 is still a work in progress, this commit aims to actively prevent new PHP issues from being introduced in WordPress core. All remaining known issues are deprecation notices. Please note, a deprecation notice is not an error, but rather an indicator of where additional work is needed for compatibility before PHP 9 (i.e. when the notices become fatal errors). With a deprecation notice, the PHP code will continue to work and nothing is broken. Follow-up to [49077], [49162], [50299], [51588], [51604], [53922], [54072]. Props jrf, desrosj. See #55652, #55656, #56009, #56681. git-svn-id: https://develop.svn.wordpress.org/trunk@54369 602fd350-edb4-49c9-b593-d223f7449a82 --- .github/workflows/phpunit-tests.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/phpunit-tests.yml b/.github/workflows/phpunit-tests.yml index 5d1de8f851..49493715b0 100644 --- a/.github/workflows/phpunit-tests.yml +++ b/.github/workflows/phpunit-tests.yml @@ -194,25 +194,22 @@ jobs: - name: Run PHPUnit tests if: ${{ matrix.php >= '7.0' }} - continue-on-error: ${{ matrix.php == '8.1' || matrix.php == '8.2' }} run: node ./tools/local-env/scripts/docker.js run php ./vendor/bin/phpunit --verbose -c ${{ env.PHPUNIT_CONFIG }} - name: Run AJAX tests if: ${{ ! matrix.split_slow }} - continue-on-error: ${{ matrix.php == '8.2' }} run: node ./tools/local-env/scripts/docker.js run php ./vendor/bin/phpunit --verbose -c ${{ env.PHPUNIT_CONFIG }} --group ajax - name: Run ms-files tests as a multisite install if: ${{ matrix.multisite && ! matrix.split_slow }} - continue-on-error: ${{ matrix.php == '8.2' }} run: node ./tools/local-env/scripts/docker.js run php ./vendor/bin/phpunit --verbose -c tests/phpunit/multisite.xml --group ms-files - name: Run external HTTP tests if: ${{ ! matrix.multisite && ! matrix.split_slow }} - continue-on-error: ${{ matrix.php == '8.2' }} run: node ./tools/local-env/scripts/docker.js run php ./vendor/bin/phpunit --verbose -c phpunit.xml.dist --group external-http # __fakegroup__ is excluded to force PHPUnit to ignore the settings in phpunit.xml.dist. + # This test group is not (yet) run against PHP 8.2 as there is no stable Xdebug version available yet for PHP 8.2. - name: Run (Xdebug) tests if: ${{ ! matrix.split_slow && matrix.php != '8.2' }} run: LOCAL_PHP_XDEBUG=true node ./tools/local-env/scripts/docker.js run php ./vendor/bin/phpunit -v --group xdebug --exclude-group __fakegroup__