vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 14:20:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve global variable setting in setup_postdata().

Browse Source 
`setup_postdata()` is responsible for setting a number of global variables
that are used for post pagination (`$pages`, `$page`, `$nextpage`) and the
generation of post excerpts (`$more`). These variables should be sensitive to
the currently running instance of `WP_Query` - rather than the main query -
so that these features work properly inside of secondary `WP_Query` loops.

This changeset moves the logic of `setup_postdata()` into a method on `WP_Query`,
and converts `setup_postdata()` to a wrapper.

Props boonebgorges, wonderboymusic.
See #25349.
Fixes #9256, #20904.

git-svn-id: https://develop.svn.wordpress.org/trunk@30085 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2014-10-29 02:31:37 +00:00
parent 7c4aada4a6
commit 114c1f32ba
2 changed files with 67 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
tests/phpunit/tests/query.php
View File

@@ -14,62 +14,6 @@ class Tests_Query extends WP_UnitTestCase {
$wp_rewrite->flush_rules();
}
/**
* @ticket 16746
*/
function test_nextpage_at_start_of_content() {
$post = $this->factory->post->create_and_get( array( 'post_content' => '<!--nextpage-->Page 1<!--nextpage-->Page 2<!--nextpage-->Page 3' ) );
setup_postdata( $post );
$this->assertEquals( 1, $GLOBALS['multipage'] );
$this->assertCount( 3, $GLOBALS['pages'] );
$this->assertEquals( 3, $GLOBALS['numpages'] );
$this->assertEquals( array( 'Page 1', 'Page 2', 'Page 3' ), $GLOBALS['pages'] );
}
function test_setup_postdata_single_page() {
$post = $this->factory->post->create_and_get( array( 'post_content' => 'Page 0' ) );
setup_postdata( $post );
$this->assertEquals( 0, $GLOBALS['multipage'] );
$this->assertCount( 1, $GLOBALS['pages'] );
$this->assertEquals( 1, $GLOBALS['numpages'] );
$this->assertEquals( array( 'Page 0' ), $GLOBALS['pages'] );
}
function test_setup_postdata_multi_page() {
$post = $this->factory->post->create_and_get( array( 'post_content' => 'Page 0<!--nextpage-->Page 1<!--nextpage-->Page 2<!--nextpage-->Page 3' ) );
setup_postdata( $post );
$this->assertEquals( 1, $GLOBALS['multipage'] );
$this->assertCount( 4, $GLOBALS['pages'] );
$this->assertEquals( 4, $GLOBALS['numpages'] );
$this->assertEquals( array( 'Page 0', 'Page 1', 'Page 2', 'Page 3' ), $GLOBALS['pages'] );
}
/**
* @ticket 24330
*
* setup_postdata( $a_post ) followed by the_content() in a loop that does not update
* global $post should use the content of $a_post rather then the global post.
*/
function test_setup_postdata_loop() {
$post_id = $this->factory->post->create( array( 'post_content' => 'global post' ) );
$GLOBALS['wp_query']->post = $GLOBALS['post'] = get_post( $post_id );
$ids = $this->factory->post->create_many(5);
foreach ( $ids as $id ) {
$page = get_post( $id );
if ( $page ) {
setup_postdata( $page );
$content = get_echo( 'the_content', array() );
$this->assertEquals( $post_id, $GLOBALS['post']->ID );
$this->assertNotEquals( '<p>global post</p>', strip_ws( $content ) );
wp_reset_postdata();
}
}
}
/**
* @ticket 24785
*